From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 970B4C25B74 for ; Thu, 30 May 2024 15:30:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 130636B0082; Thu, 30 May 2024 11:30:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E12A6B009D; Thu, 30 May 2024 11:30:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F11D16B009F; Thu, 30 May 2024 11:30:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D3D856B009D for ; Thu, 30 May 2024 11:30:39 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7FA8AA31B7 for ; Thu, 30 May 2024 15:30:39 +0000 (UTC) X-FDA: 82175449398.27.B834878 Received: from gentwo.org (gentwo.org [62.72.0.81]) by imf27.hostedemail.com (Postfix) with ESMTP id B582740022 for ; Thu, 30 May 2024 15:30:36 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=eAjtpJHp; spf=pass (imf27.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717083036; a=rsa-sha256; cv=none; b=i4o3+MtgKFd0D46Cfg0B8LNKXQKa4GITql9/Si+GbcUIe7+hAAjjD2j6O1ZuPWk15KoLbb WDn5j6QRVpBz+nYAjUFxP2PBWDPm/GP9fX0lWaLpItuhE5ohyHBuF2pXv7fpaLC94L/etx ctKiwesj8raCeW3s08/+n9kGZ4ZCekM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gentwo.org header.s=default header.b=eAjtpJHp; spf=pass (imf27.hostedemail.com: domain of cl@gentwo.org designates 62.72.0.81 as permitted sender) smtp.mailfrom=cl@gentwo.org; dmarc=pass (policy=reject) header.from=gentwo.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717083036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XeX6WqMXI5fca0ZxojJEQYByhD/51ohiIhi7Q0cyItA=; b=le1BkHSzzWUgY5g/TE9kXp7LlFgE8xE5mwyevQxaWIdME2J5+A5YyvRNg39xNwHSee1qiR qOJdncC4+ZoFicwD/LsIEIBFCp9VUdN+NWccezemomd/7AixghwpxJT9F/VEfiUu5jYnOs qN3EQXZXBd5wQPE7Hj578xZ1pqN5k0c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gentwo.org; s=default; t=1717082428; bh=PhD8vfWQu0fzYUGcN9chnT6h1Jccukmikqwpa2qBXcI=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=eAjtpJHpJYbnCqofA59amrPyn/YQpj9C/4aetzSjTKpYPvskNwTir9HyzdZeaQx1B i21UfQmlqJ19Z4Bc4L0++cvGtJ2ZZ7Q3OiLvuuMUp0tz3KZ7IHkpu6KlrlE53OfD+Q b0YjszmZ3lxw6gKLDrGPev9L7nCmauH82W3TH4bM= Received: by gentwo.org (Postfix, from userid 1003) id 41E0E40A77; Thu, 30 May 2024 08:20:28 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id 41008401D5; Thu, 30 May 2024 08:20:28 -0700 (PDT) Date: Thu, 30 May 2024 08:20:28 -0700 (PDT) From: "Christoph Lameter (Ampere)" To: Chengming Zhou cc: Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Feng Tang , linux-mm@kvack.org, linux-kernel@vger.kernel.org, zhouchengming@bytedance.com Subject: Re: [PATCH 1/3] slab: check the return value of check_bytes_and_report() In-Reply-To: <20240528-b4-slab-debug-v1-1-8694ef4802df@linux.dev> Message-ID: <4e4d45b5-c684-2d93-49d2-b179a088c2d5@gentwo.org> References: <20240528-b4-slab-debug-v1-0-8694ef4802df@linux.dev> <20240528-b4-slab-debug-v1-1-8694ef4802df@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-Rspamd-Queue-Id: B582740022 X-Rspam-User: X-Rspamd-Server: rspam12 X-Stat-Signature: cchip9z7qxmm65694ug96kex5agbk3nf X-HE-Tag: 1717083036-581516 X-HE-Meta: U2FsdGVkX1/tQN31PTEjBD0TGufgDJImefVPqD5l0tw1nuNfjQyPxFYsFyQvETv1NqXN8OxqSKOjesmcfADi/lb5Nm+m36TcUTWUGVSLzDYvshWTPoXCx54ZSE3RKNwQlZ2SzGxfPe8JZVWBSubOS32BOShH31C2zwGJTcI3Jfn1tl00WsHZPY/KQIsTUePjmg5k/0d/uMjGwdhErrolY3MlIdTO/gp5KmLmaJ8Qm5AkKZdZvrPu8v0aohWv+KMb4CTwOSCz+QwlpZ4oySDZWVaAvJr2gv5vKnpGxnKQsS7YZ1b/SIlTY8Avw7aRh6w/aCr1w9PTuxaNw53S9AC+/XAgN2ESnfA7wVzRrYO8F9PWLBI6Mv/yxNaa6jWzxFnCR9698k3jTjRXzDxvEguTIwlDHvrbCwmNoRIl93sKbT+XtFsOHAOAwRv0NzrvFDrQG16S1YHQn5h0bacj1j0mYev56hEgQp3RBYkUGW1XnWsxblEZtA4iNnwEBphH2f9C4ZakWsllMCNnad+p9q2l7j3QsLqnZjqWkMb6jzJ+PsMs1uMKXYmf0/fX+4xgquyCAFcIUzpbop8KjoeC2vlX7UBEZtU0cJWJ19yNmzOKmo45R5jxJz5XopKyTM7mw6Kb6BqeohjrUo2E04aW6V5OucRo2/VTxtuIRMYF6aHS+tW3LKQCu7DBQ0rTBxVIbgIn8kbVDi3086hsz/XMWgK3bPmcBUNwggwB+25bQjkaLFDpIoqsh2tonhXej8vaDSpGGNvpOfHb7xaFvtE5+RNUF5FEGUB44yYEwXrPTJw+npm5XkhbYHq5jhGgAgLEvz2ajfWfc3y/8jrI4Fky9zsEpM5XDc6d3WzoSEshDJPZIlv/7Pgx0I21hnRGRw5tj0YB0HJE1/4jywZTaDutYH7Pvae0pFL1fD08/yWP2ZqZXL0r1Ly8tsPLPu4E0sa/BBYWodGLlc+qc58JDYdXDYz U5/84SxX NoTM6J5EIw+ruTYtJUnTRTnCxnBjzXCZpYH4Q2MPljMWsnxyQhSnchUUpuLVz2/wvcwu+K8s2OiSEEpn7i4WnEMjauzPpkbZcA2Y7v4uRoSuos0NmtUAH76Lz6XeNp5B+OanLfOYw9mdlik3Ca2sHRk99HKmAg8vx41w7wBOpn5T5SsK1jX0oQUD9bHqLOtQrqCW2FDdOltyGsiHWaf8KLGpUH6IDRx4NzAmmBnSX88ViocYTLpxQFqcYDBpbGa65HBLmAIaNFistA58= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 28 May 2024, Chengming Zhou wrote: > diff --git a/mm/slub.c b/mm/slub.c > index 0809760cf789..de57512734ac 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -1324,9 +1324,10 @@ static int check_object(struct kmem_cache *s, struct slab *slab, > } > } else { > if ((s->flags & SLAB_POISON) && s->object_size < s->inuse) { > - check_bytes_and_report(s, slab, p, "Alignment padding", > + if (!check_bytes_and_report(s, slab, p, "Alignment padding", > endobject, POISON_INUSE, > - s->inuse - s->object_size); > + s->inuse - s->object_size)) > + return 0; > } > } This change means we will then skip the rest of the checks in check_object() such as the poison check.