From: "Christoph Lameter (Ampere)" <cl@gentwo.org>
To: Chengming Zhou <chengming.zhou@linux.dev>
Cc: Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Feng Tang <feng.tang@intel.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
zhouchengming@bytedance.com
Subject: Re: [PATCH 1/3] slab: check the return value of check_bytes_and_report()
Date: Thu, 30 May 2024 08:20:28 -0700 (PDT) [thread overview]
Message-ID: <4e4d45b5-c684-2d93-49d2-b179a088c2d5@gentwo.org> (raw)
In-Reply-To: <20240528-b4-slab-debug-v1-1-8694ef4802df@linux.dev>
On Tue, 28 May 2024, Chengming Zhou wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index 0809760cf789..de57512734ac 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1324,9 +1324,10 @@ static int check_object(struct kmem_cache *s, struct slab *slab,
> }
> } else {
> if ((s->flags & SLAB_POISON) && s->object_size < s->inuse) {
> - check_bytes_and_report(s, slab, p, "Alignment padding",
> + if (!check_bytes_and_report(s, slab, p, "Alignment padding",
> endobject, POISON_INUSE,
> - s->inuse - s->object_size);
> + s->inuse - s->object_size))
> + return 0;
> }
> }
This change means we will then skip the rest of the checks in
check_object() such as the poison check.
next prev parent reply other threads:[~2024-05-30 15:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 7:16 [PATCH 0/3] slab: fix and cleanup of slub_debug Chengming Zhou
2024-05-28 7:16 ` [PATCH 1/3] slab: check the return value of check_bytes_and_report() Chengming Zhou
2024-05-30 15:20 ` Christoph Lameter (Ampere) [this message]
2024-05-31 8:31 ` Chengming Zhou
2024-06-03 7:46 ` Vlastimil Babka
2024-06-03 8:05 ` Chengming Zhou
2024-05-28 7:16 ` [PATCH 2/3] slab: don't put freepointer outside of object if only orig_size Chengming Zhou
2024-05-28 13:05 ` Feng Tang
2024-06-03 9:25 ` Vlastimil Babka
2024-06-03 9:40 ` Chengming Zhou
2024-05-28 7:16 ` [PATCH 3/3] slab: delete useless RED_INACTIVE and RED_ACTIVE Chengming Zhou
2024-06-03 9:26 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e4d45b5-c684-2d93-49d2-b179a088c2d5@gentwo.org \
--to=cl@gentwo.org \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=feng.tang@intel.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=vbabka@suse.cz \
--cc=zhouchengming@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox