From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by kanga.kvack.org (Postfix) with ESMTP id 29C1D8E0001 for ; Mon, 24 Sep 2018 11:30:40 -0400 (EDT) Received: by mail-pg1-f199.google.com with SMTP id s7-v6so837146pgp.3 for ; Mon, 24 Sep 2018 08:30:40 -0700 (PDT) Received: from mga11.intel.com (mga11.intel.com. [192.55.52.93]) by mx.google.com with ESMTPS id t19-v6si901513pfm.152.2018.09.24.08.30.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Sep 2018 08:30:38 -0700 (PDT) Message-ID: <4e453720b77fd9c4dade6fcefc5b6f0eea396a1a.camel@intel.com> Subject: Re: [RFC PATCH v4 00/27] Control Flow Enforcement: Shadow Stack From: Yu-cheng Yu Date: Mon, 24 Sep 2018 08:25:51 -0700 In-Reply-To: <1ca5178d-60f3-ae70-ce95-7026ac0429b4@linux.intel.com> References: <20180921150351.20898-1-yu-cheng.yu@intel.com> <1ca5178d-60f3-ae70-ce95-7026ac0429b4@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Cyrill Gorcunov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue On Fri, 2018-09-21 at 15:53 -0700, Dave Hansen wrote: > On 09/21/2018 08:03 AM, Yu-cheng Yu wrote: > > The previous version of CET patches can be found in the following > > link: > > > > https://lkml.org/lkml/2018/8/30/608 > > So, this is an RFC, but there no mention of what you want comments *on*. :) > > What do you want folks to review? What needs to get settled before this > is merged? Thanks, Dave! These patches passed GLIBC built-in tests and more tests HJ and I put together at https://github.com/hjl-tools/cet-smoke-test. I made some changes since V3 as outlined in the cover letter. In particular there are two new patches for the VMA guard and preventing shadow stack merging. Does anyone have comments on those and the whole Shadow Stack/IBT series in general? Thanks, Yu-cheng