From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E235EC54E90 for ; Fri, 23 May 2025 03:47:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 452196B00A6; Thu, 22 May 2025 23:47:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 402BA6B00A7; Thu, 22 May 2025 23:47:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31A516B00A8; Thu, 22 May 2025 23:47:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 125966B00A6 for ; Thu, 22 May 2025 23:47:01 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 285F580F70 for ; Fri, 23 May 2025 03:47:00 +0000 (UTC) X-FDA: 83472786600.27.8DC9B8A Received: from m16.mail.126.com (m16.mail.126.com [220.197.31.9]) by imf15.hostedemail.com (Postfix) with ESMTP id A6EF9A0008 for ; Fri, 23 May 2025 03:46:57 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=j0CqrPB3; spf=pass (imf15.hostedemail.com: domain of yangge1116@126.com designates 220.197.31.9 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747972018; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BRlhWrT2SoYXDlWZPjcJEikz+rURnIHTSURTtEo/7GI=; b=IAS6YbwQ5sWk/sibryXJ9dkzMNiKPysndmVYB8GwLLGadkyDQtygwaM+TArXuI+5LfFE5X KN/J8PZSyChLnu73OxHxGEgJ0JguctvPLSTRRlAHzRkMjIEbV7XItu9PecLSlPNZmTDXe5 fdVnbcFCZILT5t56w5Bc1cyVgcxaCsA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=126.com header.s=s110527 header.b=j0CqrPB3; spf=pass (imf15.hostedemail.com: domain of yangge1116@126.com designates 220.197.31.9 as permitted sender) smtp.mailfrom=yangge1116@126.com; dmarc=pass (policy=none) header.from=126.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747972018; a=rsa-sha256; cv=none; b=lbeHYJhMMZmufbRSszzHO8lZdFBS/eAGph1VCA7dUviLpSf/E/Ae8cO11YM/ydzZ92PxXe ql/VUevIryjewhodUl6dVKeU6UARXjW7ZoHcSegI/pF5/F47AqK2SezGHd9M2dB+dbTTEI EkS/Fh5fJPg3QOyMwJiZP45rJIM9Pjs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=126.com; s=s110527; h=Message-ID:Date:MIME-Version:Subject:To:From: Content-Type; bh=BRlhWrT2SoYXDlWZPjcJEikz+rURnIHTSURTtEo/7GI=; b=j0CqrPB3BVJ2NkTWzNNJzTs2suu7ZY2L22yVmswZVziThaQUpJh9t9b4pblpVs IFWdrQZMU8ehbQTkmMo1ChtK6BuZdCzFHAaH3jZEaw+tacAVzITJ4PXLQxo8XlXs /SWybH5CWos2S04jMlGdC2HIdu7xn8Nax3cAAbQiaKIrg= Received: from [172.19.20.199] (unknown []) by gzga-smtp-mtada-g1-2 (Coremail) with SMTP id _____wD3Xyar7y9oVPJEAg--.40133S2; Fri, 23 May 2025 11:46:51 +0800 (CST) Message-ID: <4e408146-7c77-4f6d-90e8-bb311d7ab53d@126.com> Date: Fri, 23 May 2025 11:46:51 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/hugetlb: fix kernel NULL pointer dereference when replacing free hugetlb folios To: Muchun Song , Oscar Salvador Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, 21cnbao@gmail.com, david@redhat.com, baolin.wang@linux.alibaba.com, liuzixing@hygon.cn References: <1747884137-26685-1-git-send-email-yangge1116@126.com> <644FF836-9DC7-42B4-BACE-C433E637B885@linux.dev> <3B8641A1-5345-44A5-B610-9BCBC980493D@linux.dev> From: Ge Yang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wD3Xyar7y9oVPJEAg--.40133S2 X-Coremail-Antispam: 1Uf129KBjvdXoWruF1xWrykuFyrZry7Kr18Grg_yoWkGwc_ZF W0vas7Gw4UZFy0kF4DGrn0qF98Kw45ZF1YvFWrWrWUCFyftF95Xr98tr4fZwsrWa1jkF45 tw1Yva93Ar12kjkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU8OJ55UUUUU== X-Originating-IP: [112.64.138.194] X-CM-SenderInfo: 51dqwwjhrrila6rslhhfrp/1tbidRxWG2gv70MMjAAAsP X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: A6EF9A0008 X-Stat-Signature: gejya5heuaax9sgr1ynfwznn5nmq64zj X-Rspam-User: X-HE-Tag: 1747972017-487865 X-HE-Meta: U2FsdGVkX1/qQKwohuGu9BnfaVAtLwkZ70a2oHrvRujJg4i+6lQhu7Z1sn7lD4kPJmnkm6KIADHVZsCy98GjG0KB49HSHvhcFKnSe6RTlNcLa6sSRSlSYQTlqCtRQZ/95h7TsBflxtyjYmkTRolZdpWgaStmUrq4yB682rbC9XR2L4qB50yizrjd45TdpWrB3Bffvk+AOfpcPGZSLukdjm9Mbjyi6FM2GanS1IaHg4bdmMFuG7dt4B1W0uLWPs5eDfn4bMrABcuYz4rY86b3ZU+M+nEvtk0v0iJZEk7g+HM8NqSceNUJ/bipoMt6QSFPxqhwDke+bXvxgClnAyQMsGBWTPwqxaUmxAEj0Yqioo2w1SFmR9CN28FSKT8hGQKhMCXQQoftIYBu2M5xa9zGTo2/znAE5y+rtOt3n+xBzz9RRP7nb940dOlgpzPbD3tyug3j2GIgk9u3io4JhDBArO1Ucdadj/4o/nHXwQxFbN0btP8YKlLq08deKQq+6AYSuu7XpRGowBJE5NJUUn9f9iVzVxH/613ElYuj6HBo/6FfH5cv1lg+tKLTeiK3GNThX/A48D04lee1trc/v7BTbw8Xcwq8u7NcURXkS7vZP7ZTXIjzqnR07ToWcNZmxiW/oPr0zE3Sb2/q+4ILh7g5WmYGtRp8+9R4j/aRBGf1sR0o9nCAkcNmgM4RkqLvAhyYyr3uDE8+nnxr1U4bP7tM2TW1szbbwwUBmhaEr8cYOJl1eUXZ2toDDMLqfLCsctu1MVo85WB2UslPLLShWyhqMrGi5cjK4zn7drzJextsxQkO7CyWEqFn6+CB2O77bQ6KyWZH7bNxhniROxtoff94WbFwBCdWbMwJSx+PpDsyRnidj7NarLIj9pSJjIyHd2D0uZVZJE4X8yQwOg8DcZuMyJXt4oxd0REaDqOrjFn3dJoBMqNCs9xAESLvydjem1z7VkuIY9ftKPeCqHC3aOi ayyy0ffa wqOQLUwsF3C936Lh25MalIN3J2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/5/23 11:27, Muchun Song 写道: > > >> On May 23, 2025, at 03:32, Oscar Salvador wrote: >> >> On Thu, May 22, 2025 at 08:39:39PM +0800, Muchun Song wrote: >>> But I think we could use "folio_order() > MAX_PAGE_ORDER" to replace the check >>> of hstate_is_gigantic(), right? Then ee could remove the first parameter of hstate >>> from alloc_and_dissolve_hugetlb_folio() and obtain hstate in it. >> >> Yes, I think we can do that. >> So something like the following (compily-tested only) maybe? >> >> From d7199339e905f83b54d22849e8f21f631916ce94 Mon Sep 17 00:00:00 2001 >> From: Oscar Salvador >> Date: Thu, 22 May 2025 19:51:04 +0200 >> Subject: [PATCH] TMP >> >> --- >> mm/hugetlb.c | 38 +++++++++----------------------------- >> 1 file changed, 9 insertions(+), 29 deletions(-) > > Pretty simple. The code LGTM. > > Thanks. Thanks. The implementation of alloc_and_dissolve_hugetlb_folio differs between kernel 6.6 and kernel 6.15. To facilitate backporting, I'm planning to submit another patch based on Oscar Salvador's suggestion.