From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E866DCCA47B for ; Mon, 13 Jun 2022 10:51:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4CB786B012A; Mon, 13 Jun 2022 06:51:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 454938D0171; Mon, 13 Jun 2022 06:51:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2CD986B012C; Mon, 13 Jun 2022 06:51:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 197F66B012A for ; Mon, 13 Jun 2022 06:51:13 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B1A3734468 for ; Mon, 13 Jun 2022 10:51:12 +0000 (UTC) X-FDA: 79572895584.22.6025D42 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf25.hostedemail.com (Postfix) with ESMTP id 790A2A0088 for ; Mon, 13 Jun 2022 10:51:10 +0000 (UTC) Received: from dggpemm500023.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4LM7bq14W9z1K9Sb; Mon, 13 Jun 2022 18:49:11 +0800 (CST) Received: from dggpemm500014.china.huawei.com (7.185.36.153) by dggpemm500023.china.huawei.com (7.185.36.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 13 Jun 2022 18:50:47 +0800 Received: from [10.174.178.120] (10.174.178.120) by dggpemm500014.china.huawei.com (7.185.36.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Mon, 13 Jun 2022 18:50:45 +0800 Message-ID: <4e312b22-73ba-8d59-b494-b7cb1d7bbb49@huawei.com> Date: Mon, 13 Jun 2022 18:50:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 From: mawupeng Subject: Re: [PATCH v4 5/6] mm: Only remove nomap flag for initrd To: , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , References: <20220613082147.183145-1-mawupeng1@huawei.com> <20220613082147.183145-6-mawupeng1@huawei.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.120] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500014.china.huawei.com (7.185.36.153) X-CFilter-Loop: Reflected ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655117472; a=rsa-sha256; cv=none; b=f9Bmsww27JueBpqatg5UJcFNcjNZrvWwDpCTXvKKMQHGttsts0NrSNYAKvQyD5tnVhJVVk +1LHg6lf3+DatS5A5EQomkgrlWqomthesnPw3KTNZgx9zAu+lxD5f5vvgy5IwppasIQYhp vUs++sCfct/ACHlj1rQ4cDXyeVcd3KA= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655117472; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zPEhbe5jr6xljP5r16Njomy+ie2EsH16QxInbAetEbw=; b=6wcmp5Ii8eNZsHPuArnceJtT3L5NgGndX9FFJ3vOCOPS9kVDyBPZ/BEGC5i5gJ/7fsO1qI N5X8P9u/NfOj7H/6+rv5p4AkIv+NKYVt8JEvgyiEd59DI+EpVSZ8E27EY+MVLy+4LMI4Lr VsC/5ecJ2lBubkZtaU65q/CyvswwHrg= X-Rspamd-Queue-Id: 790A2A0088 X-Rspam-User: Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of mawupeng1@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=mawupeng1@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com X-Stat-Signature: 6iqh77fr94pt4ayh9y793hk4si3qrpnd X-Rspamd-Server: rspam02 X-HE-Tag: 1655117470-186616 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/13/2022 5:42 PM, Ard Biesheuvel wrote: > On Mon, 13 Jun 2022 at 10:00, Wupeng Ma wrote: >> >> From: Ma Wupeng >> >> Commit 177e15f0c144 ("arm64: add the initrd region to the linear mapping explicitly") >> remove all the flags of the memory used by initrd. This is fine since >> MEMBLOCK_MIRROR is not used in arm64. >> >> However with mirrored feature introduced to arm64, this will clear the mirrored >> flag used by initrd, which will lead to error log printed by >> find_zone_movable_pfns_for_nodes() if the lower 4G range has some non-mirrored >> memory. >> >> To solve this problem, only MEMBLOCK_NOMAP flag will be removed via >> memblock_clear_nomap(). >> >> Signed-off-by: Ma Wupeng > > Reviewed-by: Ard Biesheuvel > > This needs and ack from the arm64 maintainers, please? > And also please fix the subject to include 'arm64' > Ok, I will include 'arm64' in my subject in v5. Thanks for reviewing. > >> --- >> arch/arm64/mm/init.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c >> index 339ee84e5a61..8456dbae9441 100644 >> --- a/arch/arm64/mm/init.c >> +++ b/arch/arm64/mm/init.c >> @@ -350,8 +350,8 @@ void __init arm64_memblock_init(void) >> "initrd not fully accessible via the linear mapping -- please check your bootloader ...\n")) { >> phys_initrd_size = 0; >> } else { >> - memblock_remove(base, size); /* clear MEMBLOCK_ flags */ >> memblock_add(base, size); >> + memblock_clear_nomap(base, size); >> memblock_reserve(base, size); >> } >> } >> -- >> 2.25.1 >> > .