From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B9F1C3ABC3 for ; Sun, 11 May 2025 12:33:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7107A6B0083; Sun, 11 May 2025 08:33:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6992C6B0085; Sun, 11 May 2025 08:33:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EBFA6B0088; Sun, 11 May 2025 08:33:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2D2746B0083 for ; Sun, 11 May 2025 08:33:46 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id DBA3CBF672 for ; Sun, 11 May 2025 12:33:46 +0000 (UTC) X-FDA: 83430568452.02.1999F01 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf06.hostedemail.com (Postfix) with ESMTP id 5C9E2180006 for ; Sun, 11 May 2025 12:33:44 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=kuAqiIFH; spf=pass (imf06.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=kuAqiIFH; spf=pass (imf06.hostedemail.com: domain of donettom@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=donettom@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746966824; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JSETHQw68fWqmiPJ7zxQFvWWNMk2RZqAjOt+3JqfXmc=; b=gLw6J9FPa8oM94UdsPgmDUlyQbl1CbrQLBoJo7D5l1MiZSqL3ffi3xDy2KqO+Sc1ze4RPU w/GCYAT7po9CG2Ns1tfF2inCEiUOrtGo8EqL91b3nSqyb0Vx4MAnBIFHIX+ny+jzKqRFeK f1GPKhO3m0M9LFwOkBKnudjqjV3tRAo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746966824; a=rsa-sha256; cv=none; b=mbz4J+kOWkL+TqPaaV7No6TcHvjgd9jcBqKNi1pe4p+w3kCsHI3nEXeZhRrIBVti3pEjIn i6LeHb8rLJGMN1xr5DoAocLkGZQOxeaWveGBlnWh8k6W7/tmgwq5JsSg0dsKZsbDZdiL/Y A/LqlBW4C/8zXqRP9knqNj76GqKss5U= Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 54B1s8vN001308; Sun, 11 May 2025 12:33:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=JSETHQ w68fWqmiPJ7zxQFvWWNMk2RZqAjOt+3JqfXmc=; b=kuAqiIFH+YB6H3JFsLnj1z fnlA0AL7LSzOX9ahg+F2nTy2HaoYhLz4GCkxW7VcyqJ4SOgvA7/w+o3GQOyAaSSv mIOa4LE6k6GdqVqdAjueKcPuZzxNCglYB9bbIhvTVPeYR9TJ00ezAJlhs+Jp8dDa ApUYTRffUuPy2o+P8k+9OGQkJJGDmjOgmetBCas/VlmKvqWcWyyfZ1Sg8o1rM12S zjZRbNtuYFnvrlvFDuX6YCBUxO5vgKey9GT6yMLZGGGPHCND253mDJZZlGyy3P2+ cphf/aPWFZfemgcBrJCvqBsX1DepPfSp2/ettESaeKVf7R2h1Wtas3jAEznhYf/Q == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46jcg6hrrd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 11 May 2025 12:33:30 +0000 (GMT) Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 54BCXTJp008331; Sun, 11 May 2025 12:33:29 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 46jcg6hrrb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 11 May 2025 12:33:29 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 54BCGZxm016981; Sun, 11 May 2025 12:33:29 GMT Received: from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 46jhgystb7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 11 May 2025 12:33:29 +0000 Received: from smtpav02.wdc07v.mail.ibm.com (smtpav02.wdc07v.mail.ibm.com [10.39.53.229]) by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 54BCXSx348824616 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 11 May 2025 12:33:29 GMT Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CEFE15805C; Sun, 11 May 2025 12:33:28 +0000 (GMT) Received: from smtpav02.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3762158058; Sun, 11 May 2025 12:33:23 +0000 (GMT) Received: from [9.124.211.114] (unknown [9.124.211.114]) by smtpav02.wdc07v.mail.ibm.com (Postfix) with ESMTP; Sun, 11 May 2025 12:33:22 +0000 (GMT) Message-ID: <4e20d51e-ab22-4aeb-860f-9cdff0fb47c4@linux.ibm.com> Date: Sun, 11 May 2025 18:03:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] driver/base: Optimize memory block registration to reduce boot time To: Mike Rapoport Cc: Andrew Morton , Oscar Salvador , Zi Yan , Greg Kroah-Hartman , rafael@kernel.org, Danilo Krummrich , Ritesh Harjani , Jonathan Cameron , Alison Schofield , Yury Norov , Dave Jiang , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <188fbfba-afb4-4db7-bbba-7689a96be931@redhat.com> <74c500dd-8d1c-4177-96c7-ddd51ca77306@redhat.com> <8180a50d-eebe-4f9b-9ce8-d886654a992d@redhat.com> <78bc6a1b-164e-4925-a624-a271a4499364@redhat.com> Content-Language: en-US From: Donet Tom In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNTExMDEyNCBTYWx0ZWRfX2CpuGf4v5CSK ibEl+qmz850PvcB9N8MwsNvoR/2WEjfaY+IdWkZv5kWO4mLFUuR11xbGNfUEpQi2dvuzZhskldc g56RvR8jxqxjR9Vle81UJGOQ3tII93WIMCv40NypqIRmE1g4I8nSfPdXT9SlLUr9GG7hKG24MaP 5wmGV5XPFn02izoKNL3k1mQHlbpscvD9hjb60t9O/ZqBp3br7EgKeXlRw4Y0kY5hEt9ZzwGWq9Y ySldUSfMxrPpUa4xixFVEaJnhT39NONmsB+Vb6LYUTAftZKSVK45PS0wO8enTaCZJ0oW6wxtur8 RxIPsbrmYiVtrvWrD+nxz00d13k9xZ9jK9o299W6WIl8anm7jsMN7EoCuvlG/yWgD3pCmGNi0dr smg2aaoEs9aBtP4AH0wILUyLwW4jenJaQUlol6n2jNcBP40OnvSVdI1aBclH0nmsQ1hjxLdg X-Proofpoint-ORIG-GUID: 6x1NuWXw_bHZ1cXI72-n8ZTA7aCwbrcA X-Authority-Analysis: v=2.4 cv=IY+HWXqa c=1 sm=1 tr=0 ts=6820991a cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=IkcTkHD0fZMA:10 a=dt9VzEwgFbYA:10 a=WoPLYqF27UWALN4nqQcA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-GUID: hfEXWv_Tl_AsdY8yTKoCTtKYijQN2vJw X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-05-11_04,2025-05-09_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=799 suspectscore=0 clxscore=1015 priorityscore=1501 mlxscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 malwarescore=0 adultscore=0 spamscore=0 phishscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2505110124 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 5C9E2180006 X-Stat-Signature: nahg1g7u911uuimff3wykdywt1eu1b3x X-Rspam-User: X-HE-Tag: 1746966824-335011 X-HE-Meta: U2FsdGVkX18C6T6B2C9TT0Po/gLgbjdrHRptUl8F2C4wvF5HulW1QzlJaWIH+2CFsn3ribMg7+xwxrBJv9WbbkA+h7eLqgt02NUR759ibJd4AI+4pi1ZPA6Kn9Z3Gs5W5dk6UdQQj6zeZ2ydcsSFocGyzVde63RItrlIVrDBVeOvDrhb2ED8bJzxDy243BMRzm1VmvOlKpra1vy2MLqM/O6vRM3CzcHKxIwgBZ+xWWvl0KQ6Ca7vI8nCZc3gEALsyFC1rI9LvQZgYPYUynD15RDS3ewfWPrYcghCIciYv7Iv+lfdcwO1paI+I2Nm+uBRUFIQ3rZ0JhqgmNG5Gmws/HN3lPkjgQbrw6oWENr1rquugqLMVNGp2+1p0/ktoHw8g10ljB8cU9GyVnfOMwmJaI3Fc/nTocoPDQ9mK/8Hx3L0AfS1pM5lwMV0bDO9NTiFGpRqdjGnQB1bYuxRPe8vi+zt+hICDgtxwqDPQtzYNP1UXnj5KRI0GhHpqEAHLt3CXJyz2hbgXueoKSrV1X+rcgdeIncFK5HSsdXRwOoSKK3LCk/sOnfNaE+TLG0m1GCsAqH0GBKp/GlLmT3cFxtmy5HR0xgk/yhX812WPNUfSRarg8ThpMDV2vLTnJUva/gteJZ2Y52HkJ6SlpCulIGFp9LcjznIPMtGjFJWh6BTHqMV00f0/1RHAS//8MFiO4wwCwP/WnJOBZH0i7BYE4E7ILAHmDVRwL+PccEkdJzKeNLNvJe1uwjdFFIST2HjfkDasGEh8m7zdDLXwUQbbbmnzt+BwarzW5jN/JlkGJCfWG/LA0sdaj4ROOqIhAshJsROkt/PD/E78rXTNNjB875mnxC1w8y7bBMZQ0YHg9PJ1Qk1bFA/Sqs1nqzDEDyeEFcZT1xchQsIgG4/YM0OT66Xm50YylLyBS1h5M6JgHbmnLI+iD8nqlrx7owdDvFLvEudSyl/WrIYcwhOZB+IV/G 4L8Vvoxn QW7T77WggcKCLD9TRWApei6z1B+VBtEDwucGooZmr1n4NXFKg8CgJOk6UMkBozAHFNyCI7MDqbd8uo0YnF3fRAdiLQgsddXFR91W8h97tqYav6s/uhwgRQHpFyDiObIM1ZfIxbFe8yEONzypLtPDBj+RVagIPEF7M5n9QZ+7JyX22OghwUOXoX1V7SIbF2f8rzYJPTyc2891v50WViffYauC07294L6QPVs8jNhwYq2KVWRHueDAADDNejv1eplHxbOi98+DJgzkTKJQsL4Iys3MiLEcR5WzlAfT5tYszK+Ehg5IgpWRu53CFKAlnCN5sHecDIV4hxctuyVo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/11/25 11:09 AM, Mike Rapoport wrote: > Hi Donet, > > On Fri, May 09, 2025 at 09:10:34PM +0530, Donet Tom wrote: >>>> Then we can drop the call to register_memory_blocks_under_node() from >>>> register_one_node() and add creation of memory blocks to >>>> node_dev_init(), >>>> i.e. >>>> >>>> node_dev_init() >>>>    for_each_node(nid) >>>>      __register_one_node(nid) >>>>        for_each_mem_region() >>>>          /* create memory block if node matches */ >>> Yes exactly, that makes sense. >> Hi Andrew and Mike >> >> Based on the discussion so far, it is clear that the patch will work in all cases, >> including when CONFIG_ARCH_KEEP_MEMBLOCK  is disabled. Just checking — >> would you prefer to take this version, or should I send a v4? > During the discussion we concluded that the right thing to do seems to drop > the call to register_memory_blocks_under_node() from register_one_node() > and make node_dev_init() call __register_one_node() and then create memory > blocks for each memblock region. > > Can you please make v4 along those lines? > Sure, I will do that. Thank you. > >> Thanks >> Donet