From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3135D44162 for ; Tue, 19 Nov 2024 14:36:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C2C66B0088; Tue, 19 Nov 2024 09:36:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7724B6B00AD; Tue, 19 Nov 2024 09:36:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 615996B00B0; Tue, 19 Nov 2024 09:36:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4326C6B00AD for ; Tue, 19 Nov 2024 09:36:45 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id F1FB74053C for ; Tue, 19 Nov 2024 14:36:44 +0000 (UTC) X-FDA: 82803093786.27.35A3166 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf03.hostedemail.com (Postfix) with ESMTP id 85D8D20002 for ; Tue, 19 Nov 2024 14:36:19 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="XS/eOi29"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eUqtteDP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="XS/eOi29"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eUqtteDP; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732026936; a=rsa-sha256; cv=none; b=RfAtwHmOFpZXXr+qGi6b1f/DHgKwXiZEuZSkdmUplcM4Ggljk9jNzzrUPxNYT/QULaW1Z5 EbdCKxesKf6ZShztQhAAwzIGgTLsbrNyr7OTEKmKAoYq2FyupK5zzLfXmr8OtrtKcQgyqI wy1Fh83zrEOj9oC+nWWQQNXnSk+QrE4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="XS/eOi29"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eUqtteDP; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b="XS/eOi29"; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eUqtteDP; dmarc=none; spf=pass (imf03.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732026936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=78eK/xKpdwzTo490zBwaeaASTrV1q2qFVo+vGv2j2EY=; b=dLcomkkCM4atiMCnzTUXItAWmnMWYjZLa+vJ+NZxs/+2WEVlMNIC1d5pGhX6/56Pd/waB8 wzyLChYp8v0YbPLb5mZE7GlmL/RCUg3YLUA9pY9MbQvxtYe+4M8dXl336i39gvqONOs8MK A0omFmNwrcuu+nF0L2PEpYhEeqJ30ts= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 939111F79C; Tue, 19 Nov 2024 14:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732027000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=78eK/xKpdwzTo490zBwaeaASTrV1q2qFVo+vGv2j2EY=; b=XS/eOi29YM+fIQ9X7m8uzOJazsp2yRukUlaP39A0JKyQS5fVOJoSnu+GmR1qPvySSTAey2 xCwWmOZEPDqTyxQ9mZrHrgsJtogyYqXaEv/lZ93dvGHzev4GD4lg1p5yY3ahZ9iXe5NWFI m7SRsHTOO+r6LPBzruE4zPLjl2wsNLw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732027000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=78eK/xKpdwzTo490zBwaeaASTrV1q2qFVo+vGv2j2EY=; b=eUqtteDPog95VnW0zKN8G9xJVLVhuqGTaGHqp5g8JUpCBeGrleL4hhw5HLKuvvzGNR7wVD 3OC+344GUfIMlyCg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732027000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=78eK/xKpdwzTo490zBwaeaASTrV1q2qFVo+vGv2j2EY=; b=XS/eOi29YM+fIQ9X7m8uzOJazsp2yRukUlaP39A0JKyQS5fVOJoSnu+GmR1qPvySSTAey2 xCwWmOZEPDqTyxQ9mZrHrgsJtogyYqXaEv/lZ93dvGHzev4GD4lg1p5yY3ahZ9iXe5NWFI m7SRsHTOO+r6LPBzruE4zPLjl2wsNLw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732027000; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=78eK/xKpdwzTo490zBwaeaASTrV1q2qFVo+vGv2j2EY=; b=eUqtteDPog95VnW0zKN8G9xJVLVhuqGTaGHqp5g8JUpCBeGrleL4hhw5HLKuvvzGNR7wVD 3OC+344GUfIMlyCg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7B61F1376E; Tue, 19 Nov 2024 14:36:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ytF/HXiiPGeWEQAAD6G6ig (envelope-from ); Tue, 19 Nov 2024 14:36:40 +0000 Message-ID: <4e10f9e9-11e7-4f02-88b7-47102197e93a@suse.cz> Date: Tue, 19 Nov 2024 15:36:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6.12.y] mm/mmap: fix __mmap_region() error handling in rare merge failure case Content-Language: en-US To: "Liam R. Howlett" , Greg KH , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Lorenzo Stoakes , Jann Horn , syzbot+bc6bfc25a68b7a020ee1@syzkaller.appspotmail.com, stable@vger.kernel.org References: <20241118194048.2355180-1-Liam.Howlett@oracle.com> <2024111935-tabasco-haziness-b485@gregkh> <6m2hn4wzvvgozrrvvivy6brxiafx6g2qaedkrcicxnmflcopzg@7idyf4fuymff> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <6m2hn4wzvvgozrrvvivy6brxiafx6g2qaedkrcicxnmflcopzg@7idyf4fuymff> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Queue-Id: 85D8D20002 X-Rspamd-Server: rspam01 X-Stat-Signature: f6tue871g1pq6ahuom5ytzetxyze89se X-HE-Tag: 1732026979-446199 X-HE-Meta: U2FsdGVkX18SjF/nPCqfyEmnKEMgPJuEekoFzYOeHPrBD914oZy6Md89sVoDvwAEXq55ReKTrRN51EHGCm4I2kfE3zlBVjZyw5T4PPBdAMbnC2Iiv2BFWiIG7kaWRaiwtyKlzWypvB4ATs5FjaGpC6pss5lOzn3u6Sa3hi5G1L1a9D9HXKzw8ZPEyOrXzJlIB3r4JlIE5MYXSPrdqjStpzzyvDWY+GRoFeWZNEGLaa0+DdxUHXkzB5LJCgD5i8omvwRQNnxyinIWG4FsOfRpltGSIX/noqKFQnGJ7riYJe20eYDCCbK7lAJY3z+pf8UbzkdVtnalqdrvlfrRwgQqk1iX9Ea/nl04URtVP+HBMQbkgFM2zrnxX5VWrB9Z3pos5a7gJ/Ndho+7vmc2hgIRRGhYWdYZD6qTLAAJ/2jw6vu84RaG+NIrXgkZ7xgawqVKxuJsdaSBNnmL5rbdMdGJDX5ThFoNF+aNjWT/NN0AIwRYI4n0wknONVuz1Vdq2tR/nghI9XZPhTLC89hn7igSubxzPLxpK1f4Xd+jQ08cFgLU3S1Rk4prTfJIuoYHGNkBGsgsKjaxUjeEjdEj3itBXF8h9SerA+TRWG1+LUF7gR/9b0fF1blelKt5vjvzLag+Hkg9F3Uno3VFrr9hGVH3ZDoEQU0s2MdSz1XOVRJz0CO4gYoXcMc/GAVQNg/RO2GIe14AKYtD+qiEhjNbi97iDurEglgnnIGzkM3Z1s6ehvb678eynqyZ2AW++0HNf6oj6xqlFPFFwqyq390S2wf+S0kqIqoddfdh3lY7oagzm7dBWWW60fq3NtHao48w/wit+I8LYjTLyo4PJCPxMOienK9BYvJVXdsXkok/JbNLABdyn7b2WaXXUhONOF3sne+1aW00AspG+VzxAtK9kFG/PWbscXgU80cetk50YQR0BAhOQAf/vE4339q4VhHrh5iPIjim9EbewNc9iN0jCth 64telKEq ziS/QJZqV5PKu+MzvxM4uVFY/4c5Tf/WybzfshJORvs3WdotQs/V5NpoddZjRXXLi47oLiiNiUJDFTpn86YYKIqqszdjJvJCyREXZBvmqWOjrtVek9iEw4AEvd8uI0lZzRqTiyZ9uT8VxyB5+Wihd6/2JVoMj4fTfCLYZMBkVBvX0cuwwSUFqY+S6IfPP9o4GrU8Zz+6QO9ikRTHsjrbK0C0KJgP2M2KhJUqA/Rt5u1t7nXSork7ikhvp4rIumHZ0SbOSrmM+TyevHhWGraUltUbh5vuUN7ubuNBYbg2SuFdAbE8XqkBP6gXsh5SUDBv3QWVEBb0NJ+rGNo47i+snkBeyURtS7D55onU9HKFqk1eJ3RM/WECRTqhg4rpmIHEMe+T183lU0OxrJKCIPl8oBlyUeR4c2zqRuth+n02HnhSnqrr8bvRBnD97z7W8NYeQaOcxRnLPxMsYLT90RTjPRuHOiIzLKQBPJzbL6IBnzyU874A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/19/24 15:25, Liam R. Howlett wrote: > * Greg KH [241119 09:17]: >> On Mon, Nov 18, 2024 at 03:32:14PM -0500, Liam R. Howlett wrote: >> > Okay, before I get yelled at... >> > >> > This commit is only necessary for 6.12.y until Lorenzo's other fixes to >> > older stables land (and I'll have to figure out what to do in each). >> > >> > The commit will not work on mm-unstable, because it doesn't exist due to >> > refactoring. >> > >> > The commit does not have a tag about "upstream commit" because there >> > isn't one - the closest thing I could point to does not have a stable >> > git id. >> > >> > So here I am with a fix for a kernel that was released a few hours ago >> > that is not necessary in v6.13, for a bug that's out there on syzkaller. >> > >> > Also, it's very unlikely to happen unless you inject failures like >> > syzkaller. But hey, pretty decent turn-around on finding a fix - so >> > that's a rosy outlook. >> >> Why isn't this needed in 6.13.y? What's going to be different in there >> that this isn't needed? > > The code has been refactored and avoids the scenario. I'd name the > refactoring commit as the upstream commit, but it does not have a stable > git id as it's in mm-unstable. So I'm at a bit of a loss of how to > follow the process. Is it not in mm-stable now, given we're in a merge window? Anyway AFAIU if the stable-specific fix is completely different from the upstream refactoring, we don't even try to pretend it's the same "commit XYZ upstream" no? >> >> Do you just want me to take this for the 6.12.y tree now? I'll be glad >> to, just confused a bit. > > Yes, please. > > > Thanks, > Liam