From: Vlastimil Babka <vbabka@suse.cz>
To: "Liam R. Howlett" <Liam.Howlett@oracle.com>,
Greg KH <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Jann Horn <jannh@google.com>,
syzbot+bc6bfc25a68b7a020ee1@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH 6.12.y] mm/mmap: fix __mmap_region() error handling in rare merge failure case
Date: Tue, 19 Nov 2024 15:36:40 +0100 [thread overview]
Message-ID: <4e10f9e9-11e7-4f02-88b7-47102197e93a@suse.cz> (raw)
In-Reply-To: <6m2hn4wzvvgozrrvvivy6brxiafx6g2qaedkrcicxnmflcopzg@7idyf4fuymff>
On 11/19/24 15:25, Liam R. Howlett wrote:
> * Greg KH <gregkh@linuxfoundation.org> [241119 09:17]:
>> On Mon, Nov 18, 2024 at 03:32:14PM -0500, Liam R. Howlett wrote:
>> > Okay, before I get yelled at...
>> >
>> > This commit is only necessary for 6.12.y until Lorenzo's other fixes to
>> > older stables land (and I'll have to figure out what to do in each).
>> >
>> > The commit will not work on mm-unstable, because it doesn't exist due to
>> > refactoring.
>> >
>> > The commit does not have a tag about "upstream commit" because there
>> > isn't one - the closest thing I could point to does not have a stable
>> > git id.
>> >
>> > So here I am with a fix for a kernel that was released a few hours ago
>> > that is not necessary in v6.13, for a bug that's out there on syzkaller.
>> >
>> > Also, it's very unlikely to happen unless you inject failures like
>> > syzkaller. But hey, pretty decent turn-around on finding a fix - so
>> > that's a rosy outlook.
>>
>> Why isn't this needed in 6.13.y? What's going to be different in there
>> that this isn't needed?
>
> The code has been refactored and avoids the scenario. I'd name the
> refactoring commit as the upstream commit, but it does not have a stable
> git id as it's in mm-unstable. So I'm at a bit of a loss of how to
> follow the process.
Is it not in mm-stable now, given we're in a merge window? Anyway AFAIU if
the stable-specific fix is completely different from the upstream
refactoring, we don't even try to pretend it's the same "commit XYZ
upstream" no?
>>
>> Do you just want me to take this for the 6.12.y tree now? I'll be glad
>> to, just confused a bit.
>
> Yes, please.
>
>
> Thanks,
> Liam
next prev parent reply other threads:[~2024-11-19 14:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 19:40 Liam R. Howlett
2024-11-18 20:32 ` Liam R. Howlett
2024-11-19 14:17 ` Greg KH
2024-11-19 14:25 ` Liam R. Howlett
2024-11-19 14:36 ` Vlastimil Babka [this message]
2024-11-19 14:59 ` Lorenzo Stoakes
2024-11-19 15:16 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e10f9e9-11e7-4f02-88b7-47102197e93a@suse.cz \
--to=vbabka@suse.cz \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+bc6bfc25a68b7a020ee1@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox