From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 855EBC83F1A for ; Mon, 14 Jul 2025 18:54:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFF6A8D0010; Mon, 14 Jul 2025 14:54:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C893F8D0001; Mon, 14 Jul 2025 14:54:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B50CD8D0010; Mon, 14 Jul 2025 14:54:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9F6D68D0001 for ; Mon, 14 Jul 2025 14:54:32 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3134CC026E for ; Mon, 14 Jul 2025 18:54:32 +0000 (UTC) X-FDA: 83663771184.01.04EADD5 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf04.hostedemail.com (Postfix) with ESMTP id C5BDC40007 for ; Mon, 14 Jul 2025 18:54:29 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i2WVxjyV; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752519269; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ciLGAThMMREY2h/4HHyWdJ++xPniwYsASm//Au0nZ9I=; b=sRgw65ixRyoTPUFwJ9Hs/aXJJHjQVeL7i4BBlGa3g+m4dnv5D8+M0vBHal/OSWOoyUn6Zr u47Pq1s2ePW5GyJoxA5WlzBhWt3tRxrL/6cui4Qy0PprINfkCePO3ukmfu7q/lTfpNDLaw nw2KYGWS3Xjge71dUJnjxbFLpCfCYIA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752519269; a=rsa-sha256; cv=none; b=Frfgg80WGGqCAsHKoGwxPGA+MkCg5bM/PoX0fSRqo+BeOafbtr+KlrJWBGuKnMXZQ6eiMz 7l2UC7ofF4w7wqSF+uJbMMRbQ0KkCRW6Dr4a18LjnwqfkSPvAG6+871zzK/FpcylyAnW26 UmUGJ4VtfS0v7g07VOt40HfVY2FBD7E= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=i2WVxjyV; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752519269; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ciLGAThMMREY2h/4HHyWdJ++xPniwYsASm//Au0nZ9I=; b=i2WVxjyVaG/JW4sAmE9/n34l4fLCQ7V0RV3RUjXrQbRdFFHY3tDTZRMW9PYZhVdXnQPUJm 2eHeL0goAcbsqSVxRze8/bIwe74NBeaP3VKeqotX8H3s46phwfrL1pHDYYlbgvIxyJ841G gAtkj0UX9/jtIyR1ZF1k7tMctUQkdX4= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-190-Vd6omsB6PaujhGzk73e9AQ-1; Mon, 14 Jul 2025 14:54:28 -0400 X-MC-Unique: Vd6omsB6PaujhGzk73e9AQ-1 X-Mimecast-MFC-AGG-ID: Vd6omsB6PaujhGzk73e9AQ_1752519267 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3b39cc43f15so2564196f8f.2 for ; Mon, 14 Jul 2025 11:54:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752519267; x=1753124067; h=content-transfer-encoding:in-reply-to:organization:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ciLGAThMMREY2h/4HHyWdJ++xPniwYsASm//Au0nZ9I=; b=vWzfcYvrMf4qQa95ivUxkQMROn5JB5AV1TvsLwb1aRKd/matRGyO8Uin2xD/m7YR/w BwBUeriDCFz0EBjg0mR1/QSGvU4jUBiCoBLR6x9Wt4mq4EXMySrCcO2zbaCq4euiJYxM WPjrzVsBCDc7LFQ8w1Ln3Cq2tbY+SjBKA0YEKtvZAgLUdcF0S9XfilrPgfJgaPqt32Y4 lkR239Vd/N3wBMdXxjx+Q/j8ULlkG/nrNVu1i608fxvgfVqBPkCYsWRy/8+ogShyenG/ avp0EkUKE3/BOLq3tY64ziY5Hm025C6ZSCzR22boh4AvalAmiJMGwY69Q6zkj7/O8kxs RxWA== X-Forwarded-Encrypted: i=1; AJvYcCU2arlQsN+LY9EjHnmKiULw+VehDJMIQZdf9bRSKkl/+qhYt+mGjX7VdbTz5o0iFx/GEiJz05TiPw==@kvack.org X-Gm-Message-State: AOJu0YyrPFcIuOwPmJNAnjRRVe3RrekBH+bYWK/eWPSz15ZfH4oMVvu/ 9833rCYxuuJx+StGbWo5BBT+hDYhZ9ynJbXKHSuTZj4isddCCT588/d2hdG4YWp7Tbh8pHsXtc2 zW3AIQBLkD0Kh6YpbfAkZkTZLBTZoee6NxBDlxCA4uqZWrIt5YA0X X-Gm-Gg: ASbGnctXrOLJbk2QQPZp5B/WlNwv36NQYKYRMNeZHmodJjd80Mz/Z+AXDHH9LMAeQzW 4Q34VNvZc3FwNiuEdV6wcIRQeL7c1df57ePO6zzQRGDYtOfnD7pdpd54G+JjTAYZIUvyawJNsGp 690CnaNHvFY7vlPj8ZQhEsPRQeFArwzAxl58YywZYb7KCx8YK8VAHASQ4F5VEa2XbAPmYG4r8Vq 5eLpBcXK1dfV/uMTpMEprLUmryLIYMaQLbC/fO+6/WpvM/aF4ogTDLe/eB2qQzV5dBqsOovR70+ sOH9rGyEs2SR5FGg7o0e6/FybD4TyBv2n5QIiGcc0P0RnMZ00g/qCywbSgnYq/wGajvPg23Xd8a rbQTCoCk1BLjbCQfO0arddmmBvrRLYcD5JcTY+5ke0dMMwU0mEKmaifgUpXBVFVGj X-Received: by 2002:a05:6000:26cc:b0:3a4:efbb:6df3 with SMTP id ffacd0b85a97d-3b5f187d0b9mr12000724f8f.10.1752519266653; Mon, 14 Jul 2025 11:54:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaJJiTeODy/grE9uQG0AvoTZwYowHnLLNyNVEuR0M74Pw9NACBs4EqhO55dJs77Vh3QS8gQA== X-Received: by 2002:a05:6000:26cc:b0:3a4:efbb:6df3 with SMTP id ffacd0b85a97d-3b5f187d0b9mr12000706f8f.10.1752519266254; Mon, 14 Jul 2025 11:54:26 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:ca00:ca3a:83da:653e:234? (p200300d82f38ca00ca3a83da653e0234.dip0.t-ipconnect.de. [2003:d8:2f38:ca00:ca3a:83da:653e:234]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454dd466154sm138407125e9.12.2025.07.14.11.54.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 11:54:25 -0700 (PDT) Message-ID: <4e02afc2-3429-412f-9fb0-d15cbb30c6fa@redhat.com> Date: Mon, 14 Jul 2025 20:54:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] mm/huge_memory: move unrelated code out of __split_unmapped_folio() To: Zi Yan , Balbir Singh , linux-mm@kvack.org Cc: Andrew Morton , Hugh Dickins , Kirill Shutemov , Lorenzo Stoakes , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , linux-kernel@vger.kernel.org References: <20250714171823.3626213-1-ziy@nvidia.com> <20250714171823.3626213-2-ziy@nvidia.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20250714171823.3626213-2-ziy@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: e9uAzJE-du2x4cZFUbfBF3CCfGaX-tqKEJd4LFiSOwc_1752519267 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: C5BDC40007 X-Stat-Signature: ezqhymp7qkh95o7p1exiurgbo57gz5aw X-Rspam-User: X-HE-Tag: 1752519269-684861 X-HE-Meta: U2FsdGVkX1/mrEn8g/NG9NicyIIE1ehjT79dGZGkvqfazsTL2HRvDlTX5BaIsdXgo0YOsGX4rzkUzaQ3RFEaa/exxXrcZt3F8+3Nnhpk3d84LOqsrsG5NBxM7CYaCqpZGsp7kWc7JDXAehBT7uy7DZ2ajEkjNhiQxTdrZVQ5Ke9UmvlzCKS9uodBYYkI/n+ANezEQ4GceNslIpOHZyqQIUyQwagOdzU9JlwZahul9wDf1lA8fVRq775mn9b+wgmPlNe87Xp6k7rD5V3ZkoHUy8wBA+Ce0qDStzGdfXZHeYX2rpNGFOOk8v0gsU33tL0JGQlYor6csF0/H1JN9YdK9MmkMa2CHA5R9bysJvWN4cI924ag4O0H2jianRPJDRW8PcfifA5i7akVi4FOdqRXpAAp1km6H/1Xd3V3/et6mzFXWKO1fRTtPpDyWwC2oE4jF+olYkzt8JsUJcLvo7Ys2//NPHmtTOh2+FAGYaoSG03zlNMQb+uc8g55FpWEkPpZSdjgHbsunuSDfH36mB1lw/WK0sB1BBpoQpJrPE+8GwQNXwug1ugPJvVRkPPAOmdFasPDHZSOXeHX19re2VGLiRqb23Oe1lB4fEyAUbeIiu0T6wxdSKLbMSykmBc5vMihaQrz31L+kzEK5AIAx1Oc66lFiOpLqozjJ4930IdXEXGHZ/rj7JZUjo1K5w0cCJsGVqTBsI0GErH16J1w+Stqc0KgNJPOHLARXMf01huJv2wMaP4sQY8T04m9eWdBLfEYCsJqUCMv3FpR180aFrQ5wfDFQNSkfB0xiIUXGMdM+d7vBGrie+R/Rl+6JH2jENZfmYjHP5llvkJcyM7zTsmHOD89nU/wROSsgTZhy+MWjl58KiYHL/TtuIAJI1F+c4EXkqs+EFdVc1Ac6C39kfZsA7s2yWxPni7QX8TPFrAA+IUbGnv2DrJZIwmnaR0nXEAE5i5gmeJxYXppLyR2JpL 7woU/+iN HyJlSBbEv7ApPqN1bjke/ClqlZA/acC/HSNKNnJKSVlYfewx28+Gnp5VUdIAzBt6xLyYuwGj50tH4CUNKCBT27oUXM3yLGC+Oc/h16HLVfcjmx68xz0oWx/ky0pR1/aM5NGEmli6l/ut7WaJyarbA9iNGUl4Mvr3i1xCBUQRaLIQjztkaEyobRNsxcXURhN06vmOLscZho7NJAa2QFYWomZoXeLDXzCbct/8jcoR710EknPesa40FpHGAhTUj6EX0TeT9Q6mQsMTQ+vzYyhDLHeshFFu9TuatjmhCSYHPRT7++BLfqUGIFBf/VWlZlcKsTZ8hXZ9gBCMuOqtaWcRqUQGoEkOA3m+z0+KjKbUp3fqeFtSnAWx6OT5CCTYbYJdHGeOstN08Wp2NCU1HRnO7/evDQNY/uwLd4Nu+yhahKB4lqYcdFZx6aBvstp5ikdod661wuTR2Wo4sbV7wEKCIutS9R6Uw/K/5yP173r9nMvt8NFYWpsP3vO0kgh4n+dSTBwsL9TdRyH7gUU3E0PhuLEra5koQLQHLeg0/Exu7FTD/qsC6DKPmz693CufkUW/0UDQkdotFUvz9wxCV6mdJxiM0TQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.07.25 19:18, Zi Yan wrote: > remap(), folio_ref_unfreeze(), lru_add_split_folio() are not relevant to > splitting unmapped folio operations. Move them out to the caller so that > __split_unmapped_folio() only handles unmapped folio splits. This makes > __split_unmapped_folio() reusable. > > Convert VM_BUG_ON(mapping) to use VM_WARN_ON_ONCE_FOLIO(). > > Signed-off-by: Zi Yan > Acked-by: Balbir Singh > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb