From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22DAC3ABB6 for ; Mon, 5 May 2025 12:11:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7524A6B0088; Mon, 5 May 2025 08:11:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6DABB6B0089; Mon, 5 May 2025 08:11:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52DF46B008A; Mon, 5 May 2025 08:11:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 35EEA6B0088 for ; Mon, 5 May 2025 08:11:02 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4CD471A0298 for ; Mon, 5 May 2025 12:11:02 +0000 (UTC) X-FDA: 83408738364.14.DB77AC0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf24.hostedemail.com (Postfix) with ESMTP id DDA8E18000F for ; Mon, 5 May 2025 12:10:59 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JXtw1lMM; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746447060; a=rsa-sha256; cv=none; b=rXAO8LN3U5aeO6eupoZqE9wGcl2Pn1WvHab5/uScaCvqBaGVhEiWg6iNEqv0dKJZd2HhUY 1NPqLQr6vJIYW8av7GapuJ0yIP1q75SOHpUmAPwc863eD991kHYGDoqyEWpujC2MEpenJg EHxiqJhmmt72icKuVyNadF1I7BsMgIg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JXtw1lMM; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf24.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746447060; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AtQm0nKCXqWUQctCIsxIFw0cZn36nlmWf/6lJLm+ytU=; b=Sbnbunqb02kHhTBmhH20iB7ql3TV9uEj95iAfJhzqF8zNgZWVKMLyWvRqJNFUhKTGsB3cb J6R7Q4f8RmIGwt06p9ForhsdCv0Sgm19mX6Lc61sDQQ6ZL0tRP2h+gFC/3x9d5QLgbas+x pRIAyp05NXrugMnw25DmhCPhG3oCnYc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746447059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=AtQm0nKCXqWUQctCIsxIFw0cZn36nlmWf/6lJLm+ytU=; b=JXtw1lMMETtn5MlNDacKfLHuA4OPxz9HNuYhzlZzbYt7X7c2X3d1CmW0epzGVOcD7RA67R NcMeuuyRBen87s+MmiNRUZ5I2MjWfkq0jXMyOxXiTWAm/AB/r/iRNJH6qW8pPKiCod6iAU I37pgGO81fpGM13ZATI60//SZOka7h0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-396-xcRegaTzMJ-RE1mXSHHe4A-1; Mon, 05 May 2025 08:10:57 -0400 X-MC-Unique: xcRegaTzMJ-RE1mXSHHe4A-1 X-Mimecast-MFC-AGG-ID: xcRegaTzMJ-RE1mXSHHe4A_1746447056 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43ceeaf1524so17843635e9.1 for ; Mon, 05 May 2025 05:10:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746447056; x=1747051856; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=AtQm0nKCXqWUQctCIsxIFw0cZn36nlmWf/6lJLm+ytU=; b=nQFm3VJrH337VjCrtILqIwc8YtbGjQqP3n0ZGZarrzKKIEXr/+1oiU4F1SOUZB6+S0 Ux9O5bKowSkGBouxLlckuLjCHXQrPHPcaChmYEceof1/lkIeQeGQwDI9xyoGV1HWyUhb 2rRqBZgszkFgHRswiwoT4K8agonqF9eKNGNmc0gV/3B+uXlH4GlbOQKiTZuJyXTdwttV 7Ogz6sAkM8Ow4YR57Kw+5ZzbwmBYoi32AFgujpyGePxUV/fv6hDaWG0aOdeEW9cWEgdC RgcBEgkAA28vbLL3Zy+rZa+VRIBll8TDfOej4TCN+38D4JDrHbwTW0k5cM+Ww83DWQSR IBuw== X-Forwarded-Encrypted: i=1; AJvYcCWILa+zjpSj6oKAqg6StJkAgmIIWIQGEtl5MYnu13MTI7CY9C4EWAXywQ3GUZNfwyNihm1enN7b6w==@kvack.org X-Gm-Message-State: AOJu0Yw4++0+Il0hyKeo3ab2bG6W9sQnqfLtZHZZBfGIR4dQ0QfaCP/N qYRcM/N0i+QCgElIpAYvLcWIpvdXEnrEsq/7EBXPadxF0dlgYfuuuThV2WvNTNKXXHancUWPrhf FusNvQclaDST5g7mR9jR12y+g8B0NKDYVbP5hcq1TLuHazD23 X-Gm-Gg: ASbGnct63VMYR1FKpQvDUWz61XU22dUapqc90RMl7PhGt0cqdX8rPhDPDWoutbGoE7E ceNVxkHs6bUXQK4ZGs293YyscSoA2/vS5OoVL4ragelvH9bfSX/CJ/5Ra0Id8Ag2l8zjkGFiJNT yZIBDdFOcjw8d56EOmMhljaoClfk+KH7kMg36ANkHLK19CWVYdNM6hGcvGRtc8WGYDe5GaWXO1w b62YZBUAp7WxA1B/p8DCZEqEwJha+Pb2XsZ5LFPvIiZHCMeT8K1ZyqT7xJuoQllr+0qw7ZdWufq J76haKd+bl6G90R9Q5WV8I0Cvea2Xy171paUfWzP7arDUGkAosvg5EPE0qDkCRr6TSUNsOJBIYl HRKIC7AidSUUXV3JejN4Pc4RWXAeOD2gFl0733+k= X-Received: by 2002:a05:600c:1987:b0:43b:ca8c:fca3 with SMTP id 5b1f17b1804b1-441bb88d49fmr106652385e9.11.1746447056168; Mon, 05 May 2025 05:10:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGwOVCj9ArZhf/ZRWlo2Ca5VMFb8MLtytsIIBztQOJ8g1W3ZlOSIFXQi8rsgDe+/5Pluuj8pw== X-Received: by 2002:a05:600c:1987:b0:43b:ca8c:fca3 with SMTP id 5b1f17b1804b1-441bb88d49fmr106651995e9.11.1746447055805; Mon, 05 May 2025 05:10:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c73d:2400:3be1:a856:724c:fd29? (p200300cbc73d24003be1a856724cfd29.dip0.t-ipconnect.de. [2003:cb:c73d:2400:3be1:a856:724c:fd29]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-441b89cc387sm134622585e9.4.2025.05.05.05.10.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 May 2025 05:10:55 -0700 (PDT) Message-ID: <4dfabfce-8fe4-4b54-860c-e873fac12b8d@redhat.com> Date: Mon, 5 May 2025 14:10:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 09/11] x86/mm/pat: remove MEMTYPE_*_MATCH To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-trace-kernel@vger.kernel.org, Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , "Liam R. Howlett" , Vlastimil Babka , Jann Horn , Pedro Falcato , Peter Xu References: <20250425081715.1341199-1-david@redhat.com> <20250425081715.1341199-10-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -izVEQ4at-tvLsJOcpacYjxuVz0NoWhRknpu4QhzRII_1746447056 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DDA8E18000F X-Stat-Signature: 8omtibouo9ej13t9ts93yo7dpyp1eeoy X-Rspam-User: X-HE-Tag: 1746447059-942884 X-HE-Meta: U2FsdGVkX1+U3BRbNLHf5bbZNsY/C6zWY7jDDarpDdXSA5btM3w/cx76WLlyLY4LUa4lKWOpf6WK+UNgel4xnebEsKUP6a83bkwYg9eP1m15k6yus2KD5Qv5nLXmCNeMOevVbhrA1F7eKac6B4SvI2BB7bzE2H/uDl++tontlh6pSZRXk/H4wdjbtCK/0/c/Nuvn4OT4HQKZS6Jl3YazOdBW3vW0tnSBnBf6t5M7Zg8AVXjX2BgQ1gM7m1I6oqVKcprSmwrdCvsDRoiiH+1V2tUjMYDeFAU0kiIzmEo8bnXjujbgPjyTiVnGDVk1cN8yIa+/fooo9z1Eo65aaXFZTiSbFLnoI2qN1JcodX1iz49oqkQMe8FdKJlEGzbCPnOLBA3zYzmLL74U0bnGj9kn2ojnJTPpdkjyLjArX7w9RkgJSfpQy9FmFXaLAejDG3W5BDAEmw549gGrSQoVUEpQm/lKOr4u9/Ruglmy70AqvLVoIDaQXjSjYd6uvslg/Q9rfJtYrbQtAINNj0pYzlr1OMZnx/05KGt75Y7FRDXJgyFXk1cLiH8Mx8i1DfXyZVEh6RN5MJegGyvmpOoyNUa4OkxavLZSXhs6zD0/22gyj7Ueg4yHTcVhzSgTlm4NsyG/uzw1To7AOJwyasa0euiSPgvvjVe4UxYc7JUaHl6qWU7j0EOMfEjI8ZIq/TTez0T1eM9oKhcQSroRhJ7MMfdNkGIn4I9Pr2E3CROETyjFijeYPkQSNA3Pt0vJWsAaZJ8ACzACKvLk0q+Zz86T9xVuD6vt4lejsss5XSYDrPGZAF/MvUXDglb0uS/yM2s6y+Mv5CSawFfE7Z3lUVHC24FkrPohXbmDlj+nPVD65r/ODFoKaMjawyDSxOAEWW9knEU4CtuWSi8weGByPb2z3/mA9GscyR6BJn9fThbD6roEoY8rkd1gppDpNxMOTD87Us8rmKpP+rfn8pWwnCWGWwx ND3YFOe8 lhPlkEVNccOk2Ci+bmo2AvB6GLVecMg4/05OCkBgEgOLqEjDN0hXR8qUB/1SlvWHsfTIxuHp15kk5KCLKVAW0t0qLPr/h90vdTuV8s8FJ/XYpIixYmcEnuO4coc97HrehbsV5J8UCbz2Xl6VihIlRpE5l43G5pyht+2pnJ3xrNDjnIGsZlbgNV3jVlq7kObbqmTI8JSI38ffPtZLUnHly+FJHRvPNAv50wEctMg1RTJMJ1/abXR7NatGXYUf2lYlJ3jlyxSff5Y4xqoslgwJnyWq1Cpd+BQM0rQb5C+Dy7sON9N839YMw0P66ZRI5qUGoSYgC7iwHP7is7bC9af0JN+51tMupCz5zaUCEj7gjTgDDPqPh305YKso/0A7uNoXVyvb6Ij/uBWCgW405HfaE2xjYSoNINSoCN5yizNSOKTywezgRf0daf2M2cfbOet/ojOqAPKD7twe7+Fo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.04.25 22:23, Lorenzo Stoakes wrote: > On Fri, Apr 25, 2025 at 10:17:13AM +0200, David Hildenbrand wrote: >> The "memramp() shrinking" scenario no longer applies, so let's remove >> that now-unnecessary handling. > > I wonder if we could remove even more of the code here given the > simplifications here? But not a big deal. It might make sense to inline memtype_match(). diff --git a/arch/x86/mm/pat/memtype_interval.c b/arch/x86/mm/pat/memtype_interval.c index 9d03f0dbc4715..e5844ed1311ed 100644 --- a/arch/x86/mm/pat/memtype_interval.c +++ b/arch/x86/mm/pat/memtype_interval.c @@ -49,21 +49,6 @@ INTERVAL_TREE_DEFINE(struct memtype, rb, u64, subtree_max_end, static struct rb_root_cached memtype_rbroot = RB_ROOT_CACHED; -static struct memtype *memtype_match(u64 start, u64 end) -{ - struct memtype *entry_match; - - entry_match = interval_iter_first(&memtype_rbroot, start, end-1); - - while (entry_match != NULL && entry_match->start < end) { - if (entry_match->start == start && entry_match->end == end) - return entry_match; - entry_match = interval_iter_next(entry_match, start, end-1); - } - - return NULL; /* Returns NULL if there is no match */ -} - static int memtype_check_conflict(u64 start, u64 end, enum page_cache_mode reqtype, enum page_cache_mode *newtype) @@ -119,14 +104,16 @@ int memtype_check_insert(struct memtype *entry_new, enum page_cache_mode *ret_ty struct memtype *memtype_erase(u64 start, u64 end) { - struct memtype *entry_old; - - entry_old = memtype_match(start, end); - if (!entry_old) - return ERR_PTR(-EINVAL); - - interval_remove(entry_old, &memtype_rbroot); - return entry_old; + struct memtype *entry = interval_iter_first(&memtype_rbroot, start, end - 1); + + while (entry && entry->start < end) { + if (entry->start == start && entry->end == end) { + interval_remove(entry, &memtype_rbroot); + return entry; + } + entry = interval_iter_next(entry, start, end - 1); + } + return ERR_PTR(-EINVAL); } struct memtype *memtype_lookup(u64 addr) Thanks for all the review! -- Cheers, David / dhildenb