From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 408A7C3DA4A for ; Thu, 22 Aug 2024 09:43:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C631F80023; Thu, 22 Aug 2024 05:43:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C133E8001E; Thu, 22 Aug 2024 05:43:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3F3A80023; Thu, 22 Aug 2024 05:43:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 8502E8001E for ; Thu, 22 Aug 2024 05:43:49 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 09B331A148A for ; Thu, 22 Aug 2024 09:43:49 +0000 (UTC) X-FDA: 82479394578.25.5C64C15 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id CA21E1C002C for ; Thu, 22 Aug 2024 09:43:46 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BInzf9xJ; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724319786; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8qIeUkM1CiKs3TMZL6yOmsW5pxWTgVW610+XGajzQpM=; b=OXZt9tYgl41WytCkHImyjosfmOCXtNCfhA+XGoWBZEN7liDCgnUyO1cZHQaOfGMmCqdzW4 3Zbj56zdYNrzZxz4pGmTjmlGtREhFKhHOXoo6PpT2a/slMs9007x9pDdv3m3g8Pp+2WY5X ARCK+94FWt/ZuNf+n5mJV1EHAcbfXAI= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=BInzf9xJ; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724319786; a=rsa-sha256; cv=none; b=FnV451Cb+Yl17DYucITLHXXIOf3HtzCrDF/RF9bp3t1pJROm20zCjZN0j5PVjbGKjCtloO 51XeFWUA6eaVo+mNdtId28FxebmRd9CaXDp1DHZhL8mvAjG6KOph/XpqN1geiGEyLMZBiF 3k6p9NbL/6ibU7ZcndhVEsvZPnt1YtQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1724319826; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8qIeUkM1CiKs3TMZL6yOmsW5pxWTgVW610+XGajzQpM=; b=BInzf9xJxVVPWP7ArtgP3M7Vike97Z1K/+hbFLSH1gqYh5Lbu5ZxHpZqIfaEkKbYp36e3u fiouDpQheKvfrdEKpAGu+LIWqJeQhlNbYNiXJAfdA3Vin1cxz5imwAD6NB77cb3ssXD53v uhg+KWvnuvhdLnI9gpW7nNXVIAEx808= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-448-T7sviYXGMbOGAlKq3FJemA-1; Thu, 22 Aug 2024 05:43:44 -0400 X-MC-Unique: T7sviYXGMbOGAlKq3FJemA-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4280b119a74so4056175e9.3 for ; Thu, 22 Aug 2024 02:43:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724319823; x=1724924623; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8qIeUkM1CiKs3TMZL6yOmsW5pxWTgVW610+XGajzQpM=; b=VkkgpqNoUBanv9IBP3pTUZp+fSiHL1oc4/cddJ/0ZRhrjbPPkv0FBXvgc1FDWtpRU9 mTmfhwEG5nZenw4wTq48qOIOtOf3o4GT2yt6R5g6RPuiurBVvxzS+8QEgbliBLRz6suC wJyg4OM6NLeNgvUuZc3icSWI94KBVfXPRHm3Gg0BsUmCjTgEU2OL5VLlni/DjwJSnP4T aCnWiY3glmcKEvltuGVg6tJvrNfP5vq6WIpj6Fsw6FUxp8x0cyMJNeFSJQ16nE0GTtAE JKvHLoS8QiRpEkqG8FQb/imIPQgIoVtNubMmbj3puztppGBnDVKNgNUQbKL2h5qJ+liG KjaA== X-Forwarded-Encrypted: i=1; AJvYcCUTk7pGzB5gLdtxWs0q4OqRN8HR2D4vJEwJHQXUmZiS07iYmAdQeq00pLspGMBmXNmfcgqPasQZSg==@kvack.org X-Gm-Message-State: AOJu0Yywjp6evGcVmkO88YYQ3WoL9cvXHprPtYP9AE64eaLs1rcJc8i7 8I1Ad5QfO+pzxq8Ss4WK0EkHmcaTYgNHNkFqxiPAJ6Q0FmwLq4hMCBN3P6hAOWrHPRLz/0dtZeG idLpBfcejs7rpU/SDrFdcsw3GMWCBrvNK/Cuv9cbEFK3fNbLX X-Received: by 2002:a05:600c:8516:b0:426:5e91:3ff1 with SMTP id 5b1f17b1804b1-42ac59ae975mr9083095e9.24.1724319823615; Thu, 22 Aug 2024 02:43:43 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGIEKSkfI7/NFqkljdf+QGKhzB85okjPLFADalUmPJd274xThySPNye+UOIXTwfR4XGddqCtw== X-Received: by 2002:a05:600c:8516:b0:426:5e91:3ff1 with SMTP id 5b1f17b1804b1-42ac59ae975mr9082785e9.24.1724319822766; Thu, 22 Aug 2024 02:43:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c70f:2b00:f928:47d8:c9be:9d87? (p200300cbc70f2b00f92847d8c9be9d87.dip0.t-ipconnect.de. [2003:cb:c70f:2b00:f928:47d8:c9be:9d87]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3730813c1e3sm1226991f8f.35.2024.08.22.02.43.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Aug 2024 02:43:42 -0700 (PDT) Message-ID: <4df58ef1-b379-484a-aa5d-ef77a1200c63@redhat.com> Date: Thu, 22 Aug 2024 11:43:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] mm: clarify nofail memory allocation To: Linus Torvalds Cc: Michal Hocko , Barry Song <21cnbao@gmail.com>, Yafang Shao , akpm@linux-foundation.org, linux-mm@kvack.org, 42.hyeyoo@gmail.com, cl@linux.com, hailong.liu@oppo.com, hch@infradead.org, iamjoonsoo.kim@lge.com, penberg@kernel.org, rientjes@google.com, roman.gushchin@linux.dev, urezki@gmail.com, v-songbaohua@oppo.com, vbabka@suse.cz, virtualization@lists.linux.dev References: <59e90825-4efa-4384-8286-06c0235304dc@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CA21E1C002C X-Stat-Signature: cu3msu3d9fuh3gre88eo7pk8sxuse3ma X-HE-Tag: 1724319826-25644 X-HE-Meta: U2FsdGVkX1+XC2Nc5b0dQBq8xuIrU4j48K+xaaMT0ASXjqcbYA/8HUsyhzto6nveoAooy1MmprS5+Ik/smB+k+PeuHmb61LolyRoNUj9VwNaqKJOk5OeeKFcPBT6P4fZOA2jVnWbuneu4GlRKiqQ33vTVcsUg3tp/PN4YI1KBkzTEO9YsmKXVgoYatNn9MrF0zw+dxsJi7PjtIVPolQDanyACHyq5FVMNMs9K6Y4NBDM8s9cKfJNLr2ekbnDhCK7HyGuJZsinZBbiOFi9l7GXbgCLWfqf/aiNX/e+NWVn4sNqzxWjVQ642m/uxxaWn7u+1ZQZN06A9X+qc7Zd+FS/3Jk26L3/NBWb2/HPqA3iYkMFN8lqsZ12v5Z6sJCP0w38ZRTlONx1XtS+w4PkDI4TyH/7nWMxi/yBefwZ/26Lf+biFZCFWMt2W3jcAsDykOObrDEn+9oPyw4KJ3+X+D+8cUCCSappLklkviZse9BmjW2Pd94aM0ccNoRgy329h9RQGm7uKA0APoNCr7qNxzPCXtywe4Q6GkW4dv8KRrHnHk/GWhRYUK2BX0qSkQqy8Jqxnay5KeCtHbQ8gsnGFm3njWOh1SbGEdWV4j9v5POwOBAebmjBssYuDO44Nk7lvL4Bz7RK6I4OTlok655gEwSHYX5FOlqw1Lnyg0NZoQQrLWokhzDgEadntMW0tP9KlSgZeX5cwGIbJYoBjAxLaEPGwp6UuY0dj+yo2CVDHrdYP8Mt+UEST8P4FX/RIUkIdSikO0apNi7/uYxHZ0trkI/gkEAxNOXsJcqxYmJqtGms8EzG4km1C53/NUAz/4EkAHkR0VlgTuV2jXy3hQyyzbWAKQ/YcY3ln8oBP8TTpWgvgpkgHklbEsmGF2J2tLOJI1L223v0uYBREcD5G9qWi3ss/R5ytrKTWAi/KJ5L3IeZI3F5CPQXtJaolxWj9ZDh2xZT3xis4fkEpfaQJCIQPp tYExNqdp CPDvRlzNSyruILMusc9C64pgs8mWKpe374E/AXCp5P7hF+eAKmKS4h2E6IXaa4nOg+ATT4P0T1ORJ1af3gVow7ZPgKavEjfnPZ12me7hsKvd0kU4tA9MhAzhYp/JkRrE4lL52lvUOGxHaUw6TFTTe4Ez85BenLYbXVHzML/o3y2zT10NpUwWzDYslHjbmb3y4O171ti44Z2ovAJ+IDA8SdCgaRLlxqi22Bo45e4fZWLbLaJaKlUkXYQQRYODUlg88n///RX9tPRvASbrh8kX3UWbPhVhPPn8dLyRHWfCMmiRq8n+NAzR75FUn2BMS+ZuM6OhPaE+V5P3PJZL3I7cUhqJcM79t/HYHsWkwAzmu9zGprI1oHJJ8SMa6sYWl35B3E8m8ByBSKLj0A+NKPjxLhp0IW+g2ylC9gw5p458AeOKHwEUlRyE7OIEKfosuhVRtYcaBm9boqcAAPYoIAE7bk7N68A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 22.08.24 11:34, Linus Torvalds wrote: > On Thu, 22 Aug 2024 at 17:27, David Hildenbrand wrote: >> >> To me, that implies that if you pass in MAX_ORDER+1 the VM will "retry >> infinitely". if that implies just OOPSing or actually be in a busy loop, >> I don't care. It could effectively happen with MAX_ORDER as well, as >> stated. But certainly not BUG_ON. > > No BUG_ON(), but also no endless loop. > > Just return NULL for bogus users. Really. Give a WARN_ON_ONCE() to > make it easy to find offenders, and then let them deal with it. > > Don't take it upon yourself to say "we have to deal with any amount of > stupidity". > > The MM layer is not some slave to users. The MM layer is one of the > most core pieces of code in the kernel, and as such the MM layer is > damn well in charge. > > Nobody has the right to say "I will not deal with allocation > failures". The MM should not bend over backwards over something like > that. > > Seriously. Get a spine already, people. Tell random drivers that claim > that they cannot deal with errors to just f-ck off. > > And you don't do it by looping forever, and you don't do it by killing > the kernel. You do it by ignoring their bullying tactics. > > Then you document the *LIMITED* cases where you actually will try forever. So on the buddy level, that might mean that we limit it to a single page, and document "NOFAIL is ineffective and ignored when allcoating pages of order > 0. Any attempt will result in a WARN_ON_ONCE()". (assuming we can find and eliminate users that allocate order > 0 fairly easily) {kv}malloc allocators would be different, as Michal said. No idea if that is feasible, but it sounds like something you have in mind. -- Cheers, David / dhildenb