From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B3B1C43334 for ; Tue, 14 Jun 2022 13:16:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 150BB6B0081; Tue, 14 Jun 2022 09:16:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1007D6B0082; Tue, 14 Jun 2022 09:16:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EBD4A6B0083; Tue, 14 Jun 2022 09:16:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D8CC86B0081 for ; Tue, 14 Jun 2022 09:16:00 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A7D3F34ED6 for ; Tue, 14 Jun 2022 13:16:00 +0000 (UTC) X-FDA: 79576889280.17.D5203EF Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf20.hostedemail.com (Postfix) with ESMTP id CF47F1C0080 for ; Tue, 14 Jun 2022 13:15:59 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9988621B3F; Tue, 14 Jun 2022 13:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1655212558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=unBJziFr/l1u7Dc63FxxSI68un+DPyciUX2nsqLKcvI=; b=xiMYiLSKDPKrXKkLsQRw5h5hZd8eUxotBwUhO7FxWlUlFpYYSlwp4eiXYg1JlL1m8HdUn8 E0QxS33JxpYuAFpWNhOgBTt+GKYtfX8u2sPUUymBX/yuuAZqt4+2drJvSicJzyilf6LOwS zhp7G/1LDjiirekyXhg+dCFq0vcAYPc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1655212558; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=unBJziFr/l1u7Dc63FxxSI68un+DPyciUX2nsqLKcvI=; b=yaIwPI80V/kxo7ivvJUeBLns588XBNOAwy1F6qgcEP/ydxKPSfj+JkyEhYRzlIPZUrAORz aIyF2avHgiO+X5Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6BBAE1361C; Tue, 14 Jun 2022 13:15:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DGwDGQ6KqGKSIwAAMHmgww (envelope-from ); Tue, 14 Jun 2022 13:15:58 +0000 Message-ID: <4df0e708-166a-53dc-12c0-a1281d988d61@suse.cz> Date: Tue, 14 Jun 2022 15:15:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] mm, slab: fix bad alignments Content-Language: en-US To: Jiapeng Chong , cl@linux.com Cc: penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Abaci Robot References: <20220609040132.89192-1-jiapeng.chong@linux.alibaba.com> From: Vlastimil Babka In-Reply-To: <20220609040132.89192-1-jiapeng.chong@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xiMYiLSK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=yaIwPI80; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655212560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=unBJziFr/l1u7Dc63FxxSI68un+DPyciUX2nsqLKcvI=; b=8cCsl8yBfJ/J1+ufKNFkWHBh2thOObSSDHpI2jKnkdK+NNzLH63sSsCkxkgQZ3sQ0j41My A4Ftd+5aFUSZ8pjTfADK6GRlb2GckwOKsCvkR3DDozRbB+yRFmWydjQbXpFuLqCwurvCa3 TKKixrkRZTQhuNRzpL4kpwxY8y72q/Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655212560; a=rsa-sha256; cv=none; b=najoTu0AmdCIbYkHeatGiLGtzo33qYN0h9PEUXIfTfyQTxshF6TXTVKn9fgW4Iyg2xTkiX fAy3kxbRzaK2yXo8FJAp1t4tsP/ThXQ5ph64Ivl2pRvzbbe+FbPqY1H9k7YVuv0Xluz7gk 5B0mdHZR+ObdzyE0wt79lVZ3NaySH0U= X-Stat-Signature: don6ngmpqwu7mxpboeaww6jknj3qffp3 X-Rspamd-Queue-Id: CF47F1C0080 X-Rspam-User: Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=xiMYiLSK; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=yaIwPI80; dmarc=none; spf=pass (imf20.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspamd-Server: rspam10 X-HE-Tag: 1655212559-352493 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/9/22 06:01, Jiapeng Chong wrote: > As reported by coccicheck: > > ./mm/slab.c:3253:2-59: code aligned with following code on line 3255. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Thanks, added to slab/for-5.20/trivial > --- > mm/slab.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slab.c b/mm/slab.c > index 47151fb2b2d2..c359c0f2c897 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3223,7 +3223,7 @@ slab_alloc_node(struct kmem_cache *cachep, gfp_t flags, int nodeid, size_t orig_ > } > /* ___cache_alloc_node can fall back to other nodes */ > ptr = ____cache_alloc_node(cachep, flags, nodeid); > - out: > +out: > local_irq_restore(save_flags); > ptr = cache_alloc_debugcheck_after(cachep, flags, ptr, caller); > init = slab_want_init_on_alloc(flags, cachep); > @@ -3252,7 +3252,7 @@ __do_cache_alloc(struct kmem_cache *cache, gfp_t flags) > if (!objp) > objp = ____cache_alloc_node(cache, flags, numa_mem_id()); > > - out: > +out: > return objp; > } > #else