From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1624FD3E78D for ; Wed, 6 Nov 2024 06:12:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D5266B0083; Wed, 6 Nov 2024 01:12:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6849E6B008A; Wed, 6 Nov 2024 01:12:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54D146B008C; Wed, 6 Nov 2024 01:12:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 37E8A6B0083 for ; Wed, 6 Nov 2024 01:12:27 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id AE85CC0642 for ; Wed, 6 Nov 2024 06:12:26 +0000 (UTC) X-FDA: 82754649180.08.453D19D Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by imf17.hostedemail.com (Postfix) with ESMTP id 40C6540012 for ; Wed, 6 Nov 2024 06:11:57 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=LUASkhXs; spf=pass (imf17.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730873460; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=F1x8diBjxJZ/wui4j6BD6zQoh/rM6nkCqZnmZjoErlo=; b=c5z0wxM8bKATDlFCIR8aWyejnhl1f0H1xitQixzkMN8mNCe54A8Y/Jb14Es79TZ6T1ngjD rFjgg+bQN13qiJVh2EeI4FJj2u0D8YsUEQLhfa3Ky/weGp6s24gTGDUgaI3vFkiH4yBylP ProVs8p31odHyW1GrO6Lq5oEWlHXZa0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730873460; a=rsa-sha256; cv=none; b=2ikHfWYMNFdaspuLMsL1z7SsTI/b6M4HkZX6lmjZplGOff9KCpgYa16Uy8MFqPfMsF0tKC wkYZW5NlUuNvlKmYOVugzAVflmBP9y9gNQAiwh3KoVNvqXw77nu8y3Sf/WJS3E60hKVI1c FEUZSCFC9e0czwbqk1OsBmGcr0dMBnk= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=LUASkhXs; spf=pass (imf17.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.130 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1730873541; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=F1x8diBjxJZ/wui4j6BD6zQoh/rM6nkCqZnmZjoErlo=; b=LUASkhXsjAKAVAuyYFqGlbaD5LUB4L9VhKHEl641BAPLzOmOFqw9aCVwcpxtoVrbKEzOz7kE9VBWq9J/u7aixjTwbpXBM3nhGIeHMAnEUsgLzA5ZypjPejej+H0JcXMF6nC/86eqANBKKWIFN5SsBS9HPua3SoPOb7Jqpuu22Kk= Received: from 30.246.162.170(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0WIqAQVZ_1730873538 cluster:ay36) by smtp.aliyun-inc.com; Wed, 06 Nov 2024 14:12:19 +0800 Message-ID: <4decd52b-a2c9-4e04-9793-4d1553689b92@linux.alibaba.com> Date: Wed, 6 Nov 2024 14:12:17 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v16 2/3] mm: memory-failure: move return value documentation to function declaration To: Yazen Ghannam Cc: mark.rutland@arm.com, catalin.marinas@arm.com, mingo@redhat.com, robin.murphy@arm.com, Jonathan.Cameron@huawei.com, bp@alien8.de, rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, linmiaohe@huawei.com, naoya.horiguchi@nec.com, james.morse@arm.com, tongtiangen@huawei.com, gregkh@linuxfoundation.org, will@kernel.org, jarkko@kernel.org, linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-edac@vger.kernel.org, x86@kernel.org, justin.he@arm.com, ardb@kernel.org, ying.huang@intel.com, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, tglx@linutronix.de, dave.hansen@linux.intel.com, lenb@kernel.org, hpa@zytor.com, robert.moore@intel.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20221027042445.60108-1-xueshuai@linux.alibaba.com> <20241104015430.98599-3-xueshuai@linux.alibaba.com> <20241105151847.GF916505@yaz-khff2.amd.com> From: Shuai Xue In-Reply-To: <20241105151847.GF916505@yaz-khff2.amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Stat-Signature: fwp1w3ouygpms3esu5jnp5rwu99s84xp X-Rspamd-Queue-Id: 40C6540012 X-Rspam-User: X-HE-Tag: 1730873517-555747 X-HE-Meta: U2FsdGVkX197SGwdojz8J1fe5B7lq6iQylkZtgf8FlliMLtjG5sx8vY6i6vl4mSpIQwRRx3opvPJuaMzPPb1+DjAZqx7ZujZRiZzNNi9HDausDZPfNjz8+StIm5Dc4/NCVPro+s0AK0qWn/6JO5Spb5HxmX0yEajGq4lUGJ/B9a1Xq/Xwch6s9rqJntcbpoXxzUadBDyxl+XdgzDctD7hYaFGOt7AxMxok9a5dkse0yRNeSBnTHywKcBYI4I3yKtEREtQL1EqvHn3YhXMBuQBS6xnGekMB+ZaXeL2H60PHarm1OuQJ3iEIrdz1iRYLiGoefTWlmyl2ODjEItBFVWE6TO/bHd3oc1KuqPuQsI7tSJRlzNvlA3T8PjuBPs88pXuvBaZJ1mZG4mbOGCmqdjieYxu0w3SrU1joaNjbsqPlFFKHBJ/jy+ul10naLs52t+htYbi2IV7SDySGXNl54OxmvGRpqgrKzsujJFH8JXzx5P6/zo7OaEQuLbrFsw0uooBA1+1ORPnb1GOFwKJ4xTQtTrH4l7UKPWvGK8w6Ex87Pms9XK3tpjgCjNFCdc59++wo2ZuwbObok4sCXQ8B4UO5+SEMyyuFv8qAvVrobAaxIKgwx/UUpMw0vEfGhGQkX9XHq0+8qeSzXGxUoJ72qlyCtNhiRXKRlj0YLIMWwEwE31JfYcgxLmoHGTOlYui5Ep4FdZEdbIF2/oaIv0RXzFYAa7MT8tIDlunoCed+dbsmXnf6SJBop8ngy+C9Ug63jpzQwVDMat1vM7ZplNurXpdoj/2j7LA63TT1Lt12dy01tNGKcWly1Xt8vBtiekT3qH5j/r7jBl9bIdkC9z0xx+OOvDCwDb+AjnkkdiFEQMu6ulIwlP0FvjHBSvy0TKTvWK6ZT2NxTZCpbt8x/thxAmWulL66+d56BghH5vLsV6y72HmxaUEwZbB3LV/e0vqVPpqPGQ+VI1DDvniZ7CA7/ 0WkOlyFA GiTUhFAjjtERZ5d72H6sPHH9u/XBt0TAj1omFPdHqn1mWu4LP7l+nV1cM+8GOKQrqoZbHZfHYDe2z3Pqx8sjMZo6Cng7sR8NMa+WLQWPsOFnjDsVVixdDyiHvdfRDJvRcfs+eAGupEQaGl7V8WW3SDPo+3V0aUXivb+BJQyoJsjIF0ITobEetiNiiQHKR7uBq4zkq8ZXAhSHaJ56vQW0Eb2GNH231U4oOnkZR+MovxpEZd7WiqmEB7oww/LLrMMFroOb5hAqjy2TMf1pi9f+FcFZBeGlXpAxGoUahOnmerxMlf5ipKLu9qD9vwQqB8Z1c7EZxDLq9Qmo5n6KG5g75lar1I38oNFRYfpNdWCFa0k48u60nNFMDWpVoGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/11/5 23:18, Yazen Ghannam 写道: > On Mon, Nov 04, 2024 at 09:54:29AM +0800, Shuai Xue wrote: >> Part of return value comments for memory_failure() were originally >> documented at the call site. Move those comments to the function >> declaration to improve code readability and to provide developers with >> immediate access to function usage and return information. >> >> Signed-off-by: Shuai Xue >> Reviewed-by: Jarkko Sakkinen >> Reviewed-by: Jonathan Cameron >> --- >> arch/x86/kernel/cpu/mce/core.c | 7 ------- >> mm/memory-failure.c | 9 ++++++--- >> 2 files changed, 6 insertions(+), 10 deletions(-) >> >> diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c >> index 2a938f429c4d..c90d8fcd246a 100644 >> --- a/arch/x86/kernel/cpu/mce/core.c >> +++ b/arch/x86/kernel/cpu/mce/core.c >> @@ -1373,13 +1373,6 @@ static void kill_me_maybe(struct callback_head *cb) >> return; >> } >> >> - /* >> - * -EHWPOISON from memory_failure() means that it already sent SIGBUS >> - * to the current process with the proper error info, >> - * -EOPNOTSUPP means hwpoison_filter() filtered the error event, >> - * >> - * In both cases, no further processing is required. >> - */ >> if (ret == -EHWPOISON || ret == -EOPNOTSUPP) >> return; >> >> diff --git a/mm/memory-failure.c b/mm/memory-failure.c >> index 96ce31e5a203..1c5098f32d48 100644 >> --- a/mm/memory-failure.c >> +++ b/mm/memory-failure.c >> @@ -2209,9 +2209,12 @@ static void kill_procs_now(struct page *p, unsigned long pfn, int flags, >> * Must run in process context (e.g. a work queue) with interrupts >> * enabled and no spinlocks held. >> * >> - * Return: 0 for successfully handled the memory error, >> - * -EOPNOTSUPP for hwpoison_filter() filtered the error event, >> - * < 0(except -EOPNOTSUPP) on failure. >> + * Return: >> + * 0 - success, > > One more obvious one from this function: > > -ENXIO - memory not managed by the kernel Yes, will fix it. > >> + * -EOPNOTSUPP - hwpoison_filter() filtered the error event, >> + * -EHWPOISON - the page was already poisoned, potentially >> + * kill process, >> + * other negative values - failure. >> */ >> int memory_failure(unsigned long pfn, int flags) >> { >> -- > > Reviewed-by: Yazen Ghannam > > Thanks, > Yazen Thank you for valuable comments. Shuai