From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 643CFC3ABCB for ; Mon, 12 May 2025 02:17:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 054716B009D; Sun, 11 May 2025 22:17:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 004A96B009E; Sun, 11 May 2025 22:17:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E5BFC6B009F; Sun, 11 May 2025 22:17:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C89126B009D for ; Sun, 11 May 2025 22:17:34 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 104DBBFF46 for ; Mon, 12 May 2025 02:17:35 +0000 (UTC) X-FDA: 83432644470.28.96E0233 Received: from out30-124.freemail.mail.aliyun.com (out30-124.freemail.mail.aliyun.com [115.124.30.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 5461340009 for ; Mon, 12 May 2025 02:17:31 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=wLHkxy8r; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1747016253; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Q3V6PINikXfSMOOKNu6WoMw90+2FG7fdPuCXdZsG9iA=; b=cEpzG44Hrxh+Jcu3CsoRAdWa1TxdDzIbwOesZzfu2IA9aTtO1RFnMWfXjzrlT0wTQD85xn pT4ZDeZXTDhI3yulvOqka3L2915KSuJBqjdnlsaICWV+lgR3tyUMZEVGTDnJXkvWOEmdsT ADrSHjTPVJazN3mk+w2Ftuco2Nfkk0g= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux.alibaba.com header.s=default header.b=wLHkxy8r; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.124 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=linux.alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1747016253; a=rsa-sha256; cv=none; b=fWzDS3RC4GNaB6aqCT2jGSvLSeJTFZwMwIZqILTGqK/gf1IysVL1IfZ75Gp0UVRAkZfVcs rdrbd7hcNIY67IPtAW+TdKI9tiPddjPHceYTcgGvvnBtL0OcYjJZnme8eMtix2rs/3ppW3 V/ijWYM175302Ew6v+aWWV1Vk0ozx1M= DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1747016249; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=Q3V6PINikXfSMOOKNu6WoMw90+2FG7fdPuCXdZsG9iA=; b=wLHkxy8rK9plBewX1TYMkf569xHZ1+iX2VVGVPh6UjR3flCeZqvp9gkYkN0vcg/T3Y+FbnD0axZuk/ORsR0Q34vgRM0rQJM5MN8fKW0ItBNEkjk011DPShA0+fCeIaoxr/BZ4fW/S7goiD0yQWgXEzUe8A/vm0d9EIEf7H8+qI4= Received: from 30.74.144.145(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0WaCYvyQ_1747016247 cluster:ay36) by smtp.aliyun-inc.com; Mon, 12 May 2025 10:17:27 +0800 Message-ID: <4decbf69-23cd-4717-ad9b-3315a9df7b37@linux.alibaba.com> Date: Mon, 12 May 2025 10:17:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] mm: khugepaged: convert set_huge_pmd() to take a folio To: David Hildenbrand , akpm@linux-foundation.org, willy@infradead.org Cc: hannes@cmpxchg.org, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, npache@redhat.com, ryan.roberts@arm.com, dev.jain@arm.com, ziy@nvidia.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <239471b5-12fe-4bad-a6e1-e9f0ad195ab5@redhat.com> From: Baolin Wang In-Reply-To: <239471b5-12fe-4bad-a6e1-e9f0ad195ab5@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5461340009 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: pcah3xjbowkofcz45er7fmtgz3s31r57 X-HE-Tag: 1747016251-954443 X-HE-Meta: U2FsdGVkX19Gjs8iE4cZOYOcpmFrYEppdqJsRymxh7YtKC7lBHTOQ5c+s+9taXV3FsasaJmUXveXGA3jNJpUBK4t76I39ycSMwNSOArynsPaZSuaMxCKv3OkFgoStm6LEKZ8t2g+UuviB+ghU+FKtqDxlF3JfoUMSHBBX9bYUg71+XhUYmWaTx2kFvfWIP/JUJHmfqZogNc1vOq3P6Zum2HoVp2o0U2o+hrY4GR14m1r2nWtOC/WUwdKneE2joVd+8KBXOhbwGfI/L6gmZD4H062xT1C7GYjwoC9AJB45hXQFlErENXPhf9x9enfc/kjmcUn6xyyzwS449WNNFULPPovDF7OemKnALLb78PiArXZ/c3faS2fMdFSezJjG1SG+vXSr2qQunV9V8Gmu3bLwAORTDtaW2mYGiJR0MQgxZcc73u9Jnl9MlU78d+HI5WZI9X2Q1nNFqpsN6c0GNtSzVaj6Ea6rD+Bua4Js8MIOP/bWSJ8aCt90SJ2biMkKYAwdoKdXCoQSIsZY3RV0N355xLpeM0PuDyTeAq74Y3zLct4AAEMVSjG2A4vYxfvATJOCENjQg42P1+zvPn0S/FVNAWePObgJwSPt1cooHNy4OywM8oc+RknjjdSOwTk2k1/TSklrJzOHckC4IxkMNThVwjP57l4iXJIRje+F6AJafLgUa7R1GGYSACUrspwWrLF/FxICwDxeSLMCNTdH7Fqks60Ld9Iw6BS4yhLICLVYIdGsjw/C/tWg1VYnTDQSfV7sFzAkaCf1HYm7rk2isKHyJnykWb7T/FfHrYv4UazAvqXC3Qb0mSbsFnJ1R+JhbbzCCiFXQ+/pPHrrNQ7+2XUF/Wo/zrLDaS8mPtMAQH3dQLbrsYW86vGPPHVkVhaSHc68doViBvhn92QoLvB0ZfNjvHpru/gqNuVIysHU6dX44svBeskpCKQinlKYvOc22sE45mDsEvWVyl0Ex4jGba qseW+YAE FHBiOHBJkXo7mcvzte8sIdBFy3fU4X1L669nQtrhIOOCsav0bPreS1l7f0+5DgsrjMbIGzgp/Hm0Li47jCTyIaQDG+3XHXBMnfoymUpKnojgc6MRKBIHYEjIgs3pyVq9BDlafDqivUNx+AxGmL0cB4HRvwP5ZWBDRlMdxBtugR2MJcloUjPMsHoTH1ROSm12gFodwfM/AYH2RZ6XUKMemwEKlO0kORBZ7ePP6RyGRLRpRS/KUC36jHbznVlPXf0OyWl0e4JggN1z50da1/ERBYFiQZzk/g172rMcDO/sj5uDIcP7+KO+PBUcNzWxDieFPmDnO017IFV+FWHdO4kGvzP5Obyd7dHkTAqwA+xJzp5d7xg+QfsQ6psoZfVnWqlFLj5rZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/5/9 22:58, David Hildenbrand wrote: >> diff --git a/mm/khugepaged.c b/mm/khugepaged.c >> index b04b6a770afe..aca66e7f4fd9 100644 >> --- a/mm/khugepaged.c >> +++ b/mm/khugepaged.c >> @@ -1467,7 +1467,7 @@ static void collect_mm_slot(struct >> khugepaged_mm_slot *mm_slot) >>   #ifdef CONFIG_SHMEM >>   /* hpage must be locked, and mmap_lock must be held */ > > ^ that comment probably needs some love. Ah, missed that. Will update the comments in next version. > >>   static int set_huge_pmd(struct vm_area_struct *vma, unsigned long addr, >> -            pmd_t *pmdp, struct page *hpage) >> +            pmd_t *pmdp, struct folio *folio) >>   { >>       struct vm_fault vmf = { >>           .vma = vma, >> @@ -1476,13 +1476,12 @@ static int set_huge_pmd(struct vm_area_struct >> *vma, unsigned long addr, >>           .pmd = pmdp, >>       }; >> -    VM_BUG_ON(!PageTransHuge(hpage)); >>       mmap_assert_locked(vma->vm_mm); >> -    if (do_set_pmd(&vmf, hpage)) >> +    if (do_set_pmd(&vmf, &folio->page)) >>           return SCAN_FAIL; >> -    get_page(hpage); >> +    folio_get(folio); >>       return SCAN_SUCCEED; >>   } >> @@ -1689,7 +1688,7 @@ int collapse_pte_mapped_thp(struct mm_struct >> *mm, unsigned long addr, >>   maybe_install_pmd: >>       /* step 5: install pmd entry */ >>       result = install_pmd >> -            ? set_huge_pmd(vma, haddr, pmd, &folio->page) >> +            ? set_huge_pmd(vma, haddr, pmd, folio) > > Wondering why we are not passing in the folio+page pair in here as well. > I assume in the foreseeable future this code will not be able to work > with folios large than PMDs? OK. Will do in next version. > Apart from that LGTM. > > Acked-by: David Hildenbrand Thanks.