From: Miaohe Lin <linmiaohe@huawei.com>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Shuai Xue <xueshuai@linux.alibaba.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
Naoya Horiguchi <naoya.horiguchi@nec.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v3 2/2] mm, hwpoison: When copy-on-write hits poison, take page offline
Date: Sat, 29 Oct 2022 09:55:23 +0800 [thread overview]
Message-ID: <4de52973-7590-8ba8-62ca-c78e42f36a63@huawei.com> (raw)
In-Reply-To: <SJ1PR11MB608354A1D8817902D7FC9DFAFC329@SJ1PR11MB6083.namprd11.prod.outlook.com>
On 2022/10/29 0:13, Luck, Tony wrote:
>>> Cannot call memory_failure() directly from the fault handler because
>>> mmap_lock (and others) are held.
>>
>> Could you please explain which lock makes it unfeasible to call memory_failure() directly and
>> why? I'm somewhat confused. But I agree using memory_failure_queue() should be a good idea.
>
> I tried calling memory_failure() directly, and my system just hung. I made the assumption
> that it had deadlocked based somewhat on the comments in mm/memory.c about mmap_lock
> being held ... but I didn't dig into what had gone wrong.
I see. Thanks for your explanation. :)
>
> -Tony
>
next prev parent reply other threads:[~2022-10-29 1:55 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-17 23:42 [RFC PATCH] mm, hwpoison: Recover from copy-on-write machine checks Tony Luck
2022-10-18 8:43 ` HORIGUCHI NAOYA(堀口 直也)
2022-10-18 17:52 ` Luck, Tony
2022-10-19 17:08 ` [PATCH v2] mm, hwpoison: Try to recover from copy-on write faults Tony Luck
2022-10-19 17:45 ` Dan Williams
2022-10-19 20:30 ` Luck, Tony
2022-10-20 1:57 ` Shuai Xue
2022-10-20 20:05 ` Tony Luck
2022-10-21 1:38 ` Miaohe Lin
2022-10-21 3:57 ` Luck, Tony
2022-10-21 1:52 ` Shuai Xue
2022-10-21 4:08 ` Tony Luck
2022-10-21 4:11 ` David Laight
2022-10-21 4:41 ` Luck, Tony
2022-10-21 9:29 ` Shuai Xue
2022-10-21 16:30 ` Luck, Tony
2022-10-23 15:04 ` Shuai Xue
2022-10-21 6:57 ` Shuai Xue
2022-10-21 20:01 ` [PATCH v3 0/2] Copy-on-write poison recovery Tony Luck
2022-10-21 20:01 ` [PATCH v3 1/2] mm, hwpoison: Try to recover from copy-on write faults Tony Luck
2022-10-25 5:46 ` HORIGUCHI NAOYA(堀口 直也)
2022-10-28 2:11 ` Miaohe Lin
2022-10-28 16:09 ` Luck, Tony
2022-11-02 14:27 ` Alexander Potapenko
2022-11-02 14:30 ` Alexander Potapenko
2022-10-21 20:01 ` [PATCH v3 2/2] mm, hwpoison: When copy-on-write hits poison, take page offline Tony Luck
2022-10-28 2:28 ` Miaohe Lin
2022-10-28 16:13 ` Luck, Tony
2022-10-29 1:55 ` Miaohe Lin [this message]
2022-10-23 15:52 ` [PATCH v3 0/2] Copy-on-write poison recovery Shuai Xue
2022-10-26 5:19 ` Shuai Xue
2022-10-31 20:10 ` [PATCH v4 " Tony Luck
2022-10-31 20:10 ` [PATCH v4 1/2] mm, hwpoison: Try to recover from copy-on write faults Tony Luck
2022-10-31 20:10 ` [PATCH v4 2/2] mm, hwpoison: When copy-on-write hits poison, take page offline Tony Luck
2023-05-18 21:49 ` Jane Chu
2023-05-18 22:10 ` Luck, Tony
2023-05-19 7:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4de52973-7590-8ba8-62ca-c78e42f36a63@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=christophe.leroy@csgroup.eu \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=naoya.horiguchi@nec.com \
--cc=npiggin@gmail.com \
--cc=tony.luck@intel.com \
--cc=willy@infradead.org \
--cc=xueshuai@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox