From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A2E5E68957 for ; Thu, 31 Oct 2024 04:18:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 82F056B0092; Thu, 31 Oct 2024 00:18:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DFA56B0093; Thu, 31 Oct 2024 00:18:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6A6F26B0095; Thu, 31 Oct 2024 00:18:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4DD2E6B0092 for ; Thu, 31 Oct 2024 00:18:57 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id F2283ABBFF for ; Thu, 31 Oct 2024 04:18:56 +0000 (UTC) X-FDA: 82732591368.04.B91ECD2 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf28.hostedemail.com (Postfix) with ESMTP id 25D37C000E for ; Thu, 31 Oct 2024 04:18:27 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="FPrxW5/Q"; spf=pass (imf28.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730348253; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UkVs1Y+CuMo3+Eh4nNB4M87+SHBReCgyWbkGailay5A=; b=7KyJOW11Ba4G8hks+wg7J2jlaq5TaLaRt5KD8LDVukgO0LZBIsDfsNBOb3xVYDYB6MU2BP k7tctAb+NHk1mrP1fiA8SNOa5tntIvDy65pOZL6VP87s5GbV7RCuyzQ/dIGlow0OONmOXi 8k0EZJ1QvgyPz++irMhKsG3P+5+fq1U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730348253; a=rsa-sha256; cv=none; b=1r5c6AVhbJ1ykDvEeFe1jmx/+HUCDyiLW2hr6zvy1Rn9CNqi8ncRYhRcH8oz+PCcJwWv4U BdL+7uk3ZUOnD/s0DabcYDJ9sLT+Gf3kVs4Cs62ezkDPrs69NOPyLw9Vz7WHRGwLap48cv 8xmYc//ZvkkXJqArmNT3Ufm7lKO++JY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="FPrxW5/Q"; spf=pass (imf28.hostedemail.com: domain of groeck7@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-20ca7fc4484so4306955ad.3 for ; Wed, 30 Oct 2024 21:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730348334; x=1730953134; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=UkVs1Y+CuMo3+Eh4nNB4M87+SHBReCgyWbkGailay5A=; b=FPrxW5/QLRat3oLrKia0VgIQg4Q9YY0wo1UVfLyAa3kiDBCt9bQT5dByIXkwiJrpmA NSdl0dRMZAlGOkpuDxX0If6A1SmH6xdgq049xzq1G8gUQUfyDO+7fxJgY7CJusbWbJSY EM+oBBml8BkZ4ni0EX1wIkh8G7Qd58uWhTzHZ1TTwiaDo9d//JEgrRjofjE3csCrHS1D CeKJ86qUq7wKNw0a6Qm4fkP2h+CzdEkPwyyau++s80NY39TZPusrEW2iVkEi9/3YPjVj 4DQ5u5J9sxVkk4l/lg0k4ZgYOhylIkB0MgCFnfPOceoFcRpYdSrxWxNm0LzB36rgphwc gEow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730348334; x=1730953134; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UkVs1Y+CuMo3+Eh4nNB4M87+SHBReCgyWbkGailay5A=; b=L/Q4bsaulZ0ybwsf9UjDyPwvC7na62xGi8DUlEFjkET6ogPQ66S11tIcCGxGVtziur fq9FrfoOXOeMpicy1CqzX6fs2V5Akru6IiJl05Z/qRzDZkKv/OYxVPZBlKrKA/Fp6Odg N97AzjpUuEMmvYsNjFwtVKGcLVmC5Z5Snu0Qr+wl5JJvCUguiKVubsSoqvcut6L+jzcP PhCciVEuryzk8FVpZJnxaHv5gqSk06OfcKrnWSyhDlJrSS1maMYnrMFSjGMRWKecSMpi LaI5ucMMilvTYqAIghlO0Sgh+nMoTbfn3HnfK089YiBZoaRw6wC8YGuPAExx03Nsdcii sFYA== X-Forwarded-Encrypted: i=1; AJvYcCXll1Hlajgac1f+hMTaxbOVrenNI/ZKniREtMjWyXXx6Umvdyqdxtf5hpyv4d9zRGLEVvvQEilUlg==@kvack.org X-Gm-Message-State: AOJu0YzcdBO3ri2nyCrnjgGkkVF6Q1I9lXXTXjNXprwdH2StJvc6qC9Y QnWgtBJFJ5ffCCIoA9sHDL4DNWzq+P2DEEJ/PWRkU/kwfXAKzH1Y X-Google-Smtp-Source: AGHT+IHFWV367wh2uPQdt2rqVSEtCofg8Ekol1GCNvYosDA5Ysjy9NbyROKs/diI534vGfb87lE+9A== X-Received: by 2002:a17:902:f705:b0:205:2a59:a28c with SMTP id d9443c01a7336-210c687c61fmr217240305ad.1.1730348333529; Wed, 30 Oct 2024 21:18:53 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2110571b5ebsm3212525ad.117.2024.10.30.21.18.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2024 21:18:52 -0700 (PDT) Date: Wed, 30 Oct 2024 21:18:51 -0700 From: Guenter Roeck To: SeongJae Park Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm/damon/core: avoid overflow in damon_feed_loop_next_input() Message-ID: <4dd8ba2c-e994-417d-baa9-47e40b50c1b4@roeck-us.net> References: <20240905172405.46995-1-sj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240905172405.46995-1-sj@kernel.org> X-Rspamd-Server: rspam10 X-Stat-Signature: unph8j7f6p516cw1cf3ew4xukpbt5n7n X-Rspamd-Queue-Id: 25D37C000E X-Rspam-User: X-HE-Tag: 1730348307-916020 X-HE-Meta: U2FsdGVkX190vWdQ0gVycEJ18hjv8Ky+GXng1uwcUxAFA1fZeXJ//gJxr0gzEtDAzvN1VRmLEqxctzo3DXhIzTIY26KcGtwDSxXngLQZHkSAMDqAC75gphWe6udx+sYk1TmfNXWqB0fwv/qsccR4JuNjW9nof3scxlGdtMLSl/AvJ/o6eR85888Qj7w/XvIgqZ/6dLdnFP7+KFxzf0X0qqHo6oKmLFzZWOqwIUcJgjc9nFhS7Du3bIxOi3J5mEl7cIkQiGgP5iFdLseKjip8+Xt9JmvPB55kuDB4co5x4QDIwlMiS2hyU+XzKHB7xLhqljroliHcHHE9FRneFMJme9fHztNblAubxUjfE6BJ3RODFCZZjmBs6nuoTbsOOyH2d23Z9+nci8pd0Y2q+O3V07QGGggUW+oEySOGN4Ck+i9FAIJH45kEyDe9U6O3VQd/KWL5kxnnNzyST0BuMey1w/Jsq7UpkCxZyQX09aRiuSfb6C1PGHfzWDMVWPWHFaKxAOzG0whyUL3A7j65bcO9bwGNq6bzMsaaOsypuVtmArrNTkCPWNA4WVIlHL6Cao7QBJ/kWPLMLyT0WjsoQLdJg0OfNpdnMjJa0VF2dLgioXHzbeb0ahG5zPlxB9TqwFFJQ9YACkywdwFdbi4n1Sc8z6HsMmSG+4EZ4qJHwaqDtALFtXMA/C+vQk3Y7PjWYiaG3BmYVZZNWUabapdWgvtZtOB0VAHuSheHi4ROP5WWeSDT+sq0EEx/C2KUL96tJuuKWi0sgaOOz/Gbpk1RHruG3oGBwaDS9H05moPl2u/lPUZV7iHd89DPISvbZxWixkIIUwowpG80MxogDDqchl72bI7BFL4WcY7ccRstURhzyPFmQFkUqXO0MFuuHrJpZDJ8qEZFrV0ezuJ5P2dHMhtVg+ywl0hiFfmtg5iVTrFrJBUxHV0JDVDp6AiEZrfXaiCDv/Usn8YCVBNr7JgEvju QrhVevlG hWsY2aN7Zjok4SkMslhvQ9ifDzQFBACKZc8g0ZJKDYZliMF7nj9sAbPgokT8/h5h4e4To7WeEK0DRvt89qC5O+QusjwrMQC86ZCFFMAvB7ILcfW8y7yXZX48kE/eKWJW9Z2lUGdByZyERW7UOSbcFKXCF+d39oLoxYlro5MqjS8x/DOpUwLF9ZNZaYq4I9rB0th11YWty2oeNp8YVCIjjSRZJ5iZUhKF8y3T7dZSlf6c0mhkdH4oreQuj4dFkpRj0ySJ8H9t01x1TzdBamaLtfzg+EnzqLpbB1Z4Gf2NidhsUQDJXMkjxbb0yfKmhcM9lo/n0zCrwmZ1NziAgnoYRXZmhz3GykCjxJDdoXFKmO2U5Q6TkyyF7s7ooI0VA6bFVkr36+uv6GoGtVVQ9dyf5cA+QrnaYlztnOtSZ5Y6p7rKoNKk+83vRTvZYa04vrYdkAQqWrWzHPx164dm13IAlCoZlz3fRZByJOywxQIPFm8Ydx9gORtsupvWmXKfhnIM19rH8puBbeO+N++za183lVPS7b14Vr4G9K++8XtQrz0LoFCTYf5fcL0KrTZFoJPwjkjtn6VA3NfLiLFEpo9mkchMNBzAq3RAUDxyUMWULdPfYbR8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.014388, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 10:24:05AM -0700, SeongJae Park wrote: > damon_feed_loop_next_input() is fragile to overflows. Rewrite code to > avoid overflows. This is not yet well tested on 32bit archs. > > Reported-by: Guenter Roeck > Closes: https://lore.kernel.org/944f3d5b-9177-48e7-8ec9-7f1331a3fea3@roeck-us.net > Fixes: 9294a037c015 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning") > Signed-off-by: SeongJae Park > --- > As mentioned on the commit message, this is not yet sufficiently tested > on 32bit machines. That's why this is RFC. Is that patch going anywhere ? I have been testing it on a lot of 32-bit architectures, and I do not see any failures. Guenter