From: Guenter Roeck <linux@roeck-us.net>
To: SeongJae Park <sj@kernel.org>
Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] mm/damon/core: avoid overflow in damon_feed_loop_next_input()
Date: Wed, 30 Oct 2024 21:18:51 -0700 [thread overview]
Message-ID: <4dd8ba2c-e994-417d-baa9-47e40b50c1b4@roeck-us.net> (raw)
In-Reply-To: <20240905172405.46995-1-sj@kernel.org>
On Thu, Sep 05, 2024 at 10:24:05AM -0700, SeongJae Park wrote:
> damon_feed_loop_next_input() is fragile to overflows. Rewrite code to
> avoid overflows. This is not yet well tested on 32bit archs.
>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Closes: https://lore.kernel.org/944f3d5b-9177-48e7-8ec9-7f1331a3fea3@roeck-us.net
> Fixes: 9294a037c015 ("mm/damon/core: implement goal-oriented feedback-driven quota auto-tuning")
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
> As mentioned on the commit message, this is not yet sufficiently tested
> on 32bit machines. That's why this is RFC.
Is that patch going anywhere ? I have been testing it on a lot of 32-bit architectures,
and I do not see any failures.
Guenter
next prev parent reply other threads:[~2024-10-31 4:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 17:24 SeongJae Park
2024-09-05 21:40 ` Guenter Roeck
2024-10-31 4:18 ` Guenter Roeck [this message]
2024-10-31 5:21 ` SeongJae Park
2024-11-01 14:16 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dd8ba2c-e994-417d-baa9-47e40b50c1b4@roeck-us.net \
--to=linux@roeck-us.net \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox