* Re: [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections
2025-05-08 15:28 [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections Lorenzo Stoakes
@ 2025-05-08 15:33 ` Lorenzo Stoakes
2025-05-08 16:11 ` Kees Cook
2025-05-08 15:38 ` David Hildenbrand
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Lorenzo Stoakes @ 2025-05-08 15:33 UTC (permalink / raw)
To: Andrew Morton
Cc: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Valentin Schneider, David Hildenbrand, Liam R . Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Kees Cook, linux-kernel, linux-mm, Christian Brauner
+cc Christian
And Murphy's law dictates that I forget to add the pidfd bit. Fix-patch
included...
Adding pidfd as there's a fair chunk of pidfd code that lives in
kernel/fork.c. Obviously let me know Christian if you feel this makes
sense.
Thanks! And apologies for noise...
On Thu, May 08, 2025 at 04:28:25PM +0100, Lorenzo Stoakes wrote:
> Currently kernel/fork.c both contains absolutely key logic relating to a
> number of kernel subsystems and also has absolutely no assignment in
> MAINTAINERS.
>
> Correct this by placing this file in relevant sections - mm core, exec,
> scheduler and pidfd so people know who to contact when making changes here.
>
> scripts/get_maintainers.pl can perfectly well handle a file being in
> multiple sections, so this functions correctly.
>
> Intent is that we keep putting changes to kernel/fork.c through Andrew's
> tree.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ccc45b0ba843..55332d5bc499 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8830,6 +8830,7 @@ F: include/linux/elf.h
> F: include/uapi/linux/auxvec.h
> F: include/uapi/linux/binfmts.h
> F: include/uapi/linux/elf.h
> +F: kernel/fork.c
> F: mm/vma_exec.c
> F: tools/testing/selftests/exec/
> N: asm/elf.h
> @@ -15525,6 +15526,7 @@ F: include/linux/mm.h
> F: include/linux/mm_*.h
> F: include/linux/mmdebug.h
> F: include/linux/pagewalk.h
> +F: kernel/fork.c
> F: mm/Kconfig
> F: mm/debug.c
> F: mm/init-mm.c
> @@ -21742,6 +21744,7 @@ F: include/linux/preempt.h
> F: include/linux/sched.h
> F: include/linux/wait.h
> F: include/uapi/linux/sched.h
> +F: kernel/fork.c
> F: kernel/sched/
>
> SCHEDULER - SCHED_EXT
> --
> 2.49.0
>
----8<----
From 6ab14cfd38a34fc097207dd6b898004a87b9cfa2 Mon Sep 17 00:00:00 2001
From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Date: Thu, 8 May 2025 16:30:58 +0100
Subject: [PATCH] add missing pidfd entry
Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 55332d5bc499..af1ab3ddc699 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -19135,6 +19135,7 @@ M: Christian Brauner <christian@brauner.io>
L: linux-kernel@vger.kernel.org
S: Maintained
T: git git://git.kernel.org/pub/scm/linux/kernel/git/brauner/linux.git
+F: kernel/fork.c
F: samples/pidfd/
F: tools/testing/selftests/clone3/
F: tools/testing/selftests/pid_namespace/
--
2.49.0
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections
2025-05-08 15:33 ` Lorenzo Stoakes
@ 2025-05-08 16:11 ` Kees Cook
0 siblings, 0 replies; 8+ messages in thread
From: Kees Cook @ 2025-05-08 16:11 UTC (permalink / raw)
To: Lorenzo Stoakes
Cc: Andrew Morton, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Valentin Schneider, David Hildenbrand,
Liam R . Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Michal Hocko, linux-kernel, linux-mm,
Christian Brauner
On Thu, May 08, 2025 at 04:33:33PM +0100, Lorenzo Stoakes wrote:
> +cc Christian
>
> And Murphy's law dictates that I forget to add the pidfd bit. Fix-patch
> included...
>
> Adding pidfd as there's a fair chunk of pidfd code that lives in
> kernel/fork.c. Obviously let me know Christian if you feel this makes
> sense.
>
> Thanks! And apologies for noise...
>
> On Thu, May 08, 2025 at 04:28:25PM +0100, Lorenzo Stoakes wrote:
> > Currently kernel/fork.c both contains absolutely key logic relating to a
> > number of kernel subsystems and also has absolutely no assignment in
> > MAINTAINERS.
> >
> > Correct this by placing this file in relevant sections - mm core, exec,
> > scheduler and pidfd so people know who to contact when making changes here.
> >
> > scripts/get_maintainers.pl can perfectly well handle a file being in
> > multiple sections, so this functions correctly.
> >
> > Intent is that we keep putting changes to kernel/fork.c through Andrew's
> > tree.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> > ---
> > MAINTAINERS | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ccc45b0ba843..55332d5bc499 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -8830,6 +8830,7 @@ F: include/linux/elf.h
> > F: include/uapi/linux/auxvec.h
> > F: include/uapi/linux/binfmts.h
> > F: include/uapi/linux/elf.h
> > +F: kernel/fork.c
> > F: mm/vma_exec.c
> > F: tools/testing/selftests/exec/
> > N: asm/elf.h
> > @@ -15525,6 +15526,7 @@ F: include/linux/mm.h
> > F: include/linux/mm_*.h
> > F: include/linux/mmdebug.h
> > F: include/linux/pagewalk.h
> > +F: kernel/fork.c
> > F: mm/Kconfig
> > F: mm/debug.c
> > F: mm/init-mm.c
> > @@ -21742,6 +21744,7 @@ F: include/linux/preempt.h
> > F: include/linux/sched.h
> > F: include/linux/wait.h
> > F: include/uapi/linux/sched.h
> > +F: kernel/fork.c
> > F: kernel/sched/
> >
> > SCHEDULER - SCHED_EXT
> > --
> > 2.49.0
> >
>
> ----8<----
> From 6ab14cfd38a34fc097207dd6b898004a87b9cfa2 Mon Sep 17 00:00:00 2001
> From: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> Date: Thu, 8 May 2025 16:30:58 +0100
> Subject: [PATCH] add missing pidfd entry
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Yes, please. :) Thanks!
Reviewed-by: Kees Cook <kees@kernel.org>
--
Kees Cook
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections
2025-05-08 15:28 [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections Lorenzo Stoakes
2025-05-08 15:33 ` Lorenzo Stoakes
@ 2025-05-08 15:38 ` David Hildenbrand
2025-05-12 7:41 ` Vlastimil Babka
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: David Hildenbrand @ 2025-05-08 15:38 UTC (permalink / raw)
To: Lorenzo Stoakes, Andrew Morton
Cc: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Valentin Schneider, Liam R . Howlett, Vlastimil Babka,
Mike Rapoport, Suren Baghdasaryan, Michal Hocko, Kees Cook,
linux-kernel, linux-mm
On 08.05.25 17:28, Lorenzo Stoakes wrote:
> Currently kernel/fork.c both contains absolutely key logic relating to a
> number of kernel subsystems and also has absolutely no assignment in
> MAINTAINERS.
>
> Correct this by placing this file in relevant sections - mm core, exec,
> scheduler and pidfd so people know who to contact when making changes here.
>
> scripts/get_maintainers.pl can perfectly well handle a file being in
> multiple sections, so this functions correctly.
>
> Intent is that we keep putting changes to kernel/fork.c through Andrew's
> tree.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ccc45b0ba843..55332d5bc499 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8830,6 +8830,7 @@ F: include/linux/elf.h
> F: include/uapi/linux/auxvec.h
> F: include/uapi/linux/binfmts.h
> F: include/uapi/linux/elf.h
> +F: kernel/fork.c
> F: mm/vma_exec.c
> F: tools/testing/selftests/exec/
> N: asm/elf.h
> @@ -15525,6 +15526,7 @@ F: include/linux/mm.h
> F: include/linux/mm_*.h
> F: include/linux/mmdebug.h
> F: include/linux/pagewalk.h
> +F: kernel/fork.c
> F: mm/Kconfig
> F: mm/debug.c
> F: mm/init-mm.c
> @@ -21742,6 +21744,7 @@ F: include/linux/preempt.h
> F: include/linux/sched.h
> F: include/linux/wait.h
> F: include/uapi/linux/sched.h
> +F: kernel/fork.c
> F: kernel/sched/
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections
2025-05-08 15:28 [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections Lorenzo Stoakes
2025-05-08 15:33 ` Lorenzo Stoakes
2025-05-08 15:38 ` David Hildenbrand
@ 2025-05-12 7:41 ` Vlastimil Babka
2025-05-12 7:55 ` Michal Hocko
2025-05-12 13:04 ` Peter Zijlstra
4 siblings, 0 replies; 8+ messages in thread
From: Vlastimil Babka @ 2025-05-12 7:41 UTC (permalink / raw)
To: Lorenzo Stoakes, Andrew Morton
Cc: Ingo Molnar, Peter Zijlstra, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Valentin Schneider, David Hildenbrand, Liam R . Howlett,
Mike Rapoport, Suren Baghdasaryan, Michal Hocko, Kees Cook,
linux-kernel, linux-mm
On 5/8/25 17:28, Lorenzo Stoakes wrote:
> Currently kernel/fork.c both contains absolutely key logic relating to a
> number of kernel subsystems and also has absolutely no assignment in
> MAINTAINERS.
>
> Correct this by placing this file in relevant sections - mm core, exec,
> scheduler and pidfd so people know who to contact when making changes here.
>
> scripts/get_maintainers.pl can perfectly well handle a file being in
> multiple sections, so this functions correctly.
>
> Intent is that we keep putting changes to kernel/fork.c through Andrew's
> tree.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ccc45b0ba843..55332d5bc499 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8830,6 +8830,7 @@ F: include/linux/elf.h
> F: include/uapi/linux/auxvec.h
> F: include/uapi/linux/binfmts.h
> F: include/uapi/linux/elf.h
> +F: kernel/fork.c
> F: mm/vma_exec.c
> F: tools/testing/selftests/exec/
> N: asm/elf.h
> @@ -15525,6 +15526,7 @@ F: include/linux/mm.h
> F: include/linux/mm_*.h
> F: include/linux/mmdebug.h
> F: include/linux/pagewalk.h
> +F: kernel/fork.c
> F: mm/Kconfig
> F: mm/debug.c
> F: mm/init-mm.c
> @@ -21742,6 +21744,7 @@ F: include/linux/preempt.h
> F: include/linux/sched.h
> F: include/linux/wait.h
> F: include/uapi/linux/sched.h
> +F: kernel/fork.c
> F: kernel/sched/
>
> SCHEDULER - SCHED_EXT
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections
2025-05-08 15:28 [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections Lorenzo Stoakes
` (2 preceding siblings ...)
2025-05-12 7:41 ` Vlastimil Babka
@ 2025-05-12 7:55 ` Michal Hocko
2025-05-12 13:04 ` Peter Zijlstra
4 siblings, 0 replies; 8+ messages in thread
From: Michal Hocko @ 2025-05-12 7:55 UTC (permalink / raw)
To: Lorenzo Stoakes
Cc: Andrew Morton, Ingo Molnar, Peter Zijlstra, Juri Lelli,
Vincent Guittot, Dietmar Eggemann, Steven Rostedt, Ben Segall,
Mel Gorman, Valentin Schneider, David Hildenbrand,
Liam R . Howlett, Vlastimil Babka, Mike Rapoport,
Suren Baghdasaryan, Kees Cook, linux-kernel, linux-mm
On Thu 08-05-25 16:28:25, Lorenzo Stoakes wrote:
> Currently kernel/fork.c both contains absolutely key logic relating to a
> number of kernel subsystems and also has absolutely no assignment in
> MAINTAINERS.
>
> Correct this by placing this file in relevant sections - mm core, exec,
> scheduler and pidfd so people know who to contact when making changes here.
>
> scripts/get_maintainers.pl can perfectly well handle a file being in
> multiple sections, so this functions correctly.
>
> Intent is that we keep putting changes to kernel/fork.c through Andrew's
> tree.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
--
Michal Hocko
SUSE Labs
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections
2025-05-08 15:28 [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections Lorenzo Stoakes
` (3 preceding siblings ...)
2025-05-12 7:55 ` Michal Hocko
@ 2025-05-12 13:04 ` Peter Zijlstra
2025-05-12 13:16 ` Lorenzo Stoakes
4 siblings, 1 reply; 8+ messages in thread
From: Peter Zijlstra @ 2025-05-12 13:04 UTC (permalink / raw)
To: Lorenzo Stoakes
Cc: Andrew Morton, Ingo Molnar, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Valentin Schneider, David Hildenbrand, Liam R . Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Kees Cook, linux-kernel, linux-mm
On Thu, May 08, 2025 at 04:28:25PM +0100, Lorenzo Stoakes wrote:
> Currently kernel/fork.c both contains absolutely key logic relating to a
> number of kernel subsystems and also has absolutely no assignment in
> MAINTAINERS.
>
> Correct this by placing this file in relevant sections - mm core, exec,
> scheduler and pidfd so people know who to contact when making changes here.
>
> scripts/get_maintainers.pl can perfectly well handle a file being in
> multiple sections, so this functions correctly.
>
> Intent is that we keep putting changes to kernel/fork.c through Andrew's
> tree.
>
> Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> ---
> MAINTAINERS | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ccc45b0ba843..55332d5bc499 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8830,6 +8830,7 @@ F: include/linux/elf.h
> F: include/uapi/linux/auxvec.h
> F: include/uapi/linux/binfmts.h
> F: include/uapi/linux/elf.h
> +F: kernel/fork.c
> F: mm/vma_exec.c
> F: tools/testing/selftests/exec/
> N: asm/elf.h
> @@ -15525,6 +15526,7 @@ F: include/linux/mm.h
> F: include/linux/mm_*.h
> F: include/linux/mmdebug.h
> F: include/linux/pagewalk.h
> +F: kernel/fork.c
> F: mm/Kconfig
> F: mm/debug.c
> F: mm/init-mm.c
> @@ -21742,6 +21744,7 @@ F: include/linux/preempt.h
> F: include/linux/sched.h
> F: include/linux/wait.h
> F: include/uapi/linux/sched.h
> +F: kernel/fork.c
> F: kernel/sched/
>
> SCHEDULER - SCHED_EXT
> --
> 2.49.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [RFC PATCH] MAINTAINERS: add kernel/fork.c to relevant sections
2025-05-12 13:04 ` Peter Zijlstra
@ 2025-05-12 13:16 ` Lorenzo Stoakes
0 siblings, 0 replies; 8+ messages in thread
From: Lorenzo Stoakes @ 2025-05-12 13:16 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Andrew Morton, Ingo Molnar, Juri Lelli, Vincent Guittot,
Dietmar Eggemann, Steven Rostedt, Ben Segall, Mel Gorman,
Valentin Schneider, David Hildenbrand, Liam R . Howlett,
Vlastimil Babka, Mike Rapoport, Suren Baghdasaryan, Michal Hocko,
Kees Cook, linux-kernel, linux-mm
On Mon, May 12, 2025 at 03:04:33PM +0200, Peter Zijlstra wrote:
> On Thu, May 08, 2025 at 04:28:25PM +0100, Lorenzo Stoakes wrote:
> > Currently kernel/fork.c both contains absolutely key logic relating to a
> > number of kernel subsystems and also has absolutely no assignment in
> > MAINTAINERS.
> >
> > Correct this by placing this file in relevant sections - mm core, exec,
> > scheduler and pidfd so people know who to contact when making changes here.
> >
> > scripts/get_maintainers.pl can perfectly well handle a file being in
> > multiple sections, so this functions correctly.
> >
> > Intent is that we keep putting changes to kernel/fork.c through Andrew's
> > tree.
> >
> > Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@oracle.com>
>
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Thanks!
Non-RFC'd version will be going out soon.
>
> > ---
> > MAINTAINERS | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ccc45b0ba843..55332d5bc499 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -8830,6 +8830,7 @@ F: include/linux/elf.h
> > F: include/uapi/linux/auxvec.h
> > F: include/uapi/linux/binfmts.h
> > F: include/uapi/linux/elf.h
> > +F: kernel/fork.c
> > F: mm/vma_exec.c
> > F: tools/testing/selftests/exec/
> > N: asm/elf.h
> > @@ -15525,6 +15526,7 @@ F: include/linux/mm.h
> > F: include/linux/mm_*.h
> > F: include/linux/mmdebug.h
> > F: include/linux/pagewalk.h
> > +F: kernel/fork.c
> > F: mm/Kconfig
> > F: mm/debug.c
> > F: mm/init-mm.c
> > @@ -21742,6 +21744,7 @@ F: include/linux/preempt.h
> > F: include/linux/sched.h
> > F: include/linux/wait.h
> > F: include/uapi/linux/sched.h
> > +F: kernel/fork.c
> > F: kernel/sched/
> >
> > SCHEDULER - SCHED_EXT
> > --
> > 2.49.0
> >
^ permalink raw reply [flat|nested] 8+ messages in thread