From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB061C25B76 for ; Mon, 3 Jun 2024 06:04:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A57A6B0093; Mon, 3 Jun 2024 02:04:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 255216B0095; Mon, 3 Jun 2024 02:04:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11D616B0098; Mon, 3 Jun 2024 02:04:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E93376B0093 for ; Mon, 3 Jun 2024 02:04:22 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8F9FEC0385 for ; Mon, 3 Jun 2024 06:04:22 +0000 (UTC) X-FDA: 82188537564.15.619BEFC Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) by imf30.hostedemail.com (Postfix) with ESMTP id 56F2A8001F for ; Mon, 3 Jun 2024 06:04:19 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Th/GCHfE"; spf=pass (imf30.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717394659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VAJn/Jtb/IU6mglsNtTOn+b7ZlaaeT7CsuHSdA2/NbQ=; b=PCDVhX3zs6/jmtpJgfQ4RmIhOLeSSAot9ym+FgpEfGR+Vhk2FrD0z4e48x95KgO0c2LBN9 s5LMfC+NN617mmalJumEz4CUsO5WKxSPUFY7u9y0D8T0UX5E9ctQKsFKlKVdStwE62owqY Rz9NS9KVE2C+J1u1172YYT5KHoWwMOI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717394659; a=rsa-sha256; cv=none; b=lPY/1M6dcyCUo9DXnhiZORTXeasceDBeggVxwpOtswkuDGnANJlxb5sU70TQkZkKaaIxy4 KERsGcnDku4+DdE+Oq6FvgPFwqGy1ncNihxRjd9I6anyCRFzsG+49jVIKbk0wyNVnUmQMa ypZnwg8U7QpV4gWfELsnYUGXdveugmI= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Th/GCHfE"; spf=pass (imf30.hostedemail.com: domain of chengming.zhou@linux.dev designates 95.215.58.181 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev X-Envelope-To: yosryahmed@google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1717394657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VAJn/Jtb/IU6mglsNtTOn+b7ZlaaeT7CsuHSdA2/NbQ=; b=Th/GCHfEXrsGLfvyxPZwtXH5pDG5jI+gNqOkuAgi6WgEbWaGMKlZyzo+WHqBx3Xgi/VY73 6ae0Lb/yIW8ZJLAbyS6nqHdk/mgoCKcjs3wu5itDWaa289CPPNKl/DHkinouemD+8wYbpO 5EphkgFc30BOvgnr5Dlo5TgUP3HfTTw= X-Envelope-To: akpm@linux-foundation.org X-Envelope-To: hannes@cmpxchg.org X-Envelope-To: nphamcs@gmail.com X-Envelope-To: willy@infradead.org X-Envelope-To: linux-mm@kvack.org X-Envelope-To: linux-kernel@vger.kernel.org Message-ID: <4daef95a-4cb0-4292-9775-a0fe9993205f@linux.dev> Date: Mon, 3 Jun 2024 14:03:45 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/3] mm: zswap: use sg_set_folio() in zswap_{compress/decompress}() To: Yosry Ahmed , Andrew Morton Cc: Johannes Weiner , Nhat Pham , Matthew Wilcox , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240524033819.1953587-1-yosryahmed@google.com> <20240524033819.1953587-2-yosryahmed@google.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240524033819.1953587-2-yosryahmed@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 56F2A8001F X-Rspam-User: X-Stat-Signature: nrtnrzby73xhtgcj7a1i6ek5r5piydfo X-HE-Tag: 1717394659-297447 X-HE-Meta: U2FsdGVkX187z/J0V5NiEi6LKdjdnFTz3Jw1hUZSPXfF/wY/c0a4uRT+xvQn/e3AUVGogyRUUCbvroWVEZ9/ZeVIKERs3GoZVzVnGBfmzZSru5xUJvWRgDAiVKXuv23E42ym9lgQs8LouXaYXGRn7hqVeWunjzyay17AtxaUYZe2Q1MSZ/kTi4Ol9TSnI+qBoqUuJiXRgWCmCtSoc+/W46Eoz0WyaduzqetQi3L1zPURolHnKhNhZD/y9VG/3ZG/SzAwsbLjHc+7W1UR6kORjZ9K8S9oS7s2NvzeuJf3mG4a7dwvWShwtNLRER8knzNM5Cx1S+RX5oGv2f8lQdjAWey1Oit2gMQ59RjXBcHUcask81HnFzoNY+kzVncCkGPFnQdAMHNbfTdv27+Obkp6gqvTW3vUcFEE7wEiye79pGQQsnk0+K66LfzNMNtydPYWHt4Bm/B1vAdm1O6OF2Bi0CEobksvm57aMRyYzsmPpoTZ59DY5pjliP5wCvpoS1+o1TbWmTrEsgdvx6OkXCL8DE8ya30Lwj0F0SjTnoBzI95jdsCJJF8MPT2UQx3jqz/KGHrWVDM+W3WPml4YN9R8lM7jwoCo/Xs3JbVMUJQsKJzUZgiN/k5huWaaiSbawLfW3NbkwTyW2V3svoQRVNoYpd2mDZYOkXBKVPaVYRNuhuLV2r9zseJLzbzHn57xLF1Zl7Jt0iRas7EWK08YmIEZx+9HnI7QNW2WlFkf86gy3G4RKit7fvFNP9Vx6DhlY47/l8w3KLpnhFoMj75tPUrIq8wHm/In4c2pXo0FXtl15qe+GPxazfxb9y0st6Ifv2VPCImoUqHNt2bh3lC9CE1COrdcienut2+4EynCW3nzkrGe3KIpPg7ari6RQwPthFPAKJN0AGbow0pWVTbKsxzNVMNvjpn0cUf5JmA8WpIRcL4MdMucx5p4b1OQwA/qv1OHTQlaGiPoNJH7pQ77FHp pNWmsDGA ykfSh+oq7ojqP1mYD4VA10AYz+MjC+fWkC8BHdEbcSrYspfezkX+GGF2RM06fky8XH28Sh+XgsLYpAHC207uuA8D+SKawbMEjuiv8wnaPK5jGYaO4QZ8wmTfGhyMirPoK+8GixIQZQoyBDy2xtuqb1RSzlO6s/Qp2Pgd4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/5/24 11:38, Yosry Ahmed wrote: > sg_set_folio() is equivalent to sg_set_page() for order-0 folios, which > are the only ones supported by zswap. Now zswap_decompress() can take in > a folio directly. > > Signed-off-by: Yosry Ahmed LGTM, thanks! Reviewed-by: Chengming Zhou > --- > mm/zswap.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index a50e2986cd2fa..3693df96c81fe 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -917,7 +917,7 @@ static bool zswap_compress(struct folio *folio, struct zswap_entry *entry) > > dst = acomp_ctx->buffer; > sg_init_table(&input, 1); > - sg_set_page(&input, &folio->page, PAGE_SIZE, 0); > + sg_set_folio(&input, folio, PAGE_SIZE, 0); > > /* > * We need PAGE_SIZE * 2 here since there maybe over-compression case, > @@ -971,7 +971,7 @@ static bool zswap_compress(struct folio *folio, struct zswap_entry *entry) > return comp_ret == 0 && alloc_ret == 0; > } > > -static void zswap_decompress(struct zswap_entry *entry, struct page *page) > +static void zswap_decompress(struct zswap_entry *entry, struct folio *folio) > { > struct zpool *zpool = zswap_find_zpool(entry); > struct scatterlist input, output; > @@ -1000,7 +1000,7 @@ static void zswap_decompress(struct zswap_entry *entry, struct page *page) > > sg_init_one(&input, src, entry->length); > sg_init_table(&output, 1); > - sg_set_page(&output, page, PAGE_SIZE, 0); > + sg_set_folio(&output, folio, PAGE_SIZE, 0); > acomp_request_set_params(acomp_ctx->req, &input, &output, entry->length, PAGE_SIZE); > BUG_ON(crypto_wait_req(crypto_acomp_decompress(acomp_ctx->req), &acomp_ctx->wait)); > BUG_ON(acomp_ctx->req->dlen != PAGE_SIZE); > @@ -1073,7 +1073,7 @@ static int zswap_writeback_entry(struct zswap_entry *entry, > return -ENOMEM; > } > > - zswap_decompress(entry, &folio->page); > + zswap_decompress(entry, folio); > > count_vm_event(ZSWPWB); > if (entry->objcg) > @@ -1580,7 +1580,7 @@ bool zswap_load(struct folio *folio) > return false; > > if (entry->length) > - zswap_decompress(entry, page); > + zswap_decompress(entry, folio); > else { > dst = kmap_local_page(page); > zswap_fill_page(dst, entry->value);