From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E23C4345F for ; Sat, 27 Apr 2024 04:51:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 666F56B0088; Sat, 27 Apr 2024 00:51:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EE936B008A; Sat, 27 Apr 2024 00:51:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 48F466B008C; Sat, 27 Apr 2024 00:51:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 287FB6B0088 for ; Sat, 27 Apr 2024 00:51:26 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A6DDA1A03B4 for ; Sat, 27 Apr 2024 04:51:25 +0000 (UTC) X-FDA: 82054088130.24.75C0709 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by imf21.hostedemail.com (Postfix) with ESMTP id EB0DB1C0009 for ; Sat, 27 Apr 2024 04:51:23 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gVqeXQ5p; spf=pass (imf21.hostedemail.com: domain of rientjes@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714193484; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oDKNYdu4gZc+ksqRSwTeYjKJkvQsY4pNLxKz9bWZQaI=; b=j4uV3afHqoeiViRDbZd6LSZIMp8ap5OHE28PEjL3r/+Rn096QY8lrNVduJoRhfHoFA+a4Z VhRXba+JpgvLGs5A6OlxBvdRe028kirKlYdyuFL+t4FBoqMwj23tMcewKoftcIi1W4hIVk 9/9Qolt/hBJeOvh8g9oJXSJHf5Fg3ic= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714193484; a=rsa-sha256; cv=none; b=OG0+upfGyUJWEIaox2pecSIG+ruUN/0kJdw4j4h9fd3R2c5tDvMB6/vQ3OkWyKQ8vLuUjZ SE/JYjeqAPuuF9H1hSCRG98De8D9GpfQYo5lF67WRCovJrIBdtWtn8g9e8lE+udlRwDBDf njYQotU5UthcryHOvE+S4wN4zgellYY= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=gVqeXQ5p; spf=pass (imf21.hostedemail.com: domain of rientjes@google.com designates 209.85.214.181 as permitted sender) smtp.mailfrom=rientjes@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1e8fcb0b860so48405ad.0 for ; Fri, 26 Apr 2024 21:51:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714193483; x=1714798283; darn=kvack.org; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=oDKNYdu4gZc+ksqRSwTeYjKJkvQsY4pNLxKz9bWZQaI=; b=gVqeXQ5pn+O/2T6ttXVP4uj5iO00L6cKrACGd6FSmu1jkdqitSXpHUyAQ42OGVeqRc UxpGB38RsKi6QJHViP03ovSwQEJCK8nmYtM6EvWoQiW8begVHkxYrOGv36RqFi5zOXTe +hnSQKdoBwnWxc56oR/NedXHrXnpe+utnsygP8+5gHwwBdrkenekmCwHU08xaQZVvIeC 0cc41UpL4a0ej1eDQRYx5sLk4E6Xk9dwgh/UJgchR2m+Pe2MvFb5m4kBGdu+bSkWOOsq +Zxsw8K5owE8fDwXNMUUbzvvNzew4PyZkyrpU5FMbwCb2efD6mbv3sGlkN4Udi0PLDcc OGOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714193483; x=1714798283; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oDKNYdu4gZc+ksqRSwTeYjKJkvQsY4pNLxKz9bWZQaI=; b=eXxVGvi7I4mB7pJr1sQm9FTzic2iqQtddCPK8oD1mIOjDJ/CJATXRWfZGU7SP7Djbr wWlOqx3s8c9nqDdeaJtNwRDU/E+kZe1jdFOkg8AQJ+m9o+Vc4rO04y9B6zBTVPpPpN3r icSIoVmpVG17CNI4mQMNGvODf/cBz/lR34BxABPZUG4FzOGkXPxg3+Q8HaNZFMrjUvqr SEhHSidqtrh8/fq6yVkop6ywahs2H/8oXuPgdnN6Iv1LUL33xuGMx7GdJEy4Vz2rbbCX NrWzYcQniHZGTz6XMSsmgxENTSIIpqC2CpgRoWKSeYJw1O+fe2QQRUCuh7kPRtpootyr yxyg== X-Gm-Message-State: AOJu0YzvPdAA1lEVsLG61xaMrmpKjUu7CbQFPs/uLaBBEDl7/dEtBetH TumDK2AYlQYFmxrmVa806WuB0dOU8gjoickNKHJ/+k0y3tf0O4NI60h93ZHVtQ== X-Google-Smtp-Source: AGHT+IH6uhqTKhNjTxdneyfvAjxuh57dhsEx7v7FTJEKXvdXMn40aSWMyqTNHa8CfTTmhNtx2KfV9Q== X-Received: by 2002:a17:903:252:b0:1e3:d0f0:4623 with SMTP id j18-20020a170903025200b001e3d0f04623mr66842plh.17.1714193482183; Fri, 26 Apr 2024 21:51:22 -0700 (PDT) Received: from [2620:0:1008:15:127e:6b08:ad38:79c9] ([2620:0:1008:15:127e:6b08:ad38:79c9]) by smtp.gmail.com with ESMTPSA id s19-20020a17090a881300b002a5d684a6a7sm15267000pjn.10.2024.04.26.21.51.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Apr 2024 21:51:21 -0700 (PDT) Date: Fri, 26 Apr 2024 21:51:21 -0700 (PDT) From: David Rientjes To: Hyunmin Lee cc: linux-mm@kvack.org, Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Jeungwoo Yoo , Sangyun Kim , Gwan-gyeong Mun Subject: Re: [PATCH v3 2/2] mm/slub: remove the check for NULL kmalloc_caches In-Reply-To: <20240424140422.12780-3-hyunminlr@gmail.com> Message-ID: <4dae02cf-5f78-d31a-206c-19895f184b87@google.com> References: <20240424140422.12780-1-hyunminlr@gmail.com> <20240424140422.12780-3-hyunminlr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Stat-Signature: uoeh9wgs1qayjb6wj3zoq4te6jcrnbu6 X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: EB0DB1C0009 X-HE-Tag: 1714193483-70730 X-HE-Meta: U2FsdGVkX199RZUa1bBXi8x7v54h4T7vAqChLT9kFrXH72YPZfKCr4NPKvPtaVIpt12J+Hrsg4jDZmUDoHHzHpgrWksB7HCPfpau4zIIUujnVcf464sAGg7Pku/ZrdBudqo4viAk0ybjx9li+tY7PpdeGyBvToKkmag6V6qLvKoCxMVuVl1YPGgmAJsHHzNoPum6gUxGHwUE+E013UL1zD3UUtGSXWkOT8YjCa1cfcxEMwDJe+j36nxDkmH7X7TqPYrZt7fR1c41nDOZ6UFi/eGFEAUc1uJNI8x3qNhMW6wdPSD1QDNf4YRTu4uDjMZRHYlP3NdM0Ht6EJp13ELdMcmBqrC1UuJ6uAEg+EJ4eAYjyi/rsNnztNmgHXCNUl668yiodD5UeEUk+Tjsa3ptn0npOTeB8H7qkyhg9v332TusrUmuQi8oAtC5AZeqDzp6gVXLcLtRyHlq4KGqftZqcemNPJgRE/dBKOQPuDLdjPB8pzhmnEZYQFqpNGcNDMHqbK8+e2jitFm3Cpr/2639/ILR0x5czeCCQJa9DXwMugxCL3o0DlJheyCvrZBoK9dKN4cJxV3Ih17J2DJd7H1CkdNo3taxc8PLRQic7Ie0IZDJcKdRk406ia2ndjRti0G232fvzJ/faqFRyDjIvxpP+G2Ls5FkHWqJYKslGWt6PsyvHcNQ1/e8hhHqBN1ax6YaDhoj5ugh6iwIiYgbOgNHisczQaQFdymL0GZjE0pZQVqDXUEl/DA5iDOB6KPuIx04x0IEYRcZEZI90we9JDFxbRavZozPiLDHNThNdYPjhlb+hytKBMbWMKERPcairHI4g3iOSfaDcnhcPU4gEWy0qpF8jJ8nbawHRmZy3HctfBgNIzk7P/Sf3HRFlBqfyBgf/4/+oTZmSj/bllU4LCd1ixSj69EFJHKZfFR7Loyo8zjBmJou2CD7ArArAofrEw1/2E91/dk2NJwGWkroLGr rabbFEkR FL18zhdRG+kzb3xbkqfchjnNP5wjcQLCvBULRhFCbPdResDOuzxPoAoi3foiFOHlHY6SuXpqVoTpD0z34Y6f81kdsuDGt8Rn5I+rGAcd+2YDhfEpQ9zEdv9pDkJg8SDjZyaibImBm3yc9gUR8X5E2KqLkjkt5/p/tEN857dKJbmYOas5F+jcwPe6jvdEX74/g3ExNZ1/AXE+G//CdsTopUvwnTCthijhHWq7rMIbhy1mYmH0aS7/hrJTBQ9u0Tg3eW5Cyhbaiwlv6Dwi5feZ2iL+zgiiOBb2YkdMmO1FRY/7O3eG5DEMef5MKk0W2cz+XEpQBhSCma5BxQ0Wp8AoHcuZIHVanwnpUMj3hF13laj5m54bwwG2/p0nQPjgmJK67Q+Abmkp0hqoz4A3kBHQ7dJik+iwQtsPxntatqdzNge84oicX3QMfo9Z7BmM01BBTvDDnJkAfReyY0vsxG/BWzzNcVU2FllrT5i42r22D+GTpypb6V2RtHo9tqIUNeHK/E869VFFOfoviYmDOad3qC47l+6KcsXEH4Qnt9pNEMmtB7dNouvKM3PzOzw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 24 Apr 2024, Hyunmin Lee wrote: > If the same size kmalloc cache already exists, it should not be created > again. So there is the check for NULL kmalloc_caches before calling the > kmalloc creation function. However, new_kmalloc_cache() itself checks NULL > kmalloc_cahces before cache creation. Therefore, the NULL check is not > necessary in this function. > > Signed-off-by: Hyunmin Lee > Co-developed-by: Jeungwoo Yoo > Signed-off-by: Jeungwoo Yoo > Co-developed-by: Sangyun Kim > Signed-off-by: Sangyun Kim > Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Cc: Gwan-gyeong Mun Acked-by: David Rientjes