From: David Rientjes <rientjes@google.com>
To: Hyunmin Lee <hyunminlr@gmail.com>
Cc: linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Roman Gushchin <roman.gushchin@linux.dev>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Jeungwoo Yoo <casionwoo@gmail.com>,
Sangyun Kim <sangyun.kim@snu.ac.kr>,
Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Subject: Re: [PATCH v3 2/2] mm/slub: remove the check for NULL kmalloc_caches
Date: Fri, 26 Apr 2024 21:51:21 -0700 (PDT) [thread overview]
Message-ID: <4dae02cf-5f78-d31a-206c-19895f184b87@google.com> (raw)
In-Reply-To: <20240424140422.12780-3-hyunminlr@gmail.com>
On Wed, 24 Apr 2024, Hyunmin Lee wrote:
> If the same size kmalloc cache already exists, it should not be created
> again. So there is the check for NULL kmalloc_caches before calling the
> kmalloc creation function. However, new_kmalloc_cache() itself checks NULL
> kmalloc_cahces before cache creation. Therefore, the NULL check is not
> necessary in this function.
>
> Signed-off-by: Hyunmin Lee <hyunminlr@gmail.com>
> Co-developed-by: Jeungwoo Yoo <casionwoo@gmail.com>
> Signed-off-by: Jeungwoo Yoo <casionwoo@gmail.com>
> Co-developed-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
> Signed-off-by: Sangyun Kim <sangyun.kim@snu.ac.kr>
> Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
Acked-by: David Rientjes <rientjes@google.com>
next prev parent reply other threads:[~2024-04-27 4:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 14:04 [PATCH v3 0/2] clean-up for create_kmalloc_caches() Hyunmin Lee
2024-04-24 14:04 ` [PATCH v3 1/2] mm/slub: create kmalloc 96 and 192 caches regardless cache size order Hyunmin Lee
2024-04-24 17:04 ` Christoph Lameter (Ampere)
2024-04-27 4:51 ` David Rientjes
[not found] ` <20240424140422.12780-3-hyunminlr@gmail.com>
2024-04-24 17:05 ` [PATCH v3 2/2] mm/slub: remove the check for NULL kmalloc_caches Christoph Lameter (Ampere)
2024-04-27 4:51 ` David Rientjes [this message]
2024-05-02 14:12 ` [PATCH v3 0/2] clean-up for create_kmalloc_caches() Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4dae02cf-5f78-d31a-206c-19895f184b87@google.com \
--to=rientjes@google.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=casionwoo@gmail.com \
--cc=cl@linux.com \
--cc=gwan-gyeong.mun@intel.com \
--cc=hyunminlr@gmail.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=roman.gushchin@linux.dev \
--cc=sangyun.kim@snu.ac.kr \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox