From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB70FCF31B7 for ; Wed, 2 Oct 2024 12:09:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 51B2A6B03E3; Wed, 2 Oct 2024 08:09:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CAAE6B03E4; Wed, 2 Oct 2024 08:09:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31CE06B03E5; Wed, 2 Oct 2024 08:09:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 050346B03E3 for ; Wed, 2 Oct 2024 08:09:35 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7F3AF8033C for ; Wed, 2 Oct 2024 12:09:35 +0000 (UTC) X-FDA: 82628542710.21.CCED5D5 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf04.hostedemail.com (Postfix) with ESMTP id F3A8C40004 for ; Wed, 2 Oct 2024 12:09:32 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uCQpOEev; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="p/PrOTMG"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uCQpOEev; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="p/PrOTMG"; dmarc=none; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727870879; a=rsa-sha256; cv=none; b=ifHVfOjdh7h6PZLMtrbie2euLnDfEyfdziiBglw8KMIhf/8HZxLg16s2/iR3NxESg6wtVW jgt+ot3Snra1f7vYiYTBaMacUA6VKWEJl0l8cQ9EnkK01TPxAIn1X6tVmfYQRwcPu5waRD cm5qY46ZX/iK/tabeNtvglClbae1mB0= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uCQpOEev; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="p/PrOTMG"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=uCQpOEev; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="p/PrOTMG"; dmarc=none; spf=pass (imf04.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727870879; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eye96+7HSXT6nu/JM5zabUMkyUuxngRNpv5ElZUqX4c=; b=3Q03fqwEuxVi2Qg5MYHGfxm1Pk3NuldUj7+lFXFMe8klSU+MkMYR+PUgc82VU0pV5WzKfP fNpuO8WhJDZzC0BAthM31IeRsVa9GJpDWt4U/V2olOgcciJRk2SLCKSw96c994fpGX2F15 lzg7XPMmmUwSXofjAYXmeNi1s4YNUZg= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1D63821BAF; Wed, 2 Oct 2024 12:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727870971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eye96+7HSXT6nu/JM5zabUMkyUuxngRNpv5ElZUqX4c=; b=uCQpOEevKq7to4n31ympq/TYVAB9loUaPhDfOITUgHSLXwEmRpEuhwyxUQbpKvjW+ORUIH G3X4/3WNSO+W+udmzBXYzTyOTbR4hu8uGbksHSfYXDtJqsIjLQC1e4X5oW/QVfzeSZzWik aIQ2O6v8OCkWDP3fXpdaCOmYBYJ1q8k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727870971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eye96+7HSXT6nu/JM5zabUMkyUuxngRNpv5ElZUqX4c=; b=p/PrOTMGGm88jrN5vD7exhmAjgohcls5kA3u4CFexFt34Fe7Mynf6QEJnzBuphJ8m0CQE7 v48fuUZTEoKfeuAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1727870971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eye96+7HSXT6nu/JM5zabUMkyUuxngRNpv5ElZUqX4c=; b=uCQpOEevKq7to4n31ympq/TYVAB9loUaPhDfOITUgHSLXwEmRpEuhwyxUQbpKvjW+ORUIH G3X4/3WNSO+W+udmzBXYzTyOTbR4hu8uGbksHSfYXDtJqsIjLQC1e4X5oW/QVfzeSZzWik aIQ2O6v8OCkWDP3fXpdaCOmYBYJ1q8k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1727870971; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=eye96+7HSXT6nu/JM5zabUMkyUuxngRNpv5ElZUqX4c=; b=p/PrOTMGGm88jrN5vD7exhmAjgohcls5kA3u4CFexFt34Fe7Mynf6QEJnzBuphJ8m0CQE7 v48fuUZTEoKfeuAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 0303513974; Wed, 2 Oct 2024 12:09:31 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 4rsMAPs3/WZ6BAAAD6G6ig (envelope-from ); Wed, 02 Oct 2024 12:09:30 +0000 Message-ID: <4dadf9be-a349-4a19-ae9c-652ade9e2198@suse.cz> Date: Wed, 2 Oct 2024 14:09:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm/slab: remove duplicate check in create_cache() Content-Language: en-US To: Zhen Lei , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240821032637.1930-1-thunder.leizhen@huawei.com> From: Vlastimil Babka Autocrypt: addr=vbabka@suse.cz; keydata= xsFNBFZdmxYBEADsw/SiUSjB0dM+vSh95UkgcHjzEVBlby/Fg+g42O7LAEkCYXi/vvq31JTB KxRWDHX0R2tgpFDXHnzZcQywawu8eSq0LxzxFNYMvtB7sV1pxYwej2qx9B75qW2plBs+7+YB 87tMFA+u+L4Z5xAzIimfLD5EKC56kJ1CsXlM8S/LHcmdD9Ctkn3trYDNnat0eoAcfPIP2OZ+ 9oe9IF/R28zmh0ifLXyJQQz5ofdj4bPf8ecEW0rhcqHfTD8k4yK0xxt3xW+6Exqp9n9bydiy tcSAw/TahjW6yrA+6JhSBv1v2tIm+itQc073zjSX8OFL51qQVzRFr7H2UQG33lw2QrvHRXqD Ot7ViKam7v0Ho9wEWiQOOZlHItOOXFphWb2yq3nzrKe45oWoSgkxKb97MVsQ+q2SYjJRBBH4 8qKhphADYxkIP6yut/eaj9ImvRUZZRi0DTc8xfnvHGTjKbJzC2xpFcY0DQbZzuwsIZ8OPJCc LM4S7mT25NE5kUTG/TKQCk922vRdGVMoLA7dIQrgXnRXtyT61sg8PG4wcfOnuWf8577aXP1x 6mzw3/jh3F+oSBHb/GcLC7mvWreJifUL2gEdssGfXhGWBo6zLS3qhgtwjay0Jl+kza1lo+Cv BB2T79D4WGdDuVa4eOrQ02TxqGN7G0Biz5ZLRSFzQSQwLn8fbwARAQABzSBWbGFzdGltaWwg QmFia2EgPHZiYWJrYUBzdXNlLmN6PsLBlAQTAQoAPgIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgBYhBKlA1DSZLC6OmRA9UCJPp+fMgqZkBQJkBREIBQkRadznAAoJECJPp+fMgqZkNxIQ ALZRqwdUGzqL2aeSavbum/VF/+td+nZfuH0xeWiO2w8mG0+nPd5j9ujYeHcUP1edE7uQrjOC Gs9sm8+W1xYnbClMJTsXiAV88D2btFUdU1mCXURAL9wWZ8Jsmz5ZH2V6AUszvNezsS/VIT87 AmTtj31TLDGwdxaZTSYLwAOOOtyqafOEq+gJB30RxTRE3h3G1zpO7OM9K6ysLdAlwAGYWgJJ V4JqGsQ/lyEtxxFpUCjb5Pztp7cQxhlkil0oBYHkudiG8j1U3DG8iC6rnB4yJaLphKx57NuQ PIY0Bccg+r9gIQ4XeSK2PQhdXdy3UWBr913ZQ9AI2usid3s5vabo4iBvpJNFLgUmxFnr73SJ KsRh/2OBsg1XXF/wRQGBO9vRuJUAbnaIVcmGOUogdBVS9Sun/Sy4GNA++KtFZK95U7J417/J Hub2xV6Ehc7UGW6fIvIQmzJ3zaTEfuriU1P8ayfddrAgZb25JnOW7L1zdYL8rXiezOyYZ8Fm ZyXjzWdO0RpxcUEp6GsJr11Bc4F3aae9OZtwtLL/jxc7y6pUugB00PodgnQ6CMcfR/HjXlae h2VS3zl9+tQWHu6s1R58t5BuMS2FNA58wU/IazImc/ZQA+slDBfhRDGYlExjg19UXWe/gMcl De3P1kxYPgZdGE2eZpRLIbt+rYnqQKy8UxlszsBNBFsZNTUBCACfQfpSsWJZyi+SHoRdVyX5 J6rI7okc4+b571a7RXD5UhS9dlVRVVAtrU9ANSLqPTQKGVxHrqD39XSw8hxK61pw8p90pg4G /N3iuWEvyt+t0SxDDkClnGsDyRhlUyEWYFEoBrrCizbmahOUwqkJbNMfzj5Y7n7OIJOxNRkB IBOjPdF26dMP69BwePQao1M8Acrrex9sAHYjQGyVmReRjVEtv9iG4DoTsnIR3amKVk6si4Ea X/mrapJqSCcBUVYUFH8M7bsm4CSxier5ofy8jTEa/CfvkqpKThTMCQPNZKY7hke5qEq1CBk2 wxhX48ZrJEFf1v3NuV3OimgsF2odzieNABEBAAHCwXwEGAEKACYCGwwWIQSpQNQ0mSwujpkQ PVAiT6fnzIKmZAUCZAUSmwUJDK5EZgAKCRAiT6fnzIKmZOJGEACOKABgo9wJXsbWhGWYO7mD 8R8mUyJHqbvaz+yTLnvRwfe/VwafFfDMx5GYVYzMY9TWpA8psFTKTUIIQmx2scYsRBUwm5VI EurRWKqENcDRjyo+ol59j0FViYysjQQeobXBDDE31t5SBg++veI6tXfpco/UiKEsDswL1WAr tEAZaruo7254TyH+gydURl2wJuzo/aZ7Y7PpqaODbYv727Dvm5eX64HCyyAH0s6sOCyGF5/p eIhrOn24oBf67KtdAN3H9JoFNUVTYJc1VJU3R1JtVdgwEdr+NEciEfYl0O19VpLE/PZxP4wX PWnhf5WjdoNI1Xec+RcJ5p/pSel0jnvBX8L2cmniYnmI883NhtGZsEWj++wyKiS4NranDFlA HdDM3b4lUth1pTtABKQ1YuTvehj7EfoWD3bv9kuGZGPrAeFNiHPdOT7DaXKeHpW9homgtBxj 8aX/UkSvEGJKUEbFL9cVa5tzyialGkSiZJNkWgeHe+jEcfRT6pJZOJidSCdzvJpbdJmm+eED w9XOLH1IIWh7RURU7G1iOfEfmImFeC3cbbS73LQEFGe1urxvIH5K/7vX+FkNcr9ujwWuPE9b 1C2o4i/yZPLXIVy387EjA6GZMqvQUFuSTs/GeBcv0NjIQi8867H3uLjz+mQy63fAitsDwLmR EP+ylKVEKb0Q2A== In-Reply-To: <20240821032637.1930-1-thunder.leizhen@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Action: no action X-Rspamd-Queue-Id: F3A8C40004 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: sg3ukrn7ippui3zk8c8khrsizf4fznia X-HE-Tag: 1727870972-648009 X-HE-Meta: U2FsdGVkX18bMUArhehxavUqPsC5QtmFodss4JCfSeaxm8dTMgeD6CC853VLHcBg1hQ+F8wAcbWsSWJr4eZoxDhPYG74AhOJRdnl4666KBOgf1bCJoQSAXgyiuZUFTimxUC5A6mZw+r+5Pld1do0zSCBk8j4ekcxvCAel+RUI6DUN/sVb0k9lpRlKreCzAqdvkavz50CoKNp6O7+YtCXxCwNoWp0KMxzpdWdmVMKeyHvzIAKvU+1lYh53RNieSQqyN2H6UUHG/gKIb1OJg1iZXXftVsO0qK2YUflUAvMldwgmz99MI0DO0mLTm5mNwkLwAAeOCm5rEfQd5/ENPtjWrE4aluPPDAydBMi1s5ggLDcoUN5jGp9oApNDKzdZW0d7YDksAmmriBwVr2vuOwRZwo9hFJbS1Uktfcyb0OhJZAwYrF0Cx0kPWY0zqSrzSlgSRd9Bh0lbXhr8UWvjhLMGmNGrJTEqF3JCa/TJPT84weEB8iq6M2P66r/XkrCa7PCVWc0NMgnjLdHGFVzQ1crctLwwlHjHaXb/hU3/gKBpZQHur9LMIBuzP6rsnUBcEAx8/Dw7vFiAxZshNfgl9SxeMM9uw9A7SH7sObOXjHBPeTLtmN2ql8Tjy6HdLfFxphdCCURwvevTszXTT9+fHFft+2y00yCXPdrASapF7U5noCZBPZj/zCsj1R/nG9rtmCmUwRVDAoAd+NmsAF0HE7fKwW7Kez8n2JBEzwhnUY2KEBGEiyPofbVHQaevUbRjujSV4IGgqBmzT2cM4v9o0I41tn7NZJlJx/FL4NGWVKrqMI71HXSrqzsKTPDzcBi3p9HVHKWPyshhaMweIEafxgBPZzPeZF+bBvcMWqoHSrGMvc6tidpaciASq5wm5eCk4c2rZrcPags6T+8WOWL22eEHejmRFY5V73pHicFFHamTiJ99DgbOWNyQJvjUcl+ffwz6vDEJ64Nb9yAwQ3AB81 QtlCCRdY gk3of2DDHtwQIF+jFtiWapwZTvYSbzCp2niTRpDhlVke95au6m4AlfOvcBRyMqje1Z+D92HYD9/uJu9QTcGK/faDpbMxPEVpdKEKwsV3NUzMWeyD1RXR7GU9WjrO2F5vU4pOUiI7wiEtyLHBQIIXFo5gabx9RSM/QN+chwlrBcSGaaO0/+IVSD8WSXjIjV3z4NGmJrjw8fPoUFPapJ8v2eQ4oMMk3suLE/0PDm1CXLG8JhCgtB08y+9+SZ9beDDmQzTcMrzAXn/SlaXwZDHlhyC/eBIsIcC0V5moULjhrg+lBrYDmaHnymNSSh7xvwbLVNdHFjBMlINkULeipVR5Sf2tC8v5hXql/HheMKyIJ/MOaVsA4X9QINSJsicDVmnAOg/vz2LMf/EOE2d6WT7QvJzye2UsfOIPvSN2AScV4F1eJyTk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/21/24 05:26, Zhen Lei wrote: > The WARN_ON() check in static function create_cache() is done by its only > parent kmem_cache_create_usercopy() before calling it. > if (... > WARN_ON(size < usersize || size - usersize < useroffset)) > usersize = useroffset = 0; > ... > s = create_cache(..., size, ..., useroffset, usersize, ...); > > Therefore, the WARN_ON() check in create_cache() can be safely removed. > > Signed-off-by: Zhen Lei Hi, sorry for the late reply. This code was heavily refactored as of 6.12-rc1. Can you check if it's still the case and send updated patch? Thanks, Vlastimil > --- > mm/slab_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/slab_common.c b/mm/slab_common.c > index 40b582a014b8f2f..3069c9095523484 100644 > --- a/mm/slab_common.c > +++ b/mm/slab_common.c > @@ -210,9 +210,6 @@ static struct kmem_cache *create_cache(const char *name, > struct kmem_cache *s; > int err; > > - if (WARN_ON(useroffset + usersize > object_size)) > - useroffset = usersize = 0; > - > err = -ENOMEM; > s = kmem_cache_zalloc(kmem_cache, GFP_KERNEL); > if (!s)