From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C04C35257 for ; Fri, 2 Oct 2020 22:57:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 89D2D2074B for ; Fri, 2 Oct 2020 22:57:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89D2D2074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A5118900005; Fri, 2 Oct 2020 18:57:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A02E0900003; Fri, 2 Oct 2020 18:57:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93F4F900005; Fri, 2 Oct 2020 18:57:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0036.hostedemail.com [216.40.44.36]) by kanga.kvack.org (Postfix) with ESMTP id 68AB2900003 for ; Fri, 2 Oct 2020 18:57:53 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 061E5362D for ; Fri, 2 Oct 2020 22:57:53 +0000 (UTC) X-FDA: 77328499626.02.rose66_30104e0271a7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id E103D100D721A for ; Fri, 2 Oct 2020 22:57:52 +0000 (UTC) X-HE-Tag: rose66_30104e0271a7 X-Filterd-Recvd-Size: 4696 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Fri, 2 Oct 2020 22:57:51 +0000 (UTC) IronPort-SDR: AW7aIIzLG6odg2AKgapoMKmkh4lltKslZlHVNBujQA2cd+cvgbnhwNhNOA/fnRJtke8+BNEpyi 8qPGBmoVYXTg== X-IronPort-AV: E=McAfee;i="6000,8403,9762"; a="143086334" X-IronPort-AV: E=Sophos;i="5.77,329,1596524400"; d="scan'208";a="143086334" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 15:57:50 -0700 IronPort-SDR: ruK8toO1JApRr4j9R8fvZ1krjdTqDA1CkS3DByaCSS070zVex6WTvU5ybmxD24W982oG/OEZUI uXqNV2Jb8nhg== X-IronPort-AV: E=Sophos;i="5.77,329,1596524400"; d="scan'208";a="346604277" Received: from yyu32-mobl1.amr.corp.intel.com (HELO [10.212.143.131]) ([10.212.143.131]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Oct 2020 15:57:48 -0700 Subject: Re: [PATCH v13 19/26] mm: Re-introduce do_mmap_pgoff() To: Peter Collingbourne Cc: x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , Linux Kernel Mailing List , linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang , Pengfei Xu , Andrew Morton References: <20200925145649.5438-1-yu-cheng.yu@intel.com> <20200925145649.5438-20-yu-cheng.yu@intel.com> <00a409f0-1e2e-0bd7-83e7-f21a47878916@intel.com> From: "Yu, Yu-cheng" Message-ID: <4da742d8-983e-ff24-c74e-3c2de1590a51@intel.com> Date: Fri, 2 Oct 2020 15:57:47 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/2/2020 3:52 PM, Peter Collingbourne wrote: > On Fri, Oct 2, 2020 at 8:58 AM Yu, Yu-cheng wrote: >> >> On 10/1/2020 7:06 PM, Peter Collingbourne wrote: >>> On Fri, Sep 25, 2020 at 7:57 AM Yu-cheng Yu wrote: >>>> >>>> There was no more caller passing vm_flags to do_mmap(), and vm_flags was >>>> removed from the function's input by: >>>> >>>> commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()"). >>>> >>>> There is a new user now. Shadow stack allocation passes VM_SHSTK to >>>> do_mmap(). Re-introduce the vm_flags and do_mmap_pgoff(). >>> >>> I would prefer to change the callers to pass the additional 0 argument >>> instead of bringing the wrapper function back, but if we're going to >>> bring it back then we should fix the naming (both functions take a >>> pgoff argument, so the previous name do_mmap_pgoff() was just plain >>> confusing). >>> >>> Peter >>> >> >> Thanks for your feedback. Here is the updated patch. I will re-send >> the whole series later. >> >> Yu-cheng >> >> ====== >> >> From 6a9f1e6bcdb6e599a44d5f58cf4cebd28c4634a2 Mon Sep 17 00:00:00 2001 >> From: Yu-cheng Yu >> Date: Wed, 12 Aug 2020 14:01:58 -0700 >> Subject: [PATCH 19/26] mm: Re-introduce do_mmap_pgoff() > > The subject line of the commit message needs to be updated, but aside from that: > > Reviewed-by: Peter Collingbourne > > Peter Thanks for reviewing. I will fix the subject line. Yu-cheng