Re: [PATCH v13 19/26] mm: Re-introduce do_mmap_pgoff()

["Yu, Yu-cheng" <yu-cheng.yu@intel.com>]

On 10/2/2020 3:52 PM, Peter Collingbourne wrote:
> On Fri, Oct 2, 2020 at 8:58 AM Yu, Yu-cheng <yu-cheng.yu@intel.com> wrote:
>>
>> On 10/1/2020 7:06 PM, Peter Collingbourne wrote:
>>> On Fri, Sep 25, 2020 at 7:57 AM Yu-cheng Yu <yu-cheng.yu@intel.com> wrote:
>>>>
>>>> There was no more caller passing vm_flags to do_mmap(), and vm_flags was
>>>> removed from the function's input by:
>>>>
>>>>       commit 45e55300f114 ("mm: remove unnecessary wrapper function do_mmap_pgoff()").
>>>>
>>>> There is a new user now.  Shadow stack allocation passes VM_SHSTK to
>>>> do_mmap().  Re-introduce the vm_flags and do_mmap_pgoff().
>>>
>>> I would prefer to change the callers to pass the additional 0 argument
>>> instead of bringing the wrapper function back, but if we're going to
>>> bring it back then we should fix the naming (both functions take a
>>> pgoff argument, so the previous name do_mmap_pgoff() was just plain
>>> confusing).
>>>
>>> Peter
>>>
>>
>> Thanks for your feedback.  Here is the updated patch.  I will re-send
>> the whole series later.
>>
>> Yu-cheng
>>
>> ======
>>
>>   From 6a9f1e6bcdb6e599a44d5f58cf4cebd28c4634a2 Mon Sep 17 00:00:00 2001
>> From: Yu-cheng Yu <yu-cheng.yu@intel.com>
>> Date: Wed, 12 Aug 2020 14:01:58 -0700
>> Subject: [PATCH 19/26] mm: Re-introduce do_mmap_pgoff()
> 
> The subject line of the commit message needs to be updated, but aside from that:
> 
> Reviewed-by: Peter Collingbourne <pcc@google.com>
> 
> Peter

Thanks for reviewing.  I will fix the subject line.

Yu-cheng