From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27FF5C4828D for ; Sat, 3 Feb 2024 07:56:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 561656B006E; Sat, 3 Feb 2024 02:56:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 511B86B0071; Sat, 3 Feb 2024 02:56:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D9246B0072; Sat, 3 Feb 2024 02:56:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2A8B76B006E for ; Sat, 3 Feb 2024 02:56:17 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E20891601EE for ; Sat, 3 Feb 2024 07:56:16 +0000 (UTC) X-FDA: 81749734752.08.8AD1B0B Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by imf15.hostedemail.com (Postfix) with ESMTP id 0E06FA000C for ; Sat, 3 Feb 2024 07:56:13 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706946975; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cvDIQPgnGiNoeQGcHV8KSWYiSrZKX3a+VHCFJnRXkVI=; b=AIU4RUQ6sUmNH8vs0py8EkyCi3H/9Ytrkz2zPxV6Gd5kbknKUPE4RzTdNoW/6pgyNfn23O MrZ3Sr8ZhwNLGrxTx2WyWGMRGczavn/aTzou2vcA/Q6+pcd0gsmelS5jvKCdV2ho7v99um VVn1wdjwgvlccQgz7COiD4H/y52a+X4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf15.hostedemail.com: domain of tongtiangen@huawei.com designates 45.249.212.191 as permitted sender) smtp.mailfrom=tongtiangen@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706946975; a=rsa-sha256; cv=none; b=oteHsJ4LcxCKvGId2ff4+DCleIqm2CRmmLhZeeIeClDoKhASXY80ndunB0qO0EqSVtMfqU yHiW0CAuKriUsr/xEiqig7XVbae3BTnxpHLDXiZY+8HQlSrjBBJ6Pf8xN/2ROHUsjxEyAc 7iPlPP47ybthSULss1rjiujg2lMVVD4= Received: from mail.maildlp.com (unknown [172.19.163.44]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4TRlFy2szwz1FK0t; Sat, 3 Feb 2024 15:51:34 +0800 (CST) Received: from kwepemm600017.china.huawei.com (unknown [7.193.23.234]) by mail.maildlp.com (Postfix) with ESMTPS id 8DE5914025A; Sat, 3 Feb 2024 15:56:06 +0800 (CST) Received: from [10.174.179.234] (10.174.179.234) by kwepemm600017.china.huawei.com (7.193.23.234) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sat, 3 Feb 2024 15:56:05 +0800 Message-ID: <4d974c1e-b3a8-8b21-88f4-e5f20b2fb654@huawei.com> Date: Sat, 3 Feb 2024 15:56:04 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH -next v4 2/3] x86/mce: rename MCE_IN_KERNEL_COPYIN to MCE_IN_KERNEL_COPY_MC To: "Luck, Tony" , Borislav Petkov CC: Thomas Gleixner , Ingo Molnar , "wangkefeng.wang@huawei.com" , Dave Hansen , "x86@kernel.org" , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Andrew Morton , Naoya Horiguchi , "linux-kernel@vger.kernel.org" , "linux-edac@vger.kernel.org" , "linux-mm@kvack.org" , Guohanjun References: <20240111135548.3207437-1-tongtiangen@huawei.com> <20240111135548.3207437-3-tongtiangen@huawei.com> <20240131070258.GGZbnwov0g918F-FGz@fat_crate.local> <3009aadd-69d6-c797-20b4-95cf926b6dd9@huawei.com> <20240201142016.GFZbuooG9CRoK90U2C@fat_crate.local> <39c1e4d2-b1d0-91ae-595e-1add4698dd7f@huawei.com> <20240202133911.GBZbzwf-M37M-J3EJX@fat_crate.local> <20240202194257.GFZb1FwcPPO8WXF86H@fat_crate.local> <20240202222220.GIZb1rHG3NiZKmdRXu@fat_crate.local> From: Tong Tiangen In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.234] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To kwepemm600017.china.huawei.com (7.193.23.234) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0E06FA000C X-Stat-Signature: ko4f67ymfrd6qu7tpdmykxhmeeqt7uaq X-HE-Tag: 1706946973-614529 X-HE-Meta: U2FsdGVkX1+7jabvnzaKP5f5jZrOzLKXaIgE7sE/S+oYoxVX3RTyD0L4w5wJxrJ79Eh67Y8LjrDqjOtameKKiKKoVyA1l1Gg3f18VEpCib8XY0FlYUXuByGFkHPGoLPrO4goNFsFxF70EHbIg9TABykahxpQE5Dv+KfJ8PCu3IudyQ02KY5QqR+Bo6UiC4G612AV4Gp8nstbYFrb5zup+tGMO0oqFVYcCxW2lgJQAKEdri74HRHc/QLbgwp6VuTkTOpy6yOjyWIcsDG68rblTdOscYGwtytlT6hgnlCiGiEFTGJTHPKLDpsj1uLRtikTc+q7t+1mGIC2hgJE4qKuoQdTM2iWc+Z84866D9OXXvxupKATAk8EJXZ/g0i1NI1LRxWrzYQ8B0yp1QFEdwYu0kmqLht+sOscd41/VZpfwbsQyDO3MqsCzHeCd3WB1pQItp22PuowzrjdZmWnNNjVAUBcqt3f4nxYBA9rbQhHpDv2iArTfbhG1Fj/b3HYP7Ua/O5nwn4caL9Ud41/X8DqFi/oyNt9Pd3m4knI+7P3yoR1aCR5c9j3MGnIcMz5/IwXex2gNel7iTMGTTs+73Gdkb4hfzaavUOpzg47JF7DPKj5aNG14JCRr5EdgEBM8dC7PtZgDW7MKdxaPRUHqnA9Cms/BhC+ccEz5A93gNKr3ZADMjIbBmSj+oKUdmv5B2E2mquRxNU/WJYeqfr/Vr1dcKpMVpRyQbOsfNClAaH3Ym+QKfZ4TXtjNo8XXBwrzC1X2xNp0METe+ffmD3ej64bXmvIL/f7rj+kBPdF8VnzSe0qNe2o3F8PuINBwn4CE9ZSeJ0bkUQG8qqutD2vC+aoS4i6p4dIIwAWwF36kITH3JWpq/tMbOWSI/kDIoOwTXuvFfcmUEBV30j2XWWNOh+axF2wjOy5460EX86lT01DdGMpLOLWhcQBAI4pQsTqTQbLTjz1PtiVDW3WkqXqNf3 ccsJuMfF +j2Uv3EY5Hz6bxoXGZnYshslLkFLS/OBi1dnbUpooG/LXAaxixZX9RUQt5dVZu+h7j/ejG0oNYzrAi/4THA1V8SjuO5TcUWLFAjGtZdhT/9tUq8+x8D4xPJ1JuWiqHVu99xd0bdmc1yBlKMYuBNI3VIHr5ncCUXArsjU5BniiQ6gq/+m0KYbbnafKba2SNTcTCT3v9RkgomNYdgt16B1WUuc5dZqbVcJIONdC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2024/2/3 6:46, Luck, Tony 写道: >> Now, since you're explaining things today :) pls explain to me what this >> patchset is all about? You having reviewed patch 3 and all? >> >> Why is this pattern: >> >> if (copy_mc_user_highpage(dst, src, addr, vma)) { >> memory_failure_queue(page_to_pfn(src), 0); >> >> not good anymore? >> >> Or is the goal here to poison straight from the #MC handler and not >> waste time and potentially get another #MC while memory_failure_queue() >> on the source address is done? >> >> Or something completely different? > > See the comment above memory_failure_queue() > > * The function is primarily of use for corruptions that > * happen outside the current execution context (e.g. when > * detected by a background scrubber) > > In the copy_mc_user_highpage() case the fault happens in > the current execution context. So scheduling someone else > to handle it at some future point is risky. Just deal with it > right away. > > -Tony The goal of this patch: When #MC is triggered by copy_mc_user_highpage(), #MC is directly processed in the synchronously triggered do_machine_check() -> kill_me_never() -> memory_failure(). And the current handling is to call memory_failure_queue() -> schedule_work_on() in the execution context, I think that's what "scheduling someone else to handle it at some future point is risky." Thanks. Tong.