From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C46ABE95A91 for ; Mon, 9 Oct 2023 15:45:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5893F8D007B; Mon, 9 Oct 2023 11:45:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 511A18D0031; Mon, 9 Oct 2023 11:45:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B2198D007B; Mon, 9 Oct 2023 11:45:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 294608D0031 for ; Mon, 9 Oct 2023 11:45:31 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id EC9DD4030F for ; Mon, 9 Oct 2023 15:45:30 +0000 (UTC) X-FDA: 81326347620.01.DCCF616 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf22.hostedemail.com (Postfix) with ESMTP id D122FC0038 for ; Mon, 9 Oct 2023 15:45:28 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0gfvqNDX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eDy8sKhu; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1696866329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S82M4cXdk8Z0xWHX6NNe1YRF/yKvOMhviS3adL1UiMk=; b=1XQf5/h+12+TeY9NcJl25a5rjoog16YxppkvY+cRdNLVUj2ZnrvlIs1xHtzT0q54brNqjy 7JLS3D8iUAzBQVDrAQWqltFsexhq7YsiDh3XpJGQLV5f/cU1Jw6AXnGgq/wvSdia7GOdW7 xfaAmI7J7Wqti8LhTuO2/mdn2pzRayU= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=0gfvqNDX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=eDy8sKhu; dmarc=none; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1696866329; a=rsa-sha256; cv=none; b=TvdqQBCCK6M9WH9+4pDqcoBFneA1viJkU1mpw0wCBWaFHKNEiuol+D51UXf/I7qfgUyNFh CnG7r5uKrTapzvVXPxijKxxCBICDBjhK6YSwxa0T4VSxb/eNH8se9pjn8/5X4awD9jyKSA /0h6CykEHlTGfd4kssVjyp9LopVBLW0= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 42D6F1F390; Mon, 9 Oct 2023 15:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1696866327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S82M4cXdk8Z0xWHX6NNe1YRF/yKvOMhviS3adL1UiMk=; b=0gfvqNDXpK5UNQw8epyNmfhAc6nESfxfl/NBut2G+ocnDdgeZ4ydY/ObcgbYCybrQQTDRs 2HfszLMcgJfRNI/SMpJkIRDv3dJfgHFYDqvYwJrOnmpQVdW9i8VBFpzIB0V/VQ82J6NEG/ fUegQRvsEPqqCricbAZbAJVO7CogauY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1696866327; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S82M4cXdk8Z0xWHX6NNe1YRF/yKvOMhviS3adL1UiMk=; b=eDy8sKhuhDyZATH5ozLnx3F6ah3AffkV+8FP/sQ6V6bbtzURdiUWpA3F69RWzkkeVYFCAQ 7IRUvssb90feKwCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 21F6613586; Mon, 9 Oct 2023 15:45:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id pPqJBxcgJGU3OgAAMHmgww (envelope-from ); Mon, 09 Oct 2023 15:45:27 +0000 Message-ID: <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz> Date: Mon, 9 Oct 2023 17:45:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 2/4] mm: make vma_merge() and split_vma() internal Content-Language: en-US To: Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Alexander Viro , Christian Brauner Cc: "=Liam R . Howlett" , linux-fsdevel@vger.kernel.org References: <6237f46d751d5dca385242a92c09169ad4d277ee.1696795837.git.lstoakes@gmail.com> From: Vlastimil Babka In-Reply-To: <6237f46d751d5dca385242a92c09169ad4d277ee.1696795837.git.lstoakes@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D122FC0038 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: pyg7wy4ozuzht4baaihytnym74xjemrm X-HE-Tag: 1696866328-858411 X-HE-Meta: U2FsdGVkX1+29wp/jAbqzqhlHHKJGnTO6lRa7i1KVlVio9u8vlMxxMpdEQwOEvzWKq1vK7+BMcmdgWft+gUCwG8pPvC3056YVnu3107j+drTod20Ek86OffI+/aSKR9/denJ3JFrMiRWcEvkXm0NQvFLZuqeCPElbkVkPf2+f0xpMrpaHa0Qy8c3+vGZhxZ8tQXet2nCbnB6hE+o6ku/7h2xHMLia6van1r/thQw9P+7aNtulVdwGKowDgbftb6Z30O183HnlUQqttnwro6j0vqHeqhho7QJnLOIVuOsvyw3xuFGlMYJ5iAko7yp99v+OY1j6C7JCgMGFUWjlnFbDhNW6/dPle0nxs3TihHL3qH/XbWXz4pkFDfKYItSUWRir3F9LblcNej5vGluoloIdCM9Z5xLxigYzhNPQ1Qc2KFrINUxQTxFv15ZR31+y5APH9pQGowkRYFfwWkZklSvwNrgjJA/iUFtMATCIcd0Qz0Hy1QCrJNy0uivxjpW7Xu6nM/e/vPKEq8vaZuwdml4QN0ty7p6VKaNqwf4T7JrWYai5KAqzgQMvOla13DuJ5s9LVRAzTnlMZHQ/GO+BgpB8gu7RihSoJzhWCKP0WCv6WL+nG+OSVn+7sX9D6/ELdiPAVvW/SHCx2sbbfMHFJ/9RC5Guklq/ZSzj81yL4Ai8YiFbK/BT6KtX6AOFavfNZ8gYD0tdOBfon/82Hg3acYF5Tbd39jqZ6uQwRnB98EUDJjcRRahW8oWQj239O4jVnu8PfPXogDQoGNx8U9XYeCnFbX1NcJUV5Zt1GCPqS2fGVAGcf+iUWrm/TWr6uxrEaoKZ48oDORB2utsuDhSg4iV5RCVypE/hLnqmVm8aq0kUL2zEKvwnKtW0PE8hWwZIt3M8yJvKHEI7c6U1TBNPFwExkJfuQAz+m5WpwiytC22k0mkUUJsU3KhKbCCl6Y0ce5hjxvbvHjXLchVt2zsT+S wIx3V98P LrE6wBmTOsjXSEZY4fUbFd/RvdlJVH23rS1/hc+ahROanUhLczqIXYVELG8tcWb/qnqaAAM1hCw4o1JtuO5vwySWgwgtdMuMdpAnm5mrZC87SmBbojSX4+fNQFLRE6GME6D0ERgpxoy3nprCcf6+6mnprVYln9OUFioBUwsx1cnY0VuYV8loemT4GWaSiq/uN/3IJuSoAGL2VLz588eByj6lg2r9B/o9pJ1xzUUNuoQeXAbwA2jnOU5F+le1ZF7TaYznp9AUsUtGqSgg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10/8/23 22:23, Lorenzo Stoakes wrote: > Now the vma_merge()/split_vma() pattern has been abstracted, we use it "it" refers to split_vma() only so "the latter" or "split_vma()"? > entirely internally within mm/mmap.c, so make the function static. We also > no longer need vma_merge() anywhere else except mm/mremap.c, so make it > internal. > > In addition, the split_vma() nommu variant also need not be exported. > > Signed-off-by: Lorenzo Stoakes Reviewed-by: Vlastimil Babka