linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Vlastimil Babka <vbabka@suse.cz>
To: Lorenzo Stoakes <lstoakes@gmail.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>
Cc: "=Liam R . Howlett" <Liam.Howlett@oracle.com>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] mm: make vma_merge() and split_vma() internal
Date: Mon, 9 Oct 2023 17:45:26 +0200	[thread overview]
Message-ID: <4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz> (raw)
In-Reply-To: <6237f46d751d5dca385242a92c09169ad4d277ee.1696795837.git.lstoakes@gmail.com>

On 10/8/23 22:23, Lorenzo Stoakes wrote:
> Now the vma_merge()/split_vma() pattern has been abstracted, we use it

"it" refers to split_vma() only so "the latter" or "split_vma()"?

> entirely internally within mm/mmap.c, so make the function static. We also
> no longer need vma_merge() anywhere else except mm/mremap.c, so make it
> internal.
> 
> In addition, the split_vma() nommu variant also need not be exported.
> 
> Signed-off-by: Lorenzo Stoakes <lstoakes@gmail.com>

Reviewed-by: Vlastimil Babka <vbabka@suse.cz>



  reply	other threads:[~2023-10-09 15:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-08 20:23 [PATCH 0/4] Abstract vma_merge() and split_vma() Lorenzo Stoakes
2023-10-08 20:23 ` [PATCH 1/4] mm: abstract the vma_merge()/split_vma() pattern for mprotect() et al Lorenzo Stoakes
2023-10-09 15:22   ` Vlastimil Babka
2023-10-09 18:19     ` Lorenzo Stoakes
2023-10-08 20:23 ` [PATCH 2/4] mm: make vma_merge() and split_vma() internal Lorenzo Stoakes
2023-10-09 15:45   ` Vlastimil Babka [this message]
2023-10-09 18:20     ` Lorenzo Stoakes
2023-10-08 20:23 ` [PATCH 3/4] mm: abstract merge for new VMAs into vma_merge_new_vma() Lorenzo Stoakes
2023-10-09 16:04   ` Vlastimil Babka
2023-10-09 18:21     ` Lorenzo Stoakes
2023-10-08 20:23 ` [PATCH 4/4] mm: abstract VMA extension and merge into vma_merge_extend() helper Lorenzo Stoakes
2023-10-09 16:30   ` Vlastimil Babka
2023-10-09 18:22     ` Lorenzo Stoakes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4d8968e8-a103-8320-fce6-d2a78fbf05ba@suse.cz \
    --to=vbabka@suse.cz \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lstoakes@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox