From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 069BDC433FE for ; Sat, 19 Nov 2022 00:48:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92CC56B0072; Fri, 18 Nov 2022 19:48:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B5C26B0073; Fri, 18 Nov 2022 19:48:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 755FB6B0074; Fri, 18 Nov 2022 19:48:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 62D5E6B0072 for ; Fri, 18 Nov 2022 19:48:45 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 413F61C6022 for ; Sat, 19 Nov 2022 00:48:45 +0000 (UTC) X-FDA: 80148356610.04.DE1869B Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by imf04.hostedemail.com (Postfix) with ESMTP id 22C9940003 for ; Sat, 19 Nov 2022 00:48:43 +0000 (UTC) Received: by mail-pj1-f43.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso6548983pjc.5 for ; Fri, 18 Nov 2022 16:48:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eSj2/cLHt1SdQObKh67xzbIPuUwvEskces+Lnu0fKrQ=; b=Lod+RJl5ay4LW7CCVlbLVUpVW9yWRmjZS7z4BgLn9FMTNVOMqDo575AiTzf60tmQ7k 1EX58Lueuy4m/3mWqyE+pMkUTKz3s5nj2gQwc6eVlmACBwow8YCLU/nsCqdAbZ8d2mIK jF8QPdH+gSoH53sUSzO25R7eb3xC3lTEbIKviDGAW6J5r4ssCLHrEnQrkU0TlZ3k6wGV REZwacxFiMi7qyROKMRk4RwZ1VzfdsgggKrDrjMzNMbleR1EmdEEgi+6NPSbBWYoSvOn fk3RDude0PcKMooAKfQAuDS/qWB0tlSvfrhCSCJDGUtP3TuZOSvPVzb1db/bRzJ8/bjK p/SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eSj2/cLHt1SdQObKh67xzbIPuUwvEskces+Lnu0fKrQ=; b=eGmd7D+JnRPfxm1TZlZt1cEieIUDf2/CsytCoZ7gPSiPYegHgkfClIPcEnBYpwO1Np 0wosfvVqcTXTX8V4m1BGobQi0w09Ja/rpr4fS0yF2uDNQWAJSA9cnzeqCIqbJ4mRG4Uq O72IukUnLt9BXlD9DT7qg7/3d0GdGNGURAL2+dOHQW5mOktWYr0W68JHbXREhrQTt6E4 ixgPEIKy6tKHtMdYwYq7HqInqxs8Vqts9c9ZG0N11BynnGjyyrbnQtBbunoMX+pOjs6g E7TvjyR7mu7GbDMq8VJTC9vPOTHETnjkPKFBAFgZiyNhg257g3ofn/LdCQrrCkLhj5fJ bVZQ== X-Gm-Message-State: ANoB5pm8jYLCJLF3FnSjnMyzYedhk2bYFudBCrxspvr/yxTrAALr5Qpk YqeD+bm/N+Sh0Tf/OpnDZo8Leg== X-Google-Smtp-Source: AA0mqf6swX3sJxyi4BgEUBAbZm2DOjd6hNV4fVJPFohM84Xw+4s8Nshz7t9X6MP8fLm+8fDHRp4zcA== X-Received: by 2002:a17:902:f391:b0:178:71f9:b8fc with SMTP id f17-20020a170902f39100b0017871f9b8fcmr2021518ple.44.1668818922973; Fri, 18 Nov 2022 16:48:42 -0800 (PST) Received: from [10.255.94.72] ([139.177.225.224]) by smtp.gmail.com with ESMTPSA id e8-20020a630f08000000b0046faefad8a1sm3382499pgl.79.2022.11.18.16.48.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 16:48:42 -0800 (PST) Message-ID: <4d6eb453-2ba5-12f3-8dff-7074a62441ce@bytedance.com> Date: Sat, 19 Nov 2022 08:48:36 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v3] mm: fix unexpected changes to {failslab|fail_page_alloc}.attr Content-Language: en-US To: Andrew Morton Cc: akinobu.mita@gmail.com, dvyukov@google.com, jgg@nvidia.com, willy@infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, stable@vger.kernel.org References: <20221118100011.2634-1-zhengqi.arch@bytedance.com> <20221118134236.17a67804b3b6e6c157d8ea02@linux-foundation.org> From: Qi Zheng In-Reply-To: <20221118134236.17a67804b3b6e6c157d8ea02@linux-foundation.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668818924; a=rsa-sha256; cv=none; b=H7UfTGpMYgtrCOy9vS6k2h7bAMUUNtnh5FVlQO96JSv2AOZvD2tEg2ayQe5XIiRmK9bF3B 376lWnG+8Ugl2Y4DQPRbBYCpFVv4B7hB2NFhpsekk6o4yX0uK5DWKODUxQK1Qekzu/MDai T9Oz0rn3mEWLRMjijFHEop5AjGJoVRw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Lod+RJl5; spf=pass (imf04.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668818924; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eSj2/cLHt1SdQObKh67xzbIPuUwvEskces+Lnu0fKrQ=; b=LSF+GO7iMYrUpO5QT0unVWmQfJG99MqCA1oJ01TbP13lj0uvabCyjnBq0e2y6ssE6G5Y6B Q/voMXXhqkOX1sorjc+ZIsLufKnmYrHiYD0i65ZfQgA17ilAvkwxp6TyKsceSv8dIYxQNQ yflZJ2y5Ro92/o0bGOYJNT+kvG9zzro= Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=Lod+RJl5; spf=pass (imf04.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.216.43 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 22C9940003 X-Rspam-User: X-Stat-Signature: uq1j654xu91fcaok6rn79q8ugr5mxb63 X-HE-Tag: 1668818923-887495 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/11/19 05:42, Andrew Morton wrote: > On Fri, 18 Nov 2022 18:00:11 +0800 Qi Zheng wrote: > >> When we specify __GFP_NOWARN, we only expect that no warnings >> will be issued for current caller. But in the __should_failslab() >> and __should_fail_alloc_page(), the local GFP flags alter the >> global {failslab|fail_page_alloc}.attr, which is persistent and >> shared by all tasks. This is not what we expected, let's fix it. >> >> Cc: stable@vger.kernel.org >> Fixes: 3f913fc5f974 ("mm: fix missing handler for __GFP_NOWARN") >> Reported-by: Dmitry Vyukov >> Signed-off-by: Qi Zheng >> Reviewed-by: Akinobu Mita >> >> ... >> >> -bool should_fail(struct fault_attr *attr, ssize_t size) >> +bool should_fail_ex(struct fault_attr *attr, ssize_t size, int flags) >> { >> bool stack_checked = false; >> >> @@ -152,13 +149,20 @@ bool should_fail(struct fault_attr *attr, ssize_t size) >> return false; >> >> fail: >> - fail_dump(attr); >> + if (!(flags & FAULT_NOWARN)) >> + fail_dump(attr); >> >> if (atomic_read(&attr->times) != -1) >> atomic_dec_not_zero(&attr->times); >> >> return true; >> } >> +EXPORT_SYMBOL_GPL(should_fail_ex); > > I don't see a need to export this? Yes, my initial thought was that there might be a driver using this function, but there really isn't one yet. And I see you've helped remove this, thanks a lot. :) > > -- Thanks, Qi