From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819DFC36010 for ; Tue, 1 Apr 2025 16:36:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 07FEB280002; Tue, 1 Apr 2025 12:36:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02D55280001; Tue, 1 Apr 2025 12:36:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEA48280002; Tue, 1 Apr 2025 12:36:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C1D91280001 for ; Tue, 1 Apr 2025 12:36:38 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 501B612026D for ; Tue, 1 Apr 2025 16:36:40 +0000 (UTC) X-FDA: 83286028560.07.42EEE1A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id D94CE1C0008 for ; Tue, 1 Apr 2025 16:36:37 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JjZijXe3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1743525398; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jPlBVfdRwHRCfRmLllFKmMklMBiXVd50l/1Zb4TZD0A=; b=13APQvrTYqdAqfiulsniQ4dRtRBXiOlOnUjKlE3cHgds39fyMlP0mG8VfBGALovOqL5B7N etDRijkwg2A63WScPHQlbrwIRkyv8dHqGrvmyV/4Bg6bGV0IpCEBVpxEAd2AKNoYkICLEH FBJYkQ2kXYzWOJdzKHPCq24Jaw7wAQM= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JjZijXe3; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf20.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1743525398; a=rsa-sha256; cv=none; b=rN91CrkTbOZblf4q/LWI4UytFycDNv6sMHuaYCkaGJwT1bK9e2/kgmzVReKqskXMf5viho YU+YOfN1iwoVaW6jC1TpUohaJOzmwdkLzuqB9hO3X08DOz/voWez3Rni9N6tobymKFRXvi BXljyfDmso3k6PNiJY+ZuMOjAsBJg6M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1743525397; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=jPlBVfdRwHRCfRmLllFKmMklMBiXVd50l/1Zb4TZD0A=; b=JjZijXe3UWEVO9k0dMcABTbwXSCruwj1ghNBmMKGkWfF23NqipScdcO6gpct7dtNuNNkWS ztG8tH7LNgyhN0d6u1hTT5A4aPceJxo3AclRYK64K7dr6uoOCKBj5m60NzWXrbbC8fDEai 7Z2eplrezFbFIG+7JeZpISenLizZLQs= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-503-DgwM-n2TPturj2NLBEktFw-1; Tue, 01 Apr 2025 12:36:36 -0400 X-MC-Unique: DgwM-n2TPturj2NLBEktFw-1 X-Mimecast-MFC-AGG-ID: DgwM-n2TPturj2NLBEktFw_1743525395 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-39c1b1c0969so1880334f8f.1 for ; Tue, 01 Apr 2025 09:36:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743525395; x=1744130195; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=jPlBVfdRwHRCfRmLllFKmMklMBiXVd50l/1Zb4TZD0A=; b=QW4eO/rbO9k06J29WCPFdE9PIyoJDtcoaQpbC5uhP4u4sr72l1hatSAXhpuH/98PUo OV/nFXeiFWx9hSP1TnxgHMNg7lKf7PA6pXcnS/eO8WfVdY4uU8GQDuTFEU3tPk3GT7wb 2I0EQ2ns2JW2OSBvD6XZrhCet8ADnC/GX6IAtd4RBr+CSb4w+huE12zPQx2wFhyR3zlc gS6yo6geunkucketuslYi7RogUJbQ53t/e6VdNnT0QV0LNi7os1Kwz5cjSUMH0PKHkzO hPr9kPeQ4VcHGFLb2ybE6irVVCEzszNKxyWfCUU58z9boyOP+oP98Dn2YtntNQCkIyfn HVYA== X-Gm-Message-State: AOJu0Yx//D3RfzgWcI5Uu1uLFKeXKEi00iNOZTcrLWXeJrxC4cWR7BQe Ka2ypjsm1tVEV1tVG1twoMCkd5P5JzgxMiTGp6vjVEJZ1zePAnZtJFgKpC0G0Crr73qDB1sTUeW 1P68ziX7VBMaxZOF6tIwPDZKz5zkps7vVo07mTk4+6BrTESV2 X-Gm-Gg: ASbGncumTwWUkCZPaIxTqC2HYalr+RGa5ioNI9g2dkV1iRG2aOsWTjwaxXgv59aLuej YqLNxFTROCRXFt6gQ4oyAmS19nVQ/1F9u3pxsv0wclPEF4oiiVIiQHCNryZxlp/JY2c7hQqz7Qr 9/f1wNzWGVwd4nx3os3N+HXVKrD1CcgafeeyBr3bLoPASbSgaLCwagG+o3qKrFiHG7PNuEJKulw EQSSVySwPDGzLaZZkJMJGZQ2aM/iMbzeYbMI8aOUrDide0nXE7VZJAqWIdf9LSgbZvr9kD963zA D+FBezzgnaxhrNg1LEEPQ6SdJdhffQKcgWB/85tlttbwlxPJFyKeWHf5U7F1QTWP17dl4pgsbWs mr3pD+HjRL+8FdnpvZxNJpW2prz1J01KkNIBMUS+C X-Received: by 2002:a5d:6d8b:0:b0:391:3049:d58d with SMTP id ffacd0b85a97d-39c1208ebcbmr11140889f8f.0.1743525394901; Tue, 01 Apr 2025 09:36:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGL7vQGxP7qLoErUH43NGW32Af9+4bNHTTTVRE7Aho+BDkuwr4jeR41tih/UMzZweBHFD6Apg== X-Received: by 2002:a5d:6d8b:0:b0:391:3049:d58d with SMTP id ffacd0b85a97d-39c1208ebcbmr11140870f8f.0.1743525394499; Tue, 01 Apr 2025 09:36:34 -0700 (PDT) Received: from ?IPV6:2003:cb:c707:4d00:6ac5:30d:1611:918f? (p200300cbc7074d006ac5030d1611918f.dip0.t-ipconnect.de. [2003:cb:c707:4d00:6ac5:30d:1611:918f]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43d8835e627sm191048725e9.29.2025.04.01.09.36.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Apr 2025 09:36:33 -0700 (PDT) Message-ID: <4d5bac6d-ae77-473f-95d8-cb397005822c@redhat.com> Date: Tue, 1 Apr 2025 18:36:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] mm/vmscan: don't try to reclaim hwpoison folio To: Jinjiang Tu , akpm@linux-foundation.org, linmiaohe@huawei.com, nao.horiguchi@gmail.com Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com References: <20250318083939.987651-1-tujinjiang@huawei.com> <20250318083939.987651-3-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250318083939.987651-3-tujinjiang@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: pug7EKUEpH7OeTfHxSgFdr_sasGjrMlnuwDmY7TAvb4_1743525395 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Stat-Signature: big8euriidnj5moiaudwqjnigbaguf65 X-Rspam-User: X-Rspamd-Queue-Id: D94CE1C0008 X-HE-Tag: 1743525397-439442 X-HE-Meta: U2FsdGVkX1/voW3KOYnauYp+9TjBBSmaYAACs/aeFWmF4A+poSoFg2nQQb2yrNdNIaQRegjN2ocOey7bY25ThoaznXSwXahy51rcYwh2t9kHDThwsa2HUfML849PiRfDEL9SR5MUdVioIO+tlEsH3hTi1SiWWeqWe1yQhYoo1y/Q7g3/cbEA7Thk4fERpVJG4E1mLBz4WjiMRD3i3VS++5gbQw+4ov4PHiBMCtafd/uXrw5v8eFSqi0W9dOZ5uuk3ZWinN/sQx7CafKv+FAMN+VlNf+m4nK0qN33PjCGaBcrmco/i5mpfRL6NLzN/I5qkw0WXexoC9F9sGeokSDKxq2J1z0DO/3Xp124KSsLy6l2xLwfVgGyD2nU1Qta/ZKRp1+uDUw6GMraxFDny1W61uEcTaP/HjxY6LepjD1jESI+27eMIjP4CIfkAYtfBCnAb0hxpLmq6XRt/vWQkxhjXcjbqYj7KspSIiOtKmhwyHSxFJzIgN2VHYYqgbpJFCZz/N6sAfgc7JuhftxHSjFyKFtdtrtZN1DEN8UsyUGIf2OMqvCP8fYXyLPJ/568dqK0zrhcVLAmLq/Z+DDxopFCsFivLu9GCruWtTLXgiAimhtwiGKSU5X5m/6bJNn8Sm1QxfEAvBt6gERFswCNwamUXXGsLuZJ/MH576dfutfeDz0diD0eH03yGi17G9Ov+TtSSAUyWBKHre9I3X9C35aIPeG8TYYQp94zz0G2FZyyJQp1OTbfJJphZpskzAYwqe9B84vGwwuiOTiupxe3LmWMr1VdikNZSGZNekCBmEjaiKcXFSSYy+6WCNioNrwnwsE+c6t7qPil2sBguUZqtdHbOkvTZLed1q4TlHbPHwCl+M2KYXUv/H/ND3GYIjkr9S/isdFQ2FXKZ7I4JeWTX/EWkT5OsY344CkQ0CtWHOjOVQlVOfBvsORcIrzXTHUYqQpeRmIecb+0i+l1gFC3drZ 6iAVoIV/ miw/z/bkI7dkI9XXVjUS7wrWlzdDScYBAGNbvCanNGNTUioeLAP+TQf1qtoKeNvffYMQpWPF/sigJpAIsjI09Awd7oar6iC1+CBpUyYd4IQ0NCUIBdQrUYz+Z2isKeKgBmVrGN20FEeALPLCDSmOdQ6NjE5W/o8+Q876PSs27uvfNge7fyLBYHuxjijYdnhLq1GwGJ/gMZE6HGZrU+fKV8lLJw2E0wu85wbY8UxWqcT1gPQtlCoxawCoAbz8H04nxcB8tyue5wRvQJuNUOZVz6G8OvAqCWFVFjfJ8FDaR0UcSNZeIiDL4Stzlqkf3fOYSc+Wy6A5ntum92YM6YljV5q5eS6rNQwCoaBEbmuG+RPMFYvshrfpUMxVffwqRNvEhvQMFadfEVtot1CW65seoMlVBQNZTePUoIQdvR8bO0FhAEOpUewGg0vleKrbjuKAPXyYSRPumBwJWAqCqiKCHvRF2hnyrMpYx+stfC6GvwAmvFhUPIolA+oDlxu3MzVAhbYHx3c7DvMdTJnw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 18.03.25 09:39, Jinjiang Tu wrote: > Syzkaller reports a bug as follows: > > Injecting memory failure for pfn 0x18b00e at process virtual address 0x20ffd000 > Memory failure: 0x18b00e: dirty swapcache page still referenced by 2 users > Memory failure: 0x18b00e: recovery action for dirty swapcache page: Failed > page: refcount:2 mapcount:0 mapping:0000000000000000 index:0x20ffd pfn:0x18b00e > memcg:ffff0000dd6d9000 > anon flags: 0x5ffffe00482011(locked|dirty|arch_1|swapbacked|hwpoison|node=0|zone=2|lastcpupid=0xfffff) > raw: 005ffffe00482011 dead000000000100 dead000000000122 ffff0000e232a7c9 > raw: 0000000000020ffd 0000000000000000 00000002ffffffff ffff0000dd6d9000 > page dumped because: VM_BUG_ON_FOLIO(!folio_test_uptodate(folio)) > ------------[ cut here ]------------ > kernel BUG at mm/swap_state.c:184! > Internal error: Oops - BUG: 00000000f2000800 [#1] SMP > Modules linked in: > CPU: 0 PID: 60 Comm: kswapd0 Not tainted 6.6.0-gcb097e7de84e #3 > Hardware name: linux,dummy-virt (DT) > pstate: 80400005 (Nzcv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) > pc : add_to_swap+0xbc/0x158 > lr : add_to_swap+0xbc/0x158 > sp : ffff800087f37340 > x29: ffff800087f37340 x28: fffffc00052c0380 x27: ffff800087f37780 > x26: ffff800087f37490 x25: ffff800087f37c78 x24: ffff800087f377a0 > x23: ffff800087f37c50 x22: 0000000000000000 x21: fffffc00052c03b4 > x20: 0000000000000000 x19: fffffc00052c0380 x18: 0000000000000000 > x17: 296f696c6f662865 x16: 7461646f7470755f x15: 747365745f6f696c > x14: 6f6621284f494c4f x13: 0000000000000001 x12: ffff600036d8b97b > x11: 1fffe00036d8b97a x10: ffff600036d8b97a x9 : dfff800000000000 > x8 : 00009fffc9274686 x7 : ffff0001b6c5cbd3 x6 : 0000000000000001 > x5 : ffff0000c25896c0 x4 : 0000000000000000 x3 : 0000000000000000 > x2 : 0000000000000000 x1 : ffff0000c25896c0 x0 : 0000000000000000 > Call trace: > add_to_swap+0xbc/0x158 > shrink_folio_list+0x12ac/0x2648 > shrink_inactive_list+0x318/0x948 > shrink_lruvec+0x450/0x720 > shrink_node_memcgs+0x280/0x4a8 > shrink_node+0x128/0x978 > balance_pgdat+0x4f0/0xb20 > kswapd+0x228/0x438 > kthread+0x214/0x230 > ret_from_fork+0x10/0x20 > > I can reproduce this issue with the following steps: > 1) When a dirty swapcache page is isolated by reclaim process and the page > isn't locked, inject memory failure for the page. me_swapcache_dirty() > clears uptodate flag and tries to delete from lru, but fails. Reclaim > process will put the hwpoisoned page back to lru. > 2) The process that maps the hwpoisoned page exits, the page is deleted > the page will never be freed and will be in the lru forever. > 3) If we trigger a reclaim again and tries to reclaim the page, > add_to_swap() will trigger VM_BUG_ON_FOLIO due to the uptodate flag is > cleared. > > To fix it, skip the hwpoisoned page in shrink_folio_list(). Besides, the > hwpoison folio may not be unmapped by hwpoison_user_mappings() yet, unmap > it in shrink_folio_list(), otherwise the folio will fail to be unmaped > by hwpoison_user_mappings() since the folio isn't in lru list. > > Signed-off-by: Jinjiang Tu > --- > mm/vmscan.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/mm/vmscan.c b/mm/vmscan.c > index 2d73d497bdd5..ca3757b137d9 100644 > --- a/mm/vmscan.c > +++ b/mm/vmscan.c > @@ -1112,6 +1112,13 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, > if (!folio_trylock(folio)) > goto keep; > > + if (folio_contain_hwpoisoned_page(folio)) { > + unmap_poisoned_folio(folio, folio_pfn(folio), false); > + folio_unlock(folio); > + folio_put(folio); > + continue; > + } > + I was briefly concerned about large folios (if only a single page is bad, why unmap all of them?), but memory_failure() will already kill_procs_now() in case splitting the large folio failed. So we should rarely run into large folios here. Acked-by: David Hildenbrand -- Cheers, David / dhildenb