From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB14DC04A95 for ; Wed, 28 Sep 2022 20:27:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 003816B0073; Wed, 28 Sep 2022 16:27:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF5B96B0074; Wed, 28 Sep 2022 16:27:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBC9E6B0075; Wed, 28 Sep 2022 16:27:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CC7AC6B0073 for ; Wed, 28 Sep 2022 16:27:37 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8BDEC120A01 for ; Wed, 28 Sep 2022 20:27:37 +0000 (UTC) X-FDA: 79962629754.23.4264F82 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf03.hostedemail.com (Postfix) with ESMTP id 1D1F02000D for ; Wed, 28 Sep 2022 20:27:36 +0000 (UTC) Received: by mail-qk1-f181.google.com with SMTP id k12so8606935qkj.8 for ; Wed, 28 Sep 2022 13:27:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date; bh=8adqXN45JE2olLRk9Lphi2ZcgXsJm6thwoQKvNld65w=; b=NvoTO3K9YrwXsLuTr2K12Ojxt9FpL5LnrKKiOfYp9TI6tY4cZY5t5vLFCVgVPstbze 84Q4132pi0ULC9SvyAd0De6GOmP05juLUI5WA7LHFIYulacEHzfLmeMVWdjPgSzQ1UdO 5kclja6Qs4+st95fOlpPShcdo9fKUBCPiFtFCGVSZdZVuSUmX7oILm0F3RlJ75xSGYDt 7Fkkt9/z8zbxou4qLjiN1s/2WuqrWGPN6xP6BT0lTfm0TXs7nmhmi8yWygfHVesMSgU1 6TuMpRK8MmO6OQmIinD6M4M1ETGBGII3restta5gy4u8/cBEyXDs7iVDkOhTYQ2FlCZb +Aag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date; bh=8adqXN45JE2olLRk9Lphi2ZcgXsJm6thwoQKvNld65w=; b=jSBZd8BYcLZVRonHeEXTHRNTvLBX14qMA9xvyAbYqEUXf4zwc8Rnmt0SftiIPKIsqt 57dlZTWvMERBg17BnaxbMWodGVT3xySknwWJBN0oT+kbmetz733cUZIeTlwHG7busCha dOEvw3whBb4d16nvzjxzkAirscpMoAVsrHIt4XI9kxyYK/edGybKA4qgXyvEjRSGp+qs Yd1hGEq/LLTZJ/MDSaIbRHFagmlCGoucx5p9hJcRHnuSkt0rUhLOfjW52ab4uTBzL8k3 qsiAnoZTfhosaNWIP687A79X4ZGEBW/qHUCTPtoFZ6i0ONonQd5l+wjXbrEXvYY0V6Jk DSIw== X-Gm-Message-State: ACrzQf3UlEJI/xe1Pu2bDmZnzezBAiKvntA4eqZMByr+pmI1MkEMS4Uj s95gLiI7aQ/dxmeZoPv4vkTw2Q== X-Google-Smtp-Source: AMsMyM5ldKk195h1RT9CHCFvAwC2cFlQaqd/R0NvvDz82ndpFuvN3S4A5bvupjoHEvYyrQllgCt6gg== X-Received: by 2002:a37:40e:0:b0:6cb:be14:1818 with SMTP id 14-20020a37040e000000b006cbbe141818mr22922511qke.284.1664396856242; Wed, 28 Sep 2022 13:27:36 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id v17-20020a05620a441100b006cbdc9f178esm4313961qkp.25.2022.09.28.13.27.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Sep 2022 13:27:35 -0700 (PDT) Date: Wed, 28 Sep 2022 13:27:20 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: =?ISO-8859-15?Q?Thomas_Wei=DFschuh?= cc: Hugh Dickins , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, =?ISO-8859-15?Q?Thomas_Wei=DFschuh?= Subject: Re: [PATCH] tmpfs: ensure O_LARGEFILE with generic_file_open() In-Reply-To: <20220928104535.61186-1-linux@weissschuh.net> Message-ID: <4d5a721-cffe-cc7-8023-ae86ba35cb7d@google.com> References: <20220928104535.61186-1-linux@weissschuh.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1463760895-1420712399-1664396855=:21219" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664396857; a=rsa-sha256; cv=none; b=ClhRawUMw0sf9FEz4xk6foVLIFTsrgJtNVmBLUvQ8HJ30YUUfEVwg19dDiCbY7ZmS2tlxd D4o/gkPP+oMzFL2XDTIXSwPLi2eEPacknutrfQ3YMpYgnxgKZ8HbqADue0fAdBj/EZYVGb ejwSMZcnHp76UbV+ZabBkMRXJbKpySA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NvoTO3K9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of hughd@google.com designates 209.85.222.181 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664396857; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8adqXN45JE2olLRk9Lphi2ZcgXsJm6thwoQKvNld65w=; b=HqguRuD1KDCl8jn2byun1fiJjKiOGsiSZc+x9vvRwKST8d7Vha9PWk3Z9Dm/yoyDMPmwSt Xt+YJqScfhPdHSLmwoUEz54uMMPCr3bboO7Sb9gDnpp46aCKSiWA4IoYRfK/4vLzJYaeU9 rr9mWxejSPp2zOd5/Dj6KVziEZUYk8Y= X-Stat-Signature: fgf6xanpj3ox8y8ye5r63xb89o8mk48r X-Rspamd-Queue-Id: 1D1F02000D Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=NvoTO3K9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf03.hostedemail.com: domain of hughd@google.com designates 209.85.222.181 as permitted sender) smtp.mailfrom=hughd@google.com X-Rspamd-Server: rspam02 X-Rspam-User: X-HE-Tag: 1664396856-62774 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463760895-1420712399-1664396855=:21219 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE On Wed, 28 Sep 2022, Thomas Wei=C3=9Fschuh wrote: > From: Thomas Wei=C3=9Fschuh >=20 > Without this check open() will open large files on tmpfs although > O_LARGEFILE was not specified. This is inconsistent with other > filesystems. > Also it will later result in EOVERFLOW on stat() or EFBIG on write(). >=20 > Link: https://lore.kernel.org/lkml/76bedae6-22ea-4abc-8c06-b424ceb39217@t= -8ch.de/ > Signed-off-by: Thomas Wei=C3=9Fschuh Acked-by: Hugh Dickins Thanks! I think you deserve some special award for finding and fixing such an ancient bug/inconsistency - dating back to early v2.4 it seems. But only affecting 32-bit; and since we've happily lived with it so long, and the fix does change behaviour for userspace, better not to Cc stable. There are some other filesystems still behaving as tmpfs was (ramfs, hugetlbfsi, and I didn't look further); but we do make more of an effort to keep tmpfs in line with the major filesystems - thank you. > --- > mm/shmem.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/mm/shmem.c b/mm/shmem.c > index 42e5888bf84d..902c5550fabc 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3876,6 +3876,7 @@ EXPORT_SYMBOL(shmem_aops); > =20 > static const struct file_operations shmem_file_operations =3D { > =09.mmap=09=09=3D shmem_mmap, > +=09.open=09=09=3D generic_file_open, > =09.get_unmapped_area =3D shmem_get_unmapped_area, > #ifdef CONFIG_TMPFS > =09.llseek=09=09=3D shmem_file_llseek, >=20 > base-commit: f76349cf41451c5c42a99f18a9163377e4b364ff > --=20 > 2.37.3 ---1463760895-1420712399-1664396855=:21219--