From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 263DFC4363A for ; Mon, 5 Oct 2020 09:47:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 92C852078E for ; Mon, 5 Oct 2020 09:47:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K2LIoGVd" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92C852078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C42816B005D; Mon, 5 Oct 2020 05:47:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BF3846B0062; Mon, 5 Oct 2020 05:47:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0B2B8E0001; Mon, 5 Oct 2020 05:47:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 86ADE6B005D for ; Mon, 5 Oct 2020 05:47:09 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1A114B2AF for ; Mon, 5 Oct 2020 09:47:09 +0000 (UTC) X-FDA: 77337393378.03.cable87_3a14eef271bd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id EEFF128A4E8 for ; Mon, 5 Oct 2020 09:47:08 +0000 (UTC) X-HE-Tag: cable87_3a14eef271bd X-Filterd-Recvd-Size: 4942 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf20.hostedemail.com (Postfix) with ESMTP for ; Mon, 5 Oct 2020 09:47:08 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id r127so5520113lff.12 for ; Mon, 05 Oct 2020 02:47:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pgMwKazhCKZFftw47Ht1BMoXWpFBSCf7a1kv9wg1i9A=; b=K2LIoGVdP7xdTNMYwv4AyZ1dmRU7GcwbWIIRS6sa1Yu3Q1FfpoLwNp6siYqp3IZ/HP nWoWh8YGKnoIddnGE8CX3NjdYYqMmK3sFNvLoewxJmFpBhY+DkHeNbbJ00c0F1VE1Ga6 nhKMK3Nho37X2RgXeXtPZLCawBb/5RNVmYIfGnb0Yn+UgbegeSMRgMXHT4WO6a/xBiyf Zbblw5jBcgJVevEkBIvg613hht1a2VPhW9uTEk9o2u9PtVB+sryZRVxipYnq/HQ//9Ba 9JEQk3fTl9WgjcEzE2xdToWHd2JmUzfRc5mHEhN70zdDge364AhgMBtr6ZZwbLSmUzhg gFsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pgMwKazhCKZFftw47Ht1BMoXWpFBSCf7a1kv9wg1i9A=; b=tjXNfKjr/M3ojLCRlre4hh036sJPCz7yMpRXh2dR7D5zgp/aAPxbmiZNIp17YjzQkM qYiY9wqest77Ss5USTGJoD4ana7qz/SW/Hqa14v7TK+f5DfigZz+eUogByjmw9tCpzk5 iJm2RzagNhnLDsby09CgrilYPk/rxbe+rVkYCeRnDdc1BSNhKWJfHCMkZNs/1Naj5qO6 pWKyENVhNCRon/KlfVZtX8bx6BzEk2g682FJ1p2G1N7zn5khSsH4OyDbzGB61PwNPvCh ZLIQ+mWPVuRJ/IoXjeFRuJZAr3aZd3jRal/L1zUVTP1lL9H5YkFRx/bqeDZhDjdHVvw9 fqFw== X-Gm-Message-State: AOAM533CnZvnv5AV0s0JAbI7omYxGq8ssjqvttzdXoPbHOPS/XbaskPu jojfq+erHXNlZxqxp4kNMI0= X-Google-Smtp-Source: ABdhPJzadCJ7vlw8hDztAmcvlVIMgVDNlVOYpHLNNiSM6ltqhUK7+VUBGbO8Vh3q/ziIQsCONc7TtQ== X-Received: by 2002:a19:dcb:: with SMTP id 194mr5167787lfn.25.1601891227092; Mon, 05 Oct 2020 02:47:07 -0700 (PDT) Received: from [192.168.1.89] (88-114-211-119.elisa-laajakaista.fi. [88.114.211.119]) by smtp.gmail.com with ESMTPSA id 136sm31462lfi.176.2020.10.05.02.47.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Oct 2020 02:47:06 -0700 (PDT) Subject: Re: [PATCH] mm: optionally disable brk() To: David Hildenbrand , Michal Hocko Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201002171921.3053-1-toiwoton@gmail.com> <653873ef-2a57-37e0-1ac3-fba763652b35@redhat.com> <2a0f5ade-d770-c36e-50bc-ff0c8e9dacbf@gmail.com> <20201005061248.GN4555@dhcp22.suse.cz> <888e62e0-3979-207b-c516-ddfc6b9f3345@redhat.com> From: Topi Miettinen Message-ID: <4d325e3e-3139-eded-6781-435fb04fb915@gmail.com> Date: Mon, 5 Oct 2020 12:47:03 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <888e62e0-3979-207b-c516-ddfc6b9f3345@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 5.10.2020 12.13, David Hildenbrand wrote: > On 05.10.20 08:12, Michal Hocko wrote: >> On Sat 03-10-20 00:44:09, Topi Miettinen wrote: >>> On 2.10.2020 20.52, David Hildenbrand wrote: >>>> On 02.10.20 19:19, Topi Miettinen wrote: >>>>> The brk() system call allows to change data segment size (heap). This >>>>> is mainly used by glibc for memory allocation, but it can use mmap() >>>>> and that results in more randomized memory mappings since the heap is >>>>> always located at fixed offset to program while mmap()ed memory is >>>>> randomized. >>>> >>>> Want to take more Unix out of Linux? >>>> >>>> Honestly, why care about disabling? User space can happily use mmap() if >>>> it prefers. >>> >>> brk() interface doesn't seem to be used much and glibc is happy to switch to >>> mmap() if brk() fails, so why not allow disabling it optionally? If you >>> don't care to disable, don't do it and this is even the default. >> >> I do not think we want to have config per syscall, do we? > > I do wonder if grouping would be a better option then (finding a proper > level of abstraction ...). If hardening and compatibility are seen as tradeoffs, perhaps there could be a top level config choice (CONFIG_HARDENING_TRADEOFF) for this. It would have options - "compatibility" (default) to gear questions for maximum compatibility, deselecting any hardening options which reduce compatibility - "hardening" to gear questions for maximum hardening, deselecting any compatibility options which reduce hardening - "none/manual": ask all questions like before -Topi