From: Mike Kravetz <mike.kravetz@oracle.com>
To: Miaohe Lin <linmiaohe@huawei.com>, akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/5] hugetlb_cgroup: remove unnecessary VM_BUG_ON_PAGE in hugetlb_cgroup_migrate()
Date: Fri, 12 Mar 2021 11:46:18 -0800 [thread overview]
Message-ID: <4d302b2e-39a1-e4eb-2b7b-b5d4145bbec2@oracle.com> (raw)
In-Reply-To: <20210308112809.26107-4-linmiaohe@huawei.com>
On 3/8/21 3:28 AM, Miaohe Lin wrote:
> !PageHuge(oldhpage) is implicitly checked in page_hstate() above, so we
> remove this explicit one.
Correct. In addition, this will only be called for hugetlb pages. The
VM_BUG_ON_PAGE is unnecessary.
>
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
> mm/hugetlb_cgroup.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
>
> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> index 8668ba87cfe4..3dde6ddf0170 100644
> --- a/mm/hugetlb_cgroup.c
> +++ b/mm/hugetlb_cgroup.c
> @@ -785,7 +785,6 @@ void hugetlb_cgroup_migrate(struct page *oldhpage, struct page *newhpage)
> if (hugetlb_cgroup_disabled())
> return;
>
> - VM_BUG_ON_PAGE(!PageHuge(oldhpage), oldhpage);
> spin_lock(&hugetlb_lock);
> h_cg = hugetlb_cgroup_from_page(oldhpage);
> h_cg_rsvd = hugetlb_cgroup_from_page_rsvd(oldhpage);
>
next prev parent reply other threads:[~2021-03-12 20:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 11:28 [PATCH 0/5] Some cleanups for hugetlb Miaohe Lin
2021-03-08 11:28 ` [PATCH 1/5] mm/hugetlb: use some helper functions to cleanup code Miaohe Lin
2021-03-08 11:28 ` [PATCH 2/5] mm/hugetlb: optimize the surplus state transfer code in move_hugetlb_state() Miaohe Lin
2021-03-08 11:28 ` [PATCH 3/5] hugetlb_cgroup: remove unnecessary VM_BUG_ON_PAGE in hugetlb_cgroup_migrate() Miaohe Lin
2021-03-12 19:46 ` Mike Kravetz [this message]
2021-03-08 11:28 ` [PATCH 4/5] mm/hugetlb: simplify the code when alloc_huge_page() failed in hugetlb_no_page() Miaohe Lin
2021-03-12 19:58 ` Mike Kravetz
2021-03-13 2:54 ` Miaohe Lin
2021-03-08 11:28 ` [PATCH 5/5] mm/hugetlb: avoid calculating fault_mutex_hash in truncate_op case Miaohe Lin
2021-03-12 20:03 ` Mike Kravetz
2021-03-13 2:49 ` Miaohe Lin
2021-03-13 21:17 ` Mike Kravetz
2021-03-15 1:50 ` Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d302b2e-39a1-e4eb-2b7b-b5d4145bbec2@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox