From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9824C433EF for ; Tue, 8 Mar 2022 11:44:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 81AF48D0003; Tue, 8 Mar 2022 06:44:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7CAC38D0001; Tue, 8 Mar 2022 06:44:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 692858D0003; Tue, 8 Mar 2022 06:44:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0029.hostedemail.com [216.40.44.29]) by kanga.kvack.org (Postfix) with ESMTP id 5CFA98D0001 for ; Tue, 8 Mar 2022 06:44:26 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 1117F181AC9CC for ; Tue, 8 Mar 2022 11:44:26 +0000 (UTC) X-FDA: 79221036132.19.158C9DA Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf19.hostedemail.com (Postfix) with ESMTP id 442AC1A0013 for ; Tue, 8 Mar 2022 11:44:25 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4KCYJk6pM3z1GC1w; Tue, 8 Mar 2022 19:39:34 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Tue, 8 Mar 2022 19:44:21 +0800 Subject: Re: [PATCH 02/16] mm/migration: remove unneeded out label To: "Huang, Ying" CC: , , , , , , , , , , , , , , , , , References: <20220304093409.25829-1-linmiaohe@huawei.com> <20220304093409.25829-3-linmiaohe@huawei.com> <877d967c4i.fsf@yhuang6-desk2.ccr.corp.intel.com> From: Miaohe Lin Message-ID: <4d2dca2b-8abc-a937-3397-dde6c247874d@huawei.com> Date: Tue, 8 Mar 2022 19:44:21 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <877d967c4i.fsf@yhuang6-desk2.ccr.corp.intel.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 442AC1A0013 X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf19.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: 1m5h8ji4juhdb8zjgk9kqxu7pjhytc1s X-HE-Tag: 1646739865-273731 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/3/7 10:03, Huang, Ying wrote: > Miaohe Lin writes: > >> We can do prep_transhuge_page when newpage is not NULL. Thus we can remove >> out label to simplify the code. >> >> Signed-off-by: Miaohe Lin >> --- >> mm/migrate.c | 7 ++----- >> 1 file changed, 2 insertions(+), 5 deletions(-) >> >> diff --git a/mm/migrate.c b/mm/migrate.c >> index 50bc62d85eaf..bc1867a5706c 100644 >> --- a/mm/migrate.c >> +++ b/mm/migrate.c >> @@ -2025,12 +2025,9 @@ static struct page *alloc_misplaced_dst_page_thp(struct page *page, >> >> newpage = alloc_pages_node(nid, (GFP_TRANSHUGE_LIGHT | __GFP_THISNODE), >> HPAGE_PMD_ORDER); >> - if (!newpage) >> - goto out; >> + if (newpage) >> + prep_transhuge_page(newpage); >> >> - prep_transhuge_page(newpage); >> - >> -out: >> return newpage; >> } > > I don't think this change is necessary. The original code is simple and > follows the common practice for error processing. The new code is OK, > but it's unnecessary to change. > IMO, this out label looks 'overkill'. We should remove it and make code more succinct. Does this make sense to you? Thanks. > Best Regards, > Huang, Ying > . >