From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09DD4C433F5 for ; Thu, 20 Jan 2022 18:20:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EC2B6B009E; Thu, 20 Jan 2022 13:20:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59B636B00A0; Thu, 20 Jan 2022 13:20:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 43C806B00A1; Thu, 20 Jan 2022 13:20:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0059.hostedemail.com [216.40.44.59]) by kanga.kvack.org (Postfix) with ESMTP id 350926B009E for ; Thu, 20 Jan 2022 13:20:34 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id ED9DB181D861D for ; Thu, 20 Jan 2022 18:20:33 +0000 (UTC) X-FDA: 79051480746.27.521B89A Received: from smtp-42ad.mail.infomaniak.ch (smtp-42ad.mail.infomaniak.ch [84.16.66.173]) by imf27.hostedemail.com (Postfix) with ESMTP id 0A2BC4002F for ; Thu, 20 Jan 2022 18:20:32 +0000 (UTC) Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4JfrR30wHPzMpp4H; Thu, 20 Jan 2022 19:20:31 +0100 (CET) Received: from ns3096276.ip-94-23-54.eu (unknown [23.97.221.149]) by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 4JfrR04KcwzlhSM0; Thu, 20 Jan 2022 19:20:28 +0100 (CET) Message-ID: <4d2b0f3f-4783-3681-382d-4084c6bf79fc@digikod.net> Date: Thu, 20 Jan 2022 19:20:38 +0100 MIME-Version: 1.0 User-Agent: Content-Language: en-US To: Muhammad Usama Anjum , Shuah Khan , Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Darren Hart , Davidlohr Bueso , =?UTF-8?Q?Andr=c3=a9_Almeida?= , Paolo Bonzini , "David S. Miller" , Jakub Kicinski , Mat Martineau , Matthieu Baerts , Andrew Morton , chiminghao , "open list:KERNEL SELFTEST FRAMEWORK" , open list , "open list:KERNEL VIRTUAL MACHINE (KVM)" , "open list:LANDLOCK SECURITY MODULE" , "open list:NETWORKING [GENERAL]" , "open list:NETWORKING [MPTCP]" , "open list:MEMORY MANAGEMENT" Cc: kernel@collabora.com References: <20220119101531.2850400-1-usama.anjum@collabora.com> <20220119101531.2850400-7-usama.anjum@collabora.com> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Subject: Re: [PATCH V2 06/10] selftests: landlock: Add the uapi headers include variable In-Reply-To: <20220119101531.2850400-7-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8; format=flowed X-Rspamd-Queue-Id: 0A2BC4002F X-Stat-Signature: i8mdwzfnm4h4pf13k3sat4tysnwtejfk Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of mic@digikod.net designates 84.16.66.173 as permitted sender) smtp.mailfrom=mic@digikod.net; dmarc=none X-Rspamd-Server: rspam03 X-HE-Tag: 1642702832-589773 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 19/01/2022 11:15, Muhammad Usama Anjum wrote: > Out of tree build of this test fails if relative path of the output > directory is specified. Add the KHDR_INCLUDES to correctly reach the > headers. >=20 > Signed-off-by: Muhammad Usama Anjum > --- > Changes in V2: > Revert the excessive cleanup which was breaking the individual > test build. > --- > tools/testing/selftests/landlock/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tools/testing/selftests/landlock/Makefile b/tools/testing/= selftests/landlock/Makefile > index a99596ca9882..0b0049e133bb 100644 > --- a/tools/testing/selftests/landlock/Makefile > +++ b/tools/testing/selftests/landlock/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > =20 > -CFLAGS +=3D -Wall -O2 > +CFLAGS +=3D -Wall -O2 $(KHDR_INCLUDES) Reviewed-by: Micka=C3=ABl Sala=C3=BCn It works for me, but I'm wondering if a missing -I path could cause any=20 issue (cf. -I$(khdr_dir) bellow in this file). My GCC and clang ignore=20 such non-existent paths unless -Wmissing-include-dirs is used, which=20 would print a warning on your CI, but I guess that's OK. > =20 > src_test :=3D $(wildcard *_test.c) > =20