From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2C06D64078 for ; Fri, 8 Nov 2024 19:00:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7C3AE6B009F; Fri, 8 Nov 2024 14:00:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 772E76B00CB; Fri, 8 Nov 2024 14:00:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59B6A6B00CC; Fri, 8 Nov 2024 14:00:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 383AA6B00CB for ; Fri, 8 Nov 2024 14:00:35 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D66EEA0A63 for ; Fri, 8 Nov 2024 19:00:34 +0000 (UTC) X-FDA: 82763843232.18.D8CF335 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf25.hostedemail.com (Postfix) with ESMTP id 7B12EA000D for ; Fri, 8 Nov 2024 19:00:05 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gIAaBkgX; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731092380; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O0N0dqt2AOiHgJyVj6USAh4K7FpOzpZNcsmO3xiEHCk=; b=jO7ie819Mi4HqFFCM+jexv5V50Q2rK1K6uPevqpBMUVk+1wiV23kNc2uKFKGAAAHHyq3FI oLKbvulQMk7zJWQAGko7tuV82UaplRsnlIR1Z6VV+B6cCFegpFeVdHUbARFT1R+6+E8M8i svj/xogWSHVcQzY1M6NTMcGz21ODQKA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731092380; a=rsa-sha256; cv=none; b=lSB9X7Eolv+BrDVkNl3ObP810eeWJx6Atv90Bt4JCjynVneyjBxeKjVEuVyQJi9i4tHq0t GERzyoKJ1aEZ+LGkDRxoaKSEqSyNqNs7mMywHTsOMqxrJTpkBfkG8FFAm+gF+UGSLhdEYq oxuJxy8QVrVCr10WfkjK0DRm9uYHoN4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gIAaBkgX; spf=pass (imf25.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1731092431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=O0N0dqt2AOiHgJyVj6USAh4K7FpOzpZNcsmO3xiEHCk=; b=gIAaBkgXE+TJuBeL2C1VHiKgR+boXNRRXqqNSkoV9FtzWJjfKCby9ccJilXMEi8LFF1gWy pFba0Qx45oz8JkabGQPVIGt9LB7/QD6DW7y0INC6OEhYPPALq0c7WmJaw6gWWUWfU97uV7 nvZ0zggVaK1R8jgmkBhgt5X5OE9BRTA= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-217-UgWFpDr4Ojyt3VuRXNEh8g-1; Fri, 08 Nov 2024 14:00:30 -0500 X-MC-Unique: UgWFpDr4Ojyt3VuRXNEh8g-1 X-Mimecast-MFC-AGG-ID: UgWFpDr4Ojyt3VuRXNEh8g Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d533a484aso1817960f8f.0 for ; Fri, 08 Nov 2024 11:00:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731092429; x=1731697229; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:from:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=O0N0dqt2AOiHgJyVj6USAh4K7FpOzpZNcsmO3xiEHCk=; b=IPEhSs/O62f3AkX9jmiH+SlwEGoxV6/sZrO+DfNnLW16/xQewtmPiRHagQIN5l3YrI 5+8yU9NBwJkebdncYrV1DnyYFEeFsZvw2/hS1loqfbUNWZwD1OrBAq+B0sE984Cb3j4R f9v9tbbOZDXirKDJAeLfUeaTbgfmOBKLaTDQ7mkKRy2UEWXMStuD15ooGZocjSXniEr+ lzlG+LWoUI17IzW8mR7agNawDzqTW4cmQtOLo3nQHhDKDsI2cO40x6z1WCUdMBRrKAV3 m07c7OMpswINZnwEYLhGHaMuuypOF7lwpDTC5y+eAj3UcU5J6aa6uHc8DrEGpyp2IGRf DI4g== X-Forwarded-Encrypted: i=1; AJvYcCWzkcLeFBRTZOStohqBkJUqn9QsQufLBIEHt4VQ5/h9gYUEbrBN0p52BBShCd6cg0WIaH9knzG6tw==@kvack.org X-Gm-Message-State: AOJu0YyZ4OLjvnltNFyHdxhkyoB0sS3Nm2NUfiS8uNAQcuLx+eafn6Wn 6EZuVzRXe1MgnqjivlkRpyuWu3aP+aDGuNjos2rTQYEgm1xkTPLGawGGzWDeszG8sZ8qQelY0qZ b4QfjV54LJ8dcKr40cbUXjNYaF1Sw3Pl+ibeKpkfy+zyrGJF/ X-Received: by 2002:a05:6000:402c:b0:374:c1ea:2d40 with SMTP id ffacd0b85a97d-381f0f40d9cmr3953634f8f.1.1731092429002; Fri, 08 Nov 2024 11:00:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IF8NXteKUBnfajTNiTy8pGXq2AJ7BRCVrspkKpZbYGMnfSQehiOah1tafen33BoWgw1mQ+Lzg== X-Received: by 2002:a05:6000:402c:b0:374:c1ea:2d40 with SMTP id ffacd0b85a97d-381f0f40d9cmr3953606f8f.1.1731092428616; Fri, 08 Nov 2024 11:00:28 -0800 (PST) Received: from ?IPV6:2003:d8:2f3a:cb00:3f4e:6894:3a3b:36b5? (p200300d82f3acb003f4e68943a3b36b5.dip0.t-ipconnect.de. [2003:d8:2f3a:cb00:3f4e:6894:3a3b:36b5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-381ed9ea4f6sm5697729f8f.64.2024.11.08.11.00.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 08 Nov 2024 11:00:27 -0800 (PST) Message-ID: <4d2062bd-3cf3-4488-8dfc-b0aa672ee786@redhat.com> Date: Fri, 8 Nov 2024 20:00:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 4/6] mm/memory-hotplug: add finite retries in offline_pages() if migration fails From: David Hildenbrand To: SeongJae Park , Joanne Koong Cc: miklos@szeredi.hu, linux-fsdevel@vger.kernel.org, shakeel.butt@linux.dev, jefflexu@linux.alibaba.com, josef@toxicpanda.com, linux-mm@kvack.org, bernd.schubert@fastmail.fm, kernel-team@meta.com References: <20241108173309.71619-1-sj@kernel.org> <04020bb7-5567-4b91-a424-62c46f136e2a@redhat.com> Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <04020bb7-5567-4b91-a424-62c46f136e2a@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zFdaUWZ22PBlMRoQiTDPN2Akcriq8vhPqxA_ZrSunlc_1731092429 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: rxyzini4ktjpt4q45qhttqkwtzz86s7k X-Rspam-User: X-Rspamd-Queue-Id: 7B12EA000D X-Rspamd-Server: rspam02 X-HE-Tag: 1731092405-495884 X-HE-Meta: U2FsdGVkX19bdVjnjX+GkW6/2SkpgnyDYw1xoVt5wIZJptiELZfM9VaWqyctXQkAFd36RubQuu8aLYEI4eXLEid/pKs1CgPtYodRs4YJWtaTdttT5I4BVzx36hfWkCWi9eVd8k4AX3oMwmEetrFT1FnyRMCX54WyhXacl0N3ErzNQOpUZalQtM8kAyqX/nQ9jzwCYs9a1LvjL8Of7IqvWFEhXOxm5X9EEhQgxJG1ouxpXeYmkXBakBJWCkrWYldbHDn2eFVtbzRVeLRtd86Rwo9/JKjtZuuKRN9OfkU0sTUe9VIeV7kMsKHtFYWVzZQk5Y5051LunAw8QupvdpiiEMpPcRlJ6hLxiWgaY18t+2lL81FBRydTQaT0bljzjutmyorCb9L9tKJOWNTiVBrF+X00xtnG+WMWHKnPWyQEP+Os9+g5ctpJoqovWXa4pEe9HfwKCxsn3K4CaC+xuIZA29IqddeBskr1Zpbv+gFe4+3mfEoUp3SSvOO/dme5A78Y8d3Pk9dP5wm2rwiQSUT55VgUa9PIQkpZzejTeD+60JEKtiwgioX1l0TKx5DwuALHMcnZvZAX7pcN3BhchY0h1PebQ80hRmFe4utXB8Gr0McwYsUlFZrHNoWX1I/WHwtjqwO85V6pFP7H4UCElUxacD2zU5D0wV/2PiDlG/hlj+hhanrpAucblPm1oc5aXPq3g7DijcUakYnuQWI03pKAQJNnu35qHel6FB7HOXS1Lry5yjylkBjomhsMD7hIWkI7ZxypX0FiA8MYVEp3FA1ArDfaK3Og/YNgf1h4fREBai7Iitqk8G9m3RgfM5IvTo0/G3/is/06FTxm8fHkcneoSVEe4x1SNICKM8ddGv63e6EKZTkc+H0cXkDUwVBmkBnRhuEFQ9RpjScS1HAaCRAfzTFZs+KDhBngpJRLviOtGjOlaM0d/GTkS8DgdwlzLZLlAzHsCyfOKVkNpaI2E12 hunjzJif NdaFGngH+Q8ajkWQZIMT0deBfnmOqHNtTDaSIAb3NQFMEO5TVkIsBiGAmXY+U0keynaqS7Orkl+v0pX7xGENI9EFmqTHOJaf938eQFu+sk1SrpXOd9SacjdhJ2rahi/I/tgNTEdDJUnyr1p5HS11zhnxpDuzY2gfpF29r+GZH7cobWyh9uXIpJkMgRNDuvc69E6ysF4Bcv4U4Go/hFx3iLgJJ5yfjxvKYc0ohSCFEZ1KPthAUqPd2TqJHDqKPpWhX4audtlFCbNB4unRoZ2biXlPmoehQ3cQd7ZFgTyJEqYQ1R1ENp9KFtavY9dh3Y3hZKrqbRZ+HYIEGZ7c4YbzVq2OjJpbjj7W78JD3WtMj0iSEl8mgKHq+2TlZlZb30syRsS1aw3aKN8HjmYfuPoXEgoXNZsBL88nFBieU452teLejssvtkYH8Qclo2LTiEXKursLef/v0CvW4/mZvI2sApBbJQOh9xXHErr8BWFoIW/Lk8LTUjYMXdBv3C0dnKgzYC0QgGIwj3NGoYMI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.021285, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08.11.24 19:56, David Hildenbrand wrote: > On 08.11.24 18:33, SeongJae Park wrote: >> + David Hildenbrand >> >> On Thu, 7 Nov 2024 15:56:12 -0800 Joanne Koong wrote: >> >>> In offline_pages(), do_migrate_range() may potentially retry forever if >>> the migration fails. Add a return value for do_migrate_range(), and >>> allow offline_page() to try migrating pages 5 times before erroring >>> out, similar to how migration failures in __alloc_contig_migrate_range() >>> is handled. >> >> I'm curious if this could cause unexpected behavioral differences to memory >> hotplugging users, and how '5' is chosen. Could you please enlighten me? >> > > I'm wondering how much more often I'll have to nack such a patch. :) A more recent discussion: https://lore.kernel.org/linux-mm/52161997-15aa-4093-a573-3bfd8da14ff1@fujitsu.com/T/#mdda39b2956a11c46f8da8796f9612ac007edbdab Long story short: this is expected and documented -- Cheers, David / dhildenb