From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6766CC6FA82 for ; Tue, 20 Sep 2022 01:46:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB59A94000B; Mon, 19 Sep 2022 21:46:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B64C6940007; Mon, 19 Sep 2022 21:46:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2D6894000B; Mon, 19 Sep 2022 21:46:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 96AF9940007 for ; Mon, 19 Sep 2022 21:46:10 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7F27F160619 for ; Tue, 20 Sep 2022 01:46:10 +0000 (UTC) X-FDA: 79930773300.03.D67798A Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by imf27.hostedemail.com (Postfix) with ESMTP id A247F40003 for ; Tue, 20 Sep 2022 01:46:08 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=xhao@linux.alibaba.com;NM=1;PH=DS;RN=5;SR=0;TI=SMTPD_---0VQGgUhH_1663638364; Received: from 30.240.98.170(mailfrom:xhao@linux.alibaba.com fp:SMTPD_---0VQGgUhH_1663638364) by smtp.aliyun-inc.com; Tue, 20 Sep 2022 09:46:05 +0800 Message-ID: <4d1041d6-2163-1a90-7f25-daf72f7d139c@linux.alibaba.com> Date: Tue, 20 Sep 2022 09:46:03 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH V3] mm/hugetlb: add available_huge_pages() func To: Mike Kravetz Cc: songmuchun@bytedance.com, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220917011528.11331-1-xhao@linux.alibaba.com> From: haoxin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1663638370; a=rsa-sha256; cv=none; b=w6rbd6AHmEp4Y9l1Ba5mGtCVh9OwLPYU+AFiNlFEtsUEgHrGD4Hu12XaIboddtczVQjerv kzhcrzFhl2Thc1ummuYeDZJNDyEF22QLOqSMSdx0K3e/4tzQAmRuKpacLPyMW9xmFLRLut w4valIxMkQf+ZvmsDo4thWPzD8CiAcE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf27.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.42 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1663638370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UNUhdJneyK7RGJWv95kLbfrpxkrt+noXel/wAV2R7Ro=; b=TBt/Q/d5xJr0UK1HqD3lGMRWXNTztQRR2vzBaiNoVIwrWaoeViQlOFISWh8JrUGQSDT7g9 qVbgPgwBL2sR0esBewmMvKMDormPMdIm9oBa5XWNC4DteZDeHNuxVL5Hk9l1PbEPpsjsbT xOuMNGuDQlaIKT8eYx3jhn0ma1dzynQ= X-Stat-Signature: kqrgeoemrfpspk7m5oihw6ffd7kmh9ps X-Rspamd-Queue-Id: A247F40003 X-Rspam-User: Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=alibaba.com; spf=pass (imf27.hostedemail.com: domain of xhao@linux.alibaba.com designates 115.124.30.42 as permitted sender) smtp.mailfrom=xhao@linux.alibaba.com X-Rspamd-Server: rspam03 X-HE-Tag: 1663638368-782636 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: 在 2022/9/20 上午7:58, Mike Kravetz 写道: > On 09/17/22 09:15, Xin Hao wrote: >> In hugetlb.c file, there are several places to compare the values of >> 'h->free_huge_pages' and 'h->resv_huge_pages', it looks a bit messy, so >> there add a new available_huge_pages() func to do these. > Thanks, I think the code looks a little better with this change. > >> Signed-off-by: Xin Hao >> Changes from v2 >> https://lore.kernel.org/linux-mm/20220916064127.1904-1-xhao@linux.alibaba.com/ >> - Convert is_resv_equal_free() to available_huge_pages() > I believe the above 'Changes from v2' information should be below the marker > '---' as it will not be included in the changelog. Ok, i will remove the changelog in the next patch. > >> --- >> mm/hugetlb.c | 14 +++++++++----- >> 1 file changed, 9 insertions(+), 5 deletions(-) > The changes look fine, > > Reviewed-by: Mike Kravetz