From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C476C4345F for ; Fri, 12 Apr 2024 09:34:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 217456B0082; Fri, 12 Apr 2024 05:34:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C6E36B0083; Fri, 12 Apr 2024 05:34:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B6A36B0087; Fri, 12 Apr 2024 05:34:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E23206B0082 for ; Fri, 12 Apr 2024 05:34:53 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9DB851A0DC6 for ; Fri, 12 Apr 2024 09:34:53 +0000 (UTC) X-FDA: 82000370466.19.23660B3 Received: from mail-oo1-f51.google.com (mail-oo1-f51.google.com [209.85.161.51]) by imf18.hostedemail.com (Postfix) with ESMTP id C84CE1C0022 for ; Fri, 12 Apr 2024 09:34:51 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=Vf473KTg; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf18.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.161.51 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712914491; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aLAyHld4nBwM9U/oMij3cJEhNh4cYcKp+0eslEaQ9w0=; b=2WWdvQ0QRfzDiQg4SXffgZ5ImBlHAf5P7hrRveuly5ChJGcbXCw8lkaUGZ7nbxm1ujr6Km NKyvS47t7qsfkRsMEBOa6zDOkjs0Smf6RWd6e/0eR+jen+culopJjRX1fFt7qomgo0LXaE oW8w41C4DWb4U3RKX831NPOa8RyGZ1Y= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=Vf473KTg; dmarc=pass (policy=reject) header.from=shopee.com; spf=pass (imf18.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.161.51 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712914491; a=rsa-sha256; cv=none; b=7/vW1rrp5lER37peT4Q7QTitIgtbqA+xxfs34m7Lp+Ri0Ujdyc0QU2wfRik04geID6Q43K m8UHahypULC1tc69AoZBA3lH21OxBnzeGRODgndfP1VtOzaj4JsLiZG64P2lIRWvNF1rew AXnsLWOgtV+oIdeAfy/D8YcqV5zaBP4= Received: by mail-oo1-f51.google.com with SMTP id 006d021491bc7-5aa2bd6f651so542926eaf.0 for ; Fri, 12 Apr 2024 02:34:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; t=1712914491; x=1713519291; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=aLAyHld4nBwM9U/oMij3cJEhNh4cYcKp+0eslEaQ9w0=; b=Vf473KTgfCcLC3g3Ntqprds8lUgM7b2I2unT/ajyG9UlQZ2iC/3kuvo84hewx9FDyX 0HwAsGjXGhqydHYb4OueHd7Lcp0IUM3CmfSnh9At8QhoOZiVuGPkbKgsnr8nijvB4ssd HFRdS/KuJDZZUDrvHJY5MMiQKwYOWfR2edNrE71aMujxB1QfzdYieC0nYiyocZdzdUEp cr4Ad0akr0/+3ZptMu6Upuud4yYx2CV/1SaKjvYMq3sDTpvRl7LQGoQ092jB68KEsFDy NyuMZfJS5XjPwNayBwOqGwqa7t1lWZIFNG7yEavRMY9M+7naoz8burW+kYdplibMfcDd ffAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712914491; x=1713519291; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=aLAyHld4nBwM9U/oMij3cJEhNh4cYcKp+0eslEaQ9w0=; b=qGNsg7TBHLAp39n8eTGaX5bKZrq/UB/OLa+FDycnaXbt5+QywjsCM5rHMJZsmsK+af 0CYUoa5rF2YKzDAWxvaIEshTWfrZWrV5QwegeMancPGt9+LZkas9cERdMLC/e+Cawzrb LkmRbJTXdSmRsq3NaSaf+lLPJGXYGEIkEDLUDG0KcZujt/DS1f7lJZU34TWoZEQZqFXh W4MqXalFX17YZPykxAWUvm6BEVdwpMQjT5pZHLj+vbgLXefuWJVHjFGFzvwp8mfNHKkx 5X6vAjAs0bPoBlB+XLa15cR1DyZse8jykla3I0myAjqc/qNMfU+Ej4pqP5JuVfQvES53 ppVQ== X-Forwarded-Encrypted: i=1; AJvYcCVsJe5KDfWBNmU6Ymc3hqS4YtcD7e8ZhlfLK6XzKbtysiHTbdUM+1JibbBO0FNAK2+31gGnrjJ26h2jAyqK64HdcR0= X-Gm-Message-State: AOJu0YxJh/0QB/im5zx2OqKxHYbRxozBsnp2S7LCQ2f941c7XNjUqhPS Ts3IKIXa9RW+vXFHoSGLYN7NzvlJMSmBlIcaO0lG0vpzQW94GkJXFEHXs7BzYFM= X-Google-Smtp-Source: AGHT+IFxWq6gMeU26lsyPmW/F+OpjvVPv25ng9NXVlr4+HWtyZekf7KEkyBbJWD1v/q8JUEBPWxFlw== X-Received: by 2002:a05:6358:7d0c:b0:186:1152:d741 with SMTP id i12-20020a0563587d0c00b001861152d741mr1873872rwg.6.1712914490701; Fri, 12 Apr 2024 02:34:50 -0700 (PDT) Received: from [10.54.24.115] ([143.92.118.3]) by smtp.gmail.com with ESMTPSA id q4-20020a656244000000b005dc4fc80b21sm2047884pgv.70.2024.04.12.02.34.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Apr 2024 02:34:50 -0700 (PDT) Message-ID: <4d0f2910-8fc5-4b08-b70d-5a5531d4ee2c@shopee.com> Date: Fri, 12 Apr 2024 17:34:45 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page To: "Christoph Lameter (Ampere)" Cc: vbabka@suse.cz, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240411091832.608280-1-haifeng.xu@shopee.com> <5482360c-0a0b-e5f5-b88e-4a6ec4d43f7d@linux.com> From: Haifeng Xu In-Reply-To: <5482360c-0a0b-e5f5-b88e-4a6ec4d43f7d@linux.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C84CE1C0022 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: jypxmz4x3844uimysiemexot6wex3pyc X-HE-Tag: 1712914491-755001 X-HE-Meta: U2FsdGVkX1+fsPRrft3ii8vhzeIneWP5GgGii+KZH1Treiml93VcjWD4y7D1E4K7p/rh1BQgxAr57rJqshA0J535NP7VCEIo7kDw+cz0rVABXWDY96LhlGXsmKdTWfvmFpPpfWbqsLZsJcvhg5q4NO3Dm9CY4/5c3auMHoQVvSQHXKnfqGzH1lW8DTjFP7PGj/WLO7Kb040O9teg+ou7660NN3P4C09xNKquAupwNjIJPT/O/nHSCcOkgGXcmFKyehqUjj/m/z4AaXoXSzzCA9UOfccLQxSE6E8EEQBpF14Miy4H9J69sHuWG4dixmVRPMKId0HURfDwS5JFqQFx4I3kFihqRtPMByYY5MzfCfYJ+jWeIOxWPB2xRjFRVNhqUvpn5roRWSddWSFRxSNVxAjab+faCK5j0AhxCtRp0g9Z82vStCRhKZBSv3kaA6vMHIPt3/qqdMWHaRb5LCq4CwsqR4AZs1KFQbxQc/kpfJyc2hCK6vHBn6iXJpu0U3pvA6/S+RZhawgJ4P8ftACP8R6ZszrNX0uZ/YNLTO9zLIJU4R/CsUIf1DnC4/yvpn9ygXfSflg6syf9ryHUy5Ti/umWiAuIyv5RB9tBLMj5xsW7Zt0cQ38/x5bbB2uK7ZLEpCaCo4BDIv/0GhpNoB82K0/wui/8Nj4QrToB5cZa3fR8y/KGWOULjSOh3OX4oaHEktfiJX8W5TTQBDuZa9G+WTW/3PBKV1dZS487JPvCFsWoQw5khARWSaOLsCKAW3uKcvZ6/YBPMlZlhcU2QIThQIpOUdW5juS9TJfIKoZL3IK0PBgmNIXl8ZhxYIWPKb/AXAeomuo5sMmxqNcgaf3gXK2X+uHpyLQjqqz8vkrbkvpNdFzTgiW60O+DnmaRLX5bt3wgKjrYM3LgP/WakJSt5+6k7o2XiC3Zkm4hv5qFhQMOBnjAHFyWGdr5tbcsd3z7rHfhe6zMD1eP6JvzXN0 UF1oi/hO 5xLts4mR/dbR44ZLAgEiSzczN7nBcftguPfIxv6shDQIF246PCAwq0ptULhGRN074Ege0CRMOvvyFhbdAypLu2EtprcBaFrTOw/MXfgj7UPcBLrIct0Hm0NpNV4LKBszm9fXuS780Pj4Nmkr1LdhxcdSYCMoQDZtLtHHELmsl3HdsI0wovhNN+7nCpSW7hwCL/Lc7/DzSH0KURoX1C3+LcRHEKaA8L5pq53uALN+uaHVfFSE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/4/12 00:51, Christoph Lameter (Ampere) wrote: > On Thu, 11 Apr 2024, Haifeng Xu wrote: > >> @@ -1875,6 +1875,13 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, >>     struct slab *slab; >>     unsigned int order = oo_order(oo); >> >> +    /* >> +     * If fallback to the minimum order allocation and the order is 0, >> +     * clear the __GFP_COMP flag. >> +     */ >> +    if (order == 0) >> +        flags = flags & ~__GFP_COMP; > > > This would be better placed in allocate_slab() when the need for a > fallback to a lower order is detected after the first call to alloc_slab_page(). Yes. Thanks for your suggestion.