From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C435CC282CD for ; Mon, 3 Mar 2025 13:11:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16FD36B0083; Mon, 3 Mar 2025 08:11:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 120686B0088; Mon, 3 Mar 2025 08:11:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB4B66B0089; Mon, 3 Mar 2025 08:11:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CCDCD6B0083 for ; Mon, 3 Mar 2025 08:11:32 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7CB6C1C8332 for ; Mon, 3 Mar 2025 13:11:32 +0000 (UTC) X-FDA: 83180276424.07.F49B604 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 7D08B100012 for ; Mon, 3 Mar 2025 13:11:29 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GmeHZHt0; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741007489; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TeffH+IIjqdN23Lg7LD9KsM1FVi9MoM4HVGY13ijq0E=; b=aiEoboHrI+vVwBO6yn3iVQns7pqHbx8rF85mEpBK0DpkREgqOcCO/IKzu29KCOem/fxWHx Gdtif1rNzQ72y50q+ffKfJqcy3fb6KPp6vPqtr+GPiRrDWJxdznx+diZ9O6wUbXpuLgsNK ob3O+8Hz48YkEtbIpdKRruFb13XG1ak= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=GmeHZHt0; spf=pass (imf05.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741007489; a=rsa-sha256; cv=none; b=DfWmtqcBs1S+wxQKmzYPbvDY4QGdtSbLurCqv3IdB36ILEFTyb/yv9W1wm61g7IOLEFQGo TK3WRxeR0T1b27ZP1iYbSkZ8Y01cPm6rHQ/qYMakIVLlS5qJUb7oDLkpkimmMuOIACqbuO cly7Hf2sUEonahnKe+2qKTJZbS8sYU4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741007487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=TeffH+IIjqdN23Lg7LD9KsM1FVi9MoM4HVGY13ijq0E=; b=GmeHZHt0Zp4onj528wzZHwSC6VlCCGblyTmPjBPLFYa5kpjhDgNQoc2tuQLR+lDZ7fHhve n7S5K8KzbqU3SsohvNYf/x5m8Gum8ZwHRUMmdmBAxsMKDisMEz6YHVGZKakl4SPfYEAcWG AND0XUds2FWBFOpxql8BwzPfZi225V0= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-567-9L3QPmdTNc-pM0SOORc7og-1; Mon, 03 Mar 2025 08:11:26 -0500 X-MC-Unique: 9L3QPmdTNc-pM0SOORc7og-1 X-Mimecast-MFC-AGG-ID: 9L3QPmdTNc-pM0SOORc7og_1741007486 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-43bbfc1681eso5369695e9.0 for ; Mon, 03 Mar 2025 05:11:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741007485; x=1741612285; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=TeffH+IIjqdN23Lg7LD9KsM1FVi9MoM4HVGY13ijq0E=; b=TQDGlwWalvnWpmE55Eljqw7jSUd2D0UcELbGGaP8bCCjA3NF5Zme63XXR/jyh1usWY hkVi3z5PFS4NjS5mrdSrw0kkIWcgL6a9Vylzv8CECXbzgPO7gc95JgC3bx3KGKQjZmSZ kGbDgm8DmFNlF1vVDIOfvdeSCdq8IUfHfeoczQ0BtQHyEnov2wi9jly4fvHiYNI8e5J2 pvp+pDU3BC35CpGdcx0kWxJaiin6PAQ0qMYNCeKm1pvIjdwV5d50mJnMLVHsVykjJw2t lJJ/d+MQ87fffRfkjHQqnJ7uHsI2TccgUgV69U0b/YekdPTFnrYL8Qg/N1QuTVxxWbS+ L/hA== X-Forwarded-Encrypted: i=1; AJvYcCXeueyunnn5w1if37kUSHbkOrigBsuQs4koK6w9nf3UQ5Q7iAaTmxVFIA5kigYMGkXiYPX9Ffrd1g==@kvack.org X-Gm-Message-State: AOJu0YwLdqbmjrSC6WS/mGYDSWMcsEl5LpQ70sW9qMlTzBVuoBjeET0N o03cxj8euwJWCT0PmreoDrcVKB0qjOhNAoAqsuFanjqxnQhPuRqCgdnVDjD1nl81sw/HpllKdKL tQOf6JE92GMj78Zc6N7lXzoiIancLznBiJ6hnZuRhdGR/pAsBtAf38ZP2MM8= X-Gm-Gg: ASbGncux0LJXneGAj8Kb5wkJMbNoRj2LNzgry46XuXdlMhVtUONBapQyvE1/DTL8Qpu WZmOeOcr4RHqIN/oMEoRy+g0c+NsztpP6oPm6egIw7ChzM/gB95NlKb8/0Ol4UnQ6Z0Qq+7zu9a sOV/77/DyfYuspDWG9EkfAGAwXClT6SBSqRqfwssKTszKj5r5yd/RFGkMKyS04z8vFd85MzWb77 PNYa4ypuJ1W4F3ZaT4b9T9z70vcaHmORbe+lNUghKyrgH1qxIPbl5QaNa8tanbcXnhDxQjiIzUj XkfkM0P6Iac2Oms5BcOAtlotIU5epfbEk+2lNMCCEoHC6SXMNevqE+cYlrwMeml2ozBd48qcjFL lKlsZJgGDP+/34V7Wi3Y+mX7nBpT6r19dSTUdal4MaQ8= X-Received: by 2002:a05:600c:4693:b0:439:a1ad:6851 with SMTP id 5b1f17b1804b1-43ba675d773mr99165445e9.23.1741007485624; Mon, 03 Mar 2025 05:11:25 -0800 (PST) X-Google-Smtp-Source: AGHT+IGQn2waD1QVxCAIUjRN+u3Z0398w8FHaVuNZLkCafXSE9x3fL2sE84LW/u04OY4lOA2aM46vQ== X-Received: by 2002:a05:600c:4693:b0:439:a1ad:6851 with SMTP id 5b1f17b1804b1-43ba675d773mr99165255e9.23.1741007485284; Mon, 03 Mar 2025 05:11:25 -0800 (PST) Received: from ?IPV6:2003:cb:c734:9600:af27:4326:a216:2bfb? (p200300cbc7349600af274326a2162bfb.dip0.t-ipconnect.de. [2003:cb:c734:9600:af27:4326:a216:2bfb]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43aba5711fcsm195845315e9.28.2025.03.03.05.11.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Mar 2025 05:11:24 -0800 (PST) Message-ID: <4d0f0bca-3096-4fb4-9e8b-d4dcdf7eeb92@redhat.com> Date: Mon, 3 Mar 2025 14:11:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/page_alloc: Add lockdep assertion for pageblock type change To: Brendan Jackman , Andrew Morton , Oscar Salvador Cc: Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20250303-pageblock-lockdep-v2-1-3fc0c37e9532@google.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250303-pageblock-lockdep-v2-1-3fc0c37e9532@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: jNX-ihX_bubs8Ad7K1Ukb8BTO46-A74UhHskQQSEaXQ_1741007486 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Stat-Signature: 7geqjo9jbfrpkb3bxqwcpewh1fi1y3dm X-Rspamd-Queue-Id: 7D08B100012 X-Rspamd-Server: rspam07 X-HE-Tag: 1741007489-526574 X-HE-Meta: U2FsdGVkX1/d5qYE8DP9XBGfE4OETMpL0w7u5p9fPzbTXXFhUPzv/kOst780UlbDEon8UMD5kXHW8T4QrqqHDrQKeEYXbbKsqS8Qaj27nCh0pWyAIhfyYsY5+fxduHX1L1y/1RPxvgT/CrqFFLQprL76bN6wBhA2gregr3aOAXg4H65iOXGkMtSetzR0eh1Zaeb+ASBt5wCXBRSTCOBnwaMbI4ISqWBzdmde80WVrUOKAMDhzBybQxSXVG8mp+Dyyyw6JJE99WV/KdJx1/InoqjKxcGx5pHe9wy6tenot1+ivScotmImvWw/VCuicD9U2d7Bq2knIqt3VT9eeWZSTgYkCcMGrHtrPV5UFNVAHLhYtY1cSQ/CGj9caw7g/jjf7VgPKcR+b6LWNj3hiK6sQ4F7h2D8rA5HMdiGxg5ZCIkAqxCMi2uPVMmBrjImfUYtP/zpUGxbvjYc1ygJ6msBX+Yx+VyChZ8W5Uja7ghAPwmhosHC4Ab8m1o4c4DIuqYvRA96tXp33GhqCWbKfQgG4qM3ROjjSMr3gmX7SNq3UsXrXA//CWPKgNTt07Tilryi124vmwfW4iTv0QjtDXImPQLV45ejwhx3TekJPgQEVP/FTuS+vZbI158w7K5V6itdri71U0MKBmmpj3+BEXD0almxSx4XELfuTCUn75lzFjPvptTi8dUg1Miue1fmNKv9/sW2HNQY7Xeg9s11g0Y4m+df+oTObSYatobw28+5WGwBTXpdngvmm4UkJCj7ZTcEs14jCFYweZiS7oyeHjs9Z+w2Wv0YWt5iWwfZa7MqotWikWzuLUnclOFaqXwA/QSlHFasatC2t5yUlMQaudYEdHmtmTjFpYu7SQom4FiMkjmsTb++TOogPQ34qjuKBE+DfKRW82qbk8xtEVCBLq3UD+ThEi5LuXZW3trky5aeGByjDSLqnaOyWqnuVApZhQzfj9YlkiLgJdaEkvZy8HI hQ46Lebi wDNbHoiGqKe9mHVp15detEmy74BrBCH023N98n9fLgZqaqLf64lAETaOwV139p7cYWh9TCvCigHCZYkdu93Oh9TKPprniQaH45WaDqsjlRJqeBT9WAwJPQqzcdu5sDrwj4h3QswlK1eQoNzQ7VIeR8pdkkA0qfvENdL4kEuiMOexfHbmQ/X7Pw2qD7/uSaFHi6WvE1yupa7Cg+I0z+MFANOMmwyEmDQNIfAANg6iIq92oQm2q5eGiX9S2m2DA7RWhEMLRGVpowcWOjpWWII2jvXOEt0fyeiGEmvOsWUU7xBFx79HNV5WQGzudAcLEJ4CJOOKVRMmBFOCZq5/LKtLKiDE2MsuhnGZuSFp5WwX6Ds4LKbnSTHXN1iMb+hvETXEPiqh9INjyFs3uBH+GRTjS7RlbzJhcOvG+fr2GGmsohGPWbX8tiz9jvARMjQFPeM6EIW3h X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.03.25 13:13, Brendan Jackman wrote: > Since the migratetype hygiene patches [0], the locking here is > a bit more formalised. > > For other stuff, it's pretty obvious that it would be protected by the > zone lock. But it didn't seem totally self-evident that it should > protect the pageblock type. So it seems particularly helpful to have it > written in the code. [...] > + > u64 max_mem_size = U64_MAX; > > /* add this memory to iomem resource */ > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 579789600a3c7bfb7b0d847d51af702a9d4b139a..1ed21179676d05c66f77f9dbebf88e36bbe402e9 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -417,6 +417,10 @@ void set_pfnblock_flags_mask(struct page *page, unsigned long flags, > > void set_pageblock_migratetype(struct page *page, int migratetype) > { > + lockdep_assert_once(system_state == SYSTEM_BOOTING || > + in_mem_hotplug() || > + lockdep_is_held(&page_zone(page)->lock)); > + I assume the call chain on the memory hotplug path is mostly move_pfn_range_to_zone()->memmap_init_range()->set_pageblock_migratetype() either when onlining a memory block, or from pagemap_range() while holding the hotplug lock. But there is also the memmap_init_zone_device()->memmap_init_compound()->__init_zone_device_page()->set_pageblock_migratetype() one, called from pagemap_range() *without* holding the hotplug lock, and you assertion would be missing that. I'm not too happy about that assertion in general. -- Cheers, David / dhildenb