From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D399CC56201 for ; Tue, 24 Nov 2020 13:32:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 67F38206F9 for ; Tue, 24 Nov 2020 13:32:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 67F38206F9 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB19F6B012E; Tue, 24 Nov 2020 08:32:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D87F66B0130; Tue, 24 Nov 2020 08:32:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C50216B0131; Tue, 24 Nov 2020 08:32:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0079.hostedemail.com [216.40.44.79]) by kanga.kvack.org (Postfix) with ESMTP id B07AB6B012E for ; Tue, 24 Nov 2020 08:32:32 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 765ED180AD806 for ; Tue, 24 Nov 2020 13:32:32 +0000 (UTC) X-FDA: 77519401344.08.lip06_02015812736e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 5A2591819E76B for ; Tue, 24 Nov 2020 13:32:32 +0000 (UTC) X-HE-Tag: lip06_02015812736e X-Filterd-Recvd-Size: 3789 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Tue, 24 Nov 2020 13:32:31 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id A52D5AC66; Tue, 24 Nov 2020 13:32:30 +0000 (UTC) Subject: Re: [PATCH 38/45] block: switch partition lookup to use struct block_device To: Christoph Hellwig , Jens Axboe Cc: Tejun Heo , Josef Bacik , Konrad Rzeszutek Wilk , Mike Snitzer , Greg Kroah-Hartman , Jan Kara , Johannes Thumshirn , dm-devel@redhat.com, Richard Weinberger , Jan Kara , linux-block@vger.kernel.org, xen-devel@lists.xenproject.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20201124132751.3747337-1-hch@lst.de> <20201124132751.3747337-39-hch@lst.de> From: Coly Li Message-ID: <4cdd6877-f4fd-8022-4a4f-3eabb86af2b9@suse.de> Date: Tue, 24 Nov 2020 21:32:19 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201124132751.3747337-39-hch@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/24/20 9:27 PM, Christoph Hellwig wrote: > Use struct block_device to lookup partitions on a disk. This removes > all usage of struct hd_struct from the I/O path, and this allows removing > the percpu refcount in struct hd_struct. > > Signed-off-by: Christoph Hellwig For the bcache part, Acked-by: Coly Li > --- > block/bio.c | 4 +- > block/blk-core.c | 66 ++++++++++++++---------------- > block/blk-flush.c | 2 +- > block/blk-mq.c | 9 ++-- > block/blk-mq.h | 7 ++-- > block/blk.h | 4 +- > block/genhd.c | 56 +++++++++++++------------ > block/partitions/core.c | 7 +--- > drivers/block/drbd/drbd_receiver.c | 2 +- > drivers/block/drbd/drbd_worker.c | 2 +- > drivers/block/zram/zram_drv.c | 2 +- > drivers/md/bcache/request.c | 4 +- > drivers/md/dm.c | 4 +- > drivers/md/md.c | 4 +- > drivers/nvme/target/admin-cmd.c | 20 ++++----- > fs/ext4/super.c | 18 +++----- > fs/ext4/sysfs.c | 10 +---- > fs/f2fs/f2fs.h | 2 +- > fs/f2fs/super.c | 6 +-- > include/linux/blkdev.h | 8 ++-- > include/linux/genhd.h | 4 +- > include/linux/part_stat.h | 17 ++++---- > 22 files changed, 120 insertions(+), 138 deletions(-) [snipped] > diff --git a/drivers/md/bcache/request.c b/drivers/md/bcache/request.c > index afac8d07c1bd00..85b1f2a9b72d68 100644 > --- a/drivers/md/bcache/request.c > +++ b/drivers/md/bcache/request.c > @@ -475,7 +475,7 @@ struct search { > unsigned int read_dirty_data:1; > unsigned int cache_missed:1; > > - struct hd_struct *part; > + struct block_device *part; > unsigned long start_time; > > struct btree_op op; > @@ -1073,7 +1073,7 @@ struct detached_dev_io_private { > unsigned long start_time; > bio_end_io_t *bi_end_io; > void *bi_private; > - struct hd_struct *part; > + struct block_device *part; > }; [snipped]