From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98097C5AD49 for ; Wed, 28 May 2025 20:01:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1C5396B0083; Wed, 28 May 2025 16:01:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 175A46B0088; Wed, 28 May 2025 16:01:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 03FA16B0089; Wed, 28 May 2025 16:01:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D8DA06B0083 for ; Wed, 28 May 2025 16:01:00 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 80DABC15E1 for ; Wed, 28 May 2025 20:01:00 +0000 (UTC) X-FDA: 83493385080.13.0F63A75 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf27.hostedemail.com (Postfix) with ESMTP id 16C8C40016 for ; Wed, 28 May 2025 20:00:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QT1LqL4Z; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748462458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=93E838XESEujavn6CtgRlZj0LiotNbJUH5vfb4rXjr0=; b=B7IBWQeipETi9nDDd1GIZgLLAOWOsNBzyg4pNtuXLlo0C9RFu6f2oebxBFHCRluYJiQtYS G6lQAf0Mf77S9HTub6XE5Iarf2q8d7UVE68eCR1r5u6jp97NqtZ26ouEPQ+QN67kVLX9qV nLGyUDmmyjiH4pgu8MdrtMZtwgvOSec= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=QT1LqL4Z; spf=pass (imf27.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748462458; a=rsa-sha256; cv=none; b=wC6JkDP1+UevDZKLY+xoGT9kGT1pSJJo/TBdcHU/UixlQGnCl6OqLWrKv5zRAI23G29iG+ Lc8BzddV6pRn3Yx4HW+80ORxk8pAVAdOfjUWuABR6aYS6Il8qvzRDPhVsOnSZlqfA8aCih 0M1lVwBTpeaKnI5ki00BFPim+acosm8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748462457; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=93E838XESEujavn6CtgRlZj0LiotNbJUH5vfb4rXjr0=; b=QT1LqL4Z+tqJ7OBVvhT5WBbJFA3al2KEbwA9qwcyA8cMqUWfaO4dpOPCUO1zl1cng4mYux KJK7PUPOM/wc5vYFRcYeHTBfjHYnnduhPDjFa6z9sO1P9Bo3PZHZCJvwSFhg21B12sb1gd CuJshGKQUzt3WHT7fwlpVcW06uTmWco= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-453-z4PgLoTaMV-2hbSgPjdTKg-1; Wed, 28 May 2025 16:00:55 -0400 X-MC-Unique: z4PgLoTaMV-2hbSgPjdTKg-1 X-Mimecast-MFC-AGG-ID: z4PgLoTaMV-2hbSgPjdTKg_1748462454 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3a4ea7e46dfso43096f8f.3 for ; Wed, 28 May 2025 13:00:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748462454; x=1749067254; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=93E838XESEujavn6CtgRlZj0LiotNbJUH5vfb4rXjr0=; b=rcKkYB6jUxMuiEq+6zScLaqPcM7n97YCG5MV0q96aeNk/sPp3qmYS46rIL6ogRrGPr Y5c5NRv7151QOSbW4g7nYusM57XnKFKc8x4p20czx6j0korELYkqyvtpJsVg94Uawk7t CY3QzscYW/oXkWQZ0zPS1KO8gvMUNkdmfG3WE6IaaNN3YICQBrcSbY9lYVkFOjy7dTnB q1LiE37nA5OCnVGhdg2lqR5P/f9/oe7fe1jgmyCWeFBhkm+AUAu0BUh0eTOSEPd/RHgJ DN71Nlf4LWEV4JeGjFVw1IWdJXCkKbDvU84RssLWBidEMugQmKj9XUVVQqqPAZvMV3es UKWg== X-Forwarded-Encrypted: i=1; AJvYcCUQXp/qTbt6gA/JdfPGryT6nGwcF+WtIzcR66ihmSj3Xv7PtZdKt0PXhhjVVc4mmFF6mrVpxCnR5A==@kvack.org X-Gm-Message-State: AOJu0Ywm0ibnmHctjzGyu9nms29MVEBOIIVOEfTAzF7vTtMt1uvizhsN RkN6WTMq1fn8Yo6EqAX3buVIa4ScAO1VQZMp70A/4/t6F35yYPxZqdsykvQdcMYl2AlSKloCHq6 EvIcYjzbFUGnvwElKGEDzr8T+iJKKneCjqDlL9vvuus8zgwjKBsTz X-Gm-Gg: ASbGncvxjTG3t0SXK7qXdPKB3lb69tZqp5mqGa6pyvnZvvW3hg3tHw05OQ+ELfqrb0b 8U5tYNtCwT2zulPXdWOzN8fPjNjNHpI49K/J6EauPuMeCl20xomD+wRkucET6rrUHd/w5Sr/3f4 FAX1Rt8uWa20JxXIJD5EdeZEeiXfAWYIaMHjkybaWMFkGb4hcBpgtt0KyU6Ey1XSz+sefXV0Syc 92znPwAX6IsErAD6LjR0+nA6+9q8+/jPurcxexRI6lUYk9LnuHIdENo+z33BDcBh4gVSQhYsppS E8MZXPYjDoPqml3ziMFP/RRHjTjTfbFuFDY7NZ4MOEWc+Y5C3lAFzkEQb4w5Qayxe6+MtoEjyHE JTBwvPiP8IKTktw+hXcnM4aan+ijppA6U8kp2duU= X-Received: by 2002:a5d:5f8b:0:b0:3a0:bad4:1247 with SMTP id ffacd0b85a97d-3a4cb43214amr14077338f8f.15.1748462453918; Wed, 28 May 2025 13:00:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFBqsLwtFcwOenCmYLpxNpkEXnrA8AqUwB7ajvLJSL+i9CQyVRLcPLGZQcSU4LE00ooD3Gfig== X-Received: by 2002:a5d:5f8b:0:b0:3a0:bad4:1247 with SMTP id ffacd0b85a97d-3a4cb43214amr14077297f8f.15.1748462453524; Wed, 28 May 2025 13:00:53 -0700 (PDT) Received: from ?IPV6:2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36? (p200300d82f30ec008f7e58a4ebf06a36.dip0.t-ipconnect.de. [2003:d8:2f30:ec00:8f7e:58a4:ebf0:6a36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4eace3278sm2272546f8f.88.2025.05.28.13.00.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 May 2025 13:00:53 -0700 (PDT) Message-ID: <4cc7e0bb-f247-419d-bf6f-07dc5e88c9c1@redhat.com> Date: Wed, 28 May 2025 22:00:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm/hugetlb: fix a deadlock with pagecache_folio and hugetlb_fault_mutex_table To: Oscar Salvador Cc: Peter Xu , Gavin Guo , linux-mm@kvack.org, linux-kernel@vger.kernel.org, muchun.song@linux.dev, akpm@linux-foundation.org, mike.kravetz@oracle.com, kernel-dev@igalia.com, stable@vger.kernel.org, Hugh Dickins , Florent Revest , Gavin Shan References: <20250528023326.3499204-1-gavinguo@igalia.com> <629bb87e-c493-4069-866c-20e02c14ddcc@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: ZXepf94fdUDo3wg7hR-HG77M-f9Uda41tzgJmahDo7o_1748462454 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 16C8C40016 X-Stat-Signature: f4mhkaazff95t8zbop933ptbeq3cq1sc X-Rspam-User: X-HE-Tag: 1748462457-294130 X-HE-Meta: U2FsdGVkX19IkuJIGDZwMwNoThKpTUalaBUuj3aA8vvLsxmh1lGgEZRZ23F63KrGyy2FsFth2JNQprM8RCP65nxFHsM+R3FyIoYSyysbyc4SIDE5fFoUn1JnzI4FIg4yWUs6V5E/ah8qGTUCjQ756xYnNHl5qsoB4fMxprT8KV21PEGO1FIqnp/LSB8ro/ylr/8jUutcTguTBDdEC3Gt1Ug3DVYUy18soIt7nTlcNaTa4ZVpjucGmoIcQgVXNIy6L1AzGBstxtiwFlo5g7++hZ0dAGB/mBC7YnZMwEMsSxtVUb93cVYDLDXaMqwpK1ojtnqIg3kNrsnQeMhtIU2aAKO+hiK9b3TeJiSW1ud8xaAz4eOWkIArwBEZBOpeWoANnpO1BWl8WAZ64UA0Z+ebeT7YF7+OlTBD1efANdW0dHR+eS1hPGP61Bg7tCXDitdlbJMHEcSa3d+7E2VKWzZwxaTDNBE12mvcXNIcGwvRpmpF38BnAtZ9/PUPrIX61GtwRL/DwDtpDGpznyEvKFQRyfwkJPrkMSDtu5NTyd7mtGC2DYayFypEJmQBE2BaKi7eLnhYBy8hULtcaNxztesD0gwaFscIbFP4wZHtTpkfs6trIC1fQfvRjAQON6H4TAMo0D76OP3Nm56mUzEbHlWqINMfmGco4vy4mt0jBI8LHH0NOVnGMaTDLJ6/dyzvlncJrjnwP7aTjEcolwiePalPr3dDRllMp2/AKUjljwEZPFnLTfhVn5jHDMfTAsJnQPz90YgiQ+Y8P3VBK0dWMMMvZm7qkeJ0IZLBlLk1g0NpgzAoFxZEf49R5NqVzIJeqoi7zl+1f3jlmN5y4PJNTwCUmNnjh2JX0dT+jhc9QihjS0aA/YyYGb7eP5OjWutKsg3k7oogEtuqL1ppNMID1zxptkoCLDcD2m1ueDZ2BtQVrmyo5BSf/O9cifK4yvW48vX9f6oU/lcBQIenOmlKdw3 t/v6LmN5 829Z7MY+kTQCi6mgeGma5lPJq4aO0fduu2i/CHjMYWd+RP7GK7AX/uArTODqQztA71RzX/3momBzIIK2TcLY/4xh+ZtDXRWENBDgD9KNz+YPBCMLW0I6zQa41eYieWk2VXBjpRdUhyzBBumeMZzuAevruwE1hVu4qf/4/3nXsDV2FrdVybO+oKzZGqVZwh6e5VU8/nHmcnK+Uat3M/xC6hCBKj2k6291cFSi1ZWbW+rnYDccHLUawdyt+uuim68AxjWTLtsOboc9h0h6e1hYs/L3J9T94ndIc5Y40AVOmjMVHZ/gIqojl42IJNPPZzAI4BQtgyDSOrp4BJezZCGbYw5jpbH7Vvy7ugbePL+w2DMi4W8BrR8gGyfsZvkaJb1q/OUQ+Hctt/ivhErqwWSNbciKqK5daiQBhaX0zEMre2RcYFvCilBaylDvKXZ6UBkojKBtbA7xuee0uDzs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 28.05.25 17:45, Oscar Salvador wrote: > On Wed, May 28, 2025 at 05:09:26PM +0200, David Hildenbrand wrote: >> On 28.05.25 17:03, Peter Xu wrote: >>> So I'm not 100% sure we need the folio lock even for copy; IIUC a refcount >>> would be enough? >> >> The introducing patches seem to talk about blocking concurrent migration / >> rmap walks. > > I thought the main reason was because PageLock protects us against writes, > so when copying (in case of copying the underlying file), we want the > file to be stable throughout the copy? Well, we don't do the same for ordinary pages, why should we do for hugetlb? See wp_page_copy(). If you have a MAP_PRIVATE mapping of a file and modify the pagecache pages concurrently (write to another MAP_SHARED mapping, write() ...), there are no guarantees about one observing any specific page state. At least not that I am aware of ;) > >> Maybe also concurrent fallocate(PUNCH_HOLE) is a problem regarding >> reservations? Not sure ... > > fallocate()->hugetlb_vmdelete_list() tries to grab the vma in write-mode, > and hugetlb_wp() grabs the lock in read-mode, so we should be covered? Yeah, maybe that's the case nowadays. Maybe it wasn't in the past ... > > Also, hugetlbfs_punch_hole()->remove_inode_hugepages() will try to grab the mutex. > > The only fishy thing I see is hugetlbfs_zero_partial_page(). > > But that is for old_page, and as I said, I thought main reason was to > protect us against writes during the copy. See above, I really wouldn't understand why that is required. > >> For 2) I am also not sure if we need need the pagecache folio locked; I >> doubt it ... but this code is not the easiest to follow. > > I have been staring at that code and thinking about potential scenarios > for a few days now, and I cannot convice myself that we need > pagecache_folio's lock when pagecache_folio != old_folio because as a > matter of fact I cannot think of anything it protects us against. > > I plan to rework this in a more sane way, or at least less offusctaed, and then > Galvin can fire his syzkaller to check whether we are good. > -- Cheers, David / dhildenb