From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A9D6C433FE for ; Wed, 12 Jan 2022 09:22:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE6806B0130; Wed, 12 Jan 2022 04:22:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D94F66B0131; Wed, 12 Jan 2022 04:22:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C844C6B0132; Wed, 12 Jan 2022 04:22:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id B84946B0130 for ; Wed, 12 Jan 2022 04:22:05 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 63B008249980 for ; Wed, 12 Jan 2022 09:22:05 +0000 (UTC) X-FDA: 79021093410.07.86A7BF0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id 092D140008 for ; Wed, 12 Jan 2022 09:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641979324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZkMJP6Kct1rran15fCHGX0wTP5ePzlWHQDky7Omxb9c=; b=WSkcuCbpKr2Yq92XTW/iizhDEQzxNgSJdoLgS3Zh9CgzLH2004vsUKE4lb8Xn+Yga6RnXE Puz20qff351aq+tLhWSORkMPLCILWbjFR7t/J5dSCD5Uc5kWM5uncwrvVMqwOAiBDl5P+q qGuDzfLFX8KXexnJkQihP0XuX9zrkhw= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-663-PZxbLgqIOaa6CKbCzsOxTA-1; Wed, 12 Jan 2022 04:22:03 -0500 X-MC-Unique: PZxbLgqIOaa6CKbCzsOxTA-1 Received: by mail-ed1-f71.google.com with SMTP id h1-20020aa7cdc1000000b0040042dd2fe4so440714edw.17 for ; Wed, 12 Jan 2022 01:22:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:organization:in-reply-to :content-transfer-encoding; bh=ZkMJP6Kct1rran15fCHGX0wTP5ePzlWHQDky7Omxb9c=; b=o3Jj7encRZq4lnLOxCphTSx2dZWTwVGYw9SX/os6sGIcF/RnhLWfqXsH6q55M023I5 yXhxvQD3ayOnFk9l+XDt4hn3jrM/GqCLAMP2H15OkmuRs9MDwYZmZshNY30oKg1HCYjf ZfWvRCUDAo7dQYU1k+xH6Md/mT64LxZOiO+6NLlcYiJ1/QtI/MU4meIoFSu5Iefv0Me/ 5UOjG71KD5acoAsIsjSB2+tMRbqbFzbgCyI/vaLTcJ2qIaqGZZmPU40Mwu32pHOEv9Fk djHrt+NIC3yHcfOncVuUNoJpS8UQppaqbx5MCjMpEEqfpaEf+BcFU9O5L3sJODOOq40a Alhg== X-Gm-Message-State: AOAM531l0roAdFN85TDedKXTCOTJqbkOrZRIQa2PCn4IrJBwXYiUJZIM wkowuHIKNXByXU3x+cyACgEJ7mWv6pK/Y5ULZVYVWAQAXV+ZUzp5ZP04z+bQ45lVsZsE/7jd5Hq 3IgXCtkr5Mx8= X-Received: by 2002:a17:906:9754:: with SMTP id o20mr5550565ejy.452.1641979322222; Wed, 12 Jan 2022 01:22:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyPDWe8+Rv8mGKTnrR5wrymtNU5ulfIG8wkZ/6tOwfne+hNzNx7U1tUD1XD7lB+6xV4pw95CA== X-Received: by 2002:a17:906:9754:: with SMTP id o20mr5550550ejy.452.1641979321997; Wed, 12 Jan 2022 01:22:01 -0800 (PST) Received: from ?IPV6:2003:cb:c702:4700:e25f:39eb:3cb8:1dec? (p200300cbc7024700e25f39eb3cb81dec.dip0.t-ipconnect.de. [2003:cb:c702:4700:e25f:39eb:3cb8:1dec]) by smtp.gmail.com with ESMTPSA id d24sm4286245ejd.182.2022.01.12.01.22.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jan 2022 01:22:01 -0800 (PST) Message-ID: <4cbe2f51-0654-dcfa-cd9c-1b5096cc5394@redhat.com> Date: Wed, 12 Jan 2022 10:22:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.4.0 Subject: Re: [PATCH 2/2] Fix assgining cma_area_count To: Ercan Ersoy , linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, akpm@linux-foundation.org References: <775ae3ba4f7034a78769559fa1a3542a@ercanersoy.net> From: David Hildenbrand Organization: Red Hat In-Reply-To: <775ae3ba4f7034a78769559fa1a3542a@ercanersoy.net> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=WSkcuCbp; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf12.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.129.124) smtp.mailfrom=david@redhat.com X-Stat-Signature: z4qardm699is9eyhmaew5gyqaibjbp3d X-Rspamd-Queue-Id: 092D140008 X-Rspamd-Server: rspam12 X-HE-Tag: 1641979324-122733 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 09.01.22 08:39, Ercan Ersoy wrote: > > I have patched "Contiguous Memory Allocator" of Linux kernel. > > This fix of patch is for cma_init_reserved_mem function in > mm/cma.c source file as creating area without specific name. > > Without fix may be a problem a lot of cma as next cma2147483647 naming. > Without fix may be a problem huge memory systems. > > I think after "cma2147483647" naming is "cma-2147483648". > > Thanks for interesting, > Ercan > > --- START PATCH --- > From 5d3d01a3a0f7339617d1df945c0bd0ec1ab91ae3 Mon Sep 17 00:00:00 2001 > From: Ercan Ersoy > Date: Sun, 9 Jan 2022 10:01:14 +0300 > Subject: [PATCH 2/2] Fix assgining cma_area_count > > Fix assigning to cma->name in cma_init_reserved_mem function > in mm/cma.c source file. > Honestly, how on earth are we supposed to have that many CMA areas? It's limited by MAX_CMA_AREAS, which is usually ... 7 or 19. Calling this a fix is a bit though. This is a cleanup we might not care too much about. > Signed-off-by: Ercan Ersoy > --- > mm/cma.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index bc9ca8f3c487..03f01d1f1b57 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -199,7 +199,7 @@ int __init cma_init_reserved_mem(phys_addr_t base, > phys_addr_t size, > if (name) > snprintf(cma->name, CMA_MAX_NAME, name); > else > - snprintf(cma->name, CMA_MAX_NAME, "cma%d\n", cma_area_count); > + snprintf(cma->name, CMA_MAX_NAME, "cma%u\n", cma_area_count); > > cma->base_pfn = PFN_DOWN(base); > cma->count = size >> PAGE_SHIFT; -- Thanks, David / dhildenb