From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67192C61D85 for ; Fri, 24 Nov 2023 03:08:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E31B8D005E; Thu, 23 Nov 2023 22:08:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9926C8D0002; Thu, 23 Nov 2023 22:08:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 85A228D005E; Thu, 23 Nov 2023 22:08:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 76E1C8D0002 for ; Thu, 23 Nov 2023 22:08:21 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 48637A159A for ; Fri, 24 Nov 2023 03:08:21 +0000 (UTC) X-FDA: 81491364402.07.E3B7DB2 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf06.hostedemail.com (Postfix) with ESMTP id 8EF3A180011 for ; Fri, 24 Nov 2023 03:08:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=hZ0xqvxW; spf=pass (imf06.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700795299; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Of6E7DUYOHQDJJkmAD9imFrmBVxslEORWEoCGdZehnU=; b=HaCNnOcd7Min+yCdMb08VPXcQeP56kWoU4jaUkDxiy2dYuLjPb9W2m9XAtBsuEm4bn4035 q5aq0ILn2VDtaB9AIX7OCQLkNVH3/dT5hATKOiDbu76G4Yh5SETE2uGl1ykGje0PaCT4X0 wqcRtr8U8APzrgsqKMWch+O23ueJLWQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700795299; a=rsa-sha256; cv=none; b=SpBJKgMlqxxPD1IcGG6m+D3AjmExJCewQ0eQXr8YQ/HIWCrxz6eRG+T8TI0cvqCR2bPw97 eBs2OguJrrhJMGZePnE/1f2lLvMi2daMloGYjMv1zxMr2kCAlKEIZqiRD3gVAdzYsc8lT+ s4gC3JBWWU/oehqVf1zAmzUSHK9Yxx0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=hZ0xqvxW; spf=pass (imf06.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1cf88973da5so3227105ad.0 for ; Thu, 23 Nov 2023 19:08:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1700795297; x=1701400097; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Of6E7DUYOHQDJJkmAD9imFrmBVxslEORWEoCGdZehnU=; b=hZ0xqvxWHREo26c3KC5iis5PtSkF3dwKq04jJ576ylWD2e80yDv2tP3SfdUPI1cUte 7HvxAfGHg/YEwH0VlvL9/9D6p3kZwMZ0EEAnmZnIJsdZTpibFnvGKGJEKvnJBFME24j0 0pza/V+yP53+nvm99McBlr3i39eGFFmF9QDW8aqb+8cz7iDrP8SK4JIId78BVwMYy50K FfHbIQL3ibdw9+oyWvBoba2XVet+bEbNpU+JyCiAT80GJ4zYrpf4MRB+UGRkKgsz/WTM OooXI41DWSn0DorjsKwTT5zkEWdEanyY9t4tH6RAC3Zb9bLDkLFXPvBl0VO5dAlZnZB0 oLOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700795297; x=1701400097; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Of6E7DUYOHQDJJkmAD9imFrmBVxslEORWEoCGdZehnU=; b=Yo82WyN8V3ysPDAbCSyPjH39kDK+XflVWhHDqlb3oY8pPjjfKHdlmvgaa+Q3AiPhC/ /i+Y5gNlP6mDtvzpLfi/aerovHyz6yfmnoFDmk4yWBoxBc+MuqGtEFt2NeVo/S3SH0SV EMGMFEdT4Yh6XgCtL8jgtFlxYkF5o4j3P7msX2h1uTJbYTHYJFMM4SZay6ZN4c3crpxh I9xmSYUqCsiZmxFXqVY+8ZxculoOvH96ovuocuJXnO1fTzV3x/fMLmZOmh/ehbbOX1lS 6G/aXzBIxEyFnaxu9gIpKoGpLcoELvHrgd42VU5SiVpc21uxqzM315/mmvPkJZBAGqge MhBw== X-Gm-Message-State: AOJu0YxTuTM+fzzq06w03VbNFtmMzGTWciMN2jWkXOvhGECzU7XIMs09 n55/xmWl0STtGFSPPTsysJjEEQ== X-Google-Smtp-Source: AGHT+IEx+FidCfta6MJRPBWFmlQ7eGWZ+QXFWJzCNwBSRnDUgk0mWX1laAdNUMh/DE/9iYO2kIpTwQ== X-Received: by 2002:a05:6a20:5499:b0:14e:2c56:7b02 with SMTP id i25-20020a056a20549900b0014e2c567b02mr2100530pzk.0.1700795297115; Thu, 23 Nov 2023 19:08:17 -0800 (PST) Received: from [10.84.152.29] ([203.208.167.146]) by smtp.gmail.com with ESMTPSA id jk2-20020a170903330200b001cf68e1c5a1sm2094203plb.4.2023.11.23.19.08.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Nov 2023 19:08:16 -0800 (PST) Message-ID: <4caadff7-1df0-45cc-9d43-e616f9e4ddb3@bytedance.com> Date: Fri, 24 Nov 2023 11:08:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/7] mm: shrinker: Add a .to_text() method for shrinkers Content-Language: en-US To: Kent Overstreet Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Qi Zheng , Roman Gushchin , Dave Chinner References: <20231122232515.177833-1-kent.overstreet@linux.dev> <20231122232515.177833-3-kent.overstreet@linux.dev> <20231123212411.s6r5ekvkklvhwfra@moria.home.lan> From: Qi Zheng In-Reply-To: <20231123212411.s6r5ekvkklvhwfra@moria.home.lan> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8EF3A180011 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 6p1ezforcgkcbr37c6u64kzwpersb5mh X-HE-Tag: 1700795298-100590 X-HE-Meta: U2FsdGVkX1+AngeJBEoyCf5+wgTsIHQpK4AZc3SvuShnS8GWL0uf4U8T9nLjp9aTFSToW5wMWd9lJgcOgqszBwIrgZEiQbZ0+RHTFsw+KgjlZiDZC6nCCGzSHwKpOyHXnj0+XCgC9lv51DcSnyDPsPxNgqycEsLIT1n+V+qTz3jbQzWghc7gW8IdSi7CsPiRfhj/U/OoC+RyKHaAsOcxWDVJxhIuxBUKmRwG6bbluM0fCBRiHLXD8OENVlosILqI/2o4vu4EzK3D+tT7xcyAzsv+gTjbMLpNz7J1Z2xMluHbWndnKgW3PIIXda5IPyaow9mMYyMqjEoaHtuFw/9sE9GqHSMcRm23rEvz9Nu+FMzShaHdA0KS43EL/UQTbe1iizJVununa+SEbscBCnCx1P0q7Ym7Gj7udbviMumtaJvt8gDRyhFPY0vF8LDNkJ8iYr7WApVT1RANcRZgSoVh9E6VDxw0PTEfWLNY1lQQk8D2AqW7Whzau6if27w6BzH3GaEflAXBlOBX+qL2Ti0lXzbvyALmgH77VHIc5gE53bVXrMixTGK78jNrmt6HxBMZW/mvtqpzoCH84xdXumHEY+IbVl8oWIbtySarh0zvQLe/fEmzhxvYYbqJ7tCGdja7HfwHenyEFp+jejqhzr4Q6NmG8lgm79L0zdiz2Qlc/KyTdNPMDl7K09uw+HPt0lGEmSB7gUZJe4bZrndrcp3UKV6zSnJEUnKxxftwRO6U9F0xmJBab1+Bryynw61xhiPmJX9jkCVtZUhXwQ94nM7ecNvgX1VYyhsIxk7anlwhCK5fDGN2KMW9KNMRd4cQTMw/3dJZLFr0GyfSdiIb4f7eOHL7Kk7wnLkkmv1QLKc6DLPYbqq4/QRYmHJk+I6kZLgpXSsim4w8TCONNDdm9gkMid86F4jVtpWFM7L3W+7VzjRPlP0i6N7dm6TAjc0+CBsTC3lUwJhDJixw5VKDymo cM3sCM9F o6hotskX8Ho9sxPUBLHzcd7R/c6GIPlNPGLgBysTenwTu+ECDlxCfYALVqCMkvH8AL9SaqEw1O2FDuV7Kt7n9LXNAtw6UlkTjTbmy9XLGv6+16TzGbQUtbnRZ0NqiR1EMcH5HyQfWJ75tMa2z1zEpnOWx7E5DG5eOFotWuBMuWo71FsjVtn7dFxAaVhwGswN9L4NxZLfJncts2UccEvTBGXxVtpvQPYvJ1WdaOuB6PJyD+HqR/8D5Kb2dKewKwfg1Js8pIh8yC03RLzbO64tPCsPHEbJ2n/9Oe4HDrFQvLhHCm6p108FjQxiCTWShZ7QKNuxG1pTDIrxmMDjb7Qz3xDS2ZF0EUMmizqwLJO73j6OnI9cCUYkukM1FIrbJTLZrrMWCHQYc06QpFo3rchI3+Z9acoXTooKFS712JXY3/APDiv/UqELhnaBGgC3SM3l9TmHkB/9NE4C/UOY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kent, On 2023/11/24 05:24, Kent Overstreet wrote: > On Thu, Nov 23, 2023 at 11:32:59AM +0800, Qi Zheng wrote: >>> + void (*to_text)(struct seq_buf *, struct shrinker *); >> >> The "to_text" looks a little strange, how about naming it >> "stat_objects"? > > The convention I've been using heavily in bcachefs is > typename_to_text(), or type.to_text(), for debug reports. The OK. > consistency is nice. However, this is inconsistent with the name style of other shrinker callbacks. Please use the "objects" suffix. As for bcachefs's own callback function, you can use typename_to_text() to ensure consistency. Thanks, Qi > >> >>> long batch; /* reclaim batch size, 0 = default */ >>> int seeks; /* seeks to recreate an obj */ >>> @@ -110,7 +114,6 @@ struct shrinker { >>> #endif >>> #ifdef CONFIG_SHRINKER_DEBUG >>> int debugfs_id; >>> - const char *name; >> >> The name will only be allocated memory when the CONFIG_SHRINKER_DEBUG is >> enabled, otherwise its value is NULL. So you can't move it out and use >> it while CONFIG_SHRINKER_DEBUG is disabled. > > Good catch > >>> +void shrinkers_to_text(struct seq_buf *out) >>> +{ >>> + struct shrinker *shrinker; >>> + struct shrinker_by_mem { >>> + struct shrinker *shrinker; >>> + unsigned long mem; >> >> The "mem" also looks a little strange, how about naming it >> "freeable"? > > The type is just used in this one function, but sure. > >> >>> + } shrinkers_by_mem[10]; >>> + int i, nr = 0; >>> + >>> + if (!mutex_trylock(&shrinker_mutex)) { >>> + seq_buf_puts(out, "(couldn't take shrinker lock)"); >>> + return; >>> + } >> >> We now have lockless method (RCU + refcount) to iterate shrinker_list, >> please refer to shrink_slab(). > > Will do!