From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81411C4332F for ; Wed, 1 Nov 2023 22:28:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 077368D0068; Wed, 1 Nov 2023 18:28:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0273F8D0050; Wed, 1 Nov 2023 18:28:44 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE25F8D0068; Wed, 1 Nov 2023 18:28:44 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CEAD68D0050 for ; Wed, 1 Nov 2023 18:28:44 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 9A3D0140D32 for ; Wed, 1 Nov 2023 22:28:44 +0000 (UTC) X-FDA: 81410826168.01.2D3751C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 5D57910000A for ; Wed, 1 Nov 2023 22:28:42 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bY3k3LvR; spf=pass (imf05.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698877722; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nWC5vyDZZRfa5huOPZv7psvbbvGG3qdcqN7MjpARvfI=; b=YhAzDLOeH2K5XiP50QoPz+jO5Ec1E7mI/LtFnASM1mhGFvlTAmKify0vhvHHzbxv16bYNv 27LZNnLuVIXew2IFYPjex16KH4zQRVSpyIKQYFAW98zlyzDhp+3MEPvuhwU1hLQHUZlwWe gKrq2kDlpQucOY/zqPYbQ6wVjuxy8iI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698877722; a=rsa-sha256; cv=none; b=at3SIFnYmRgkNmU/X2P2kZ4H/CnFKO72zkYMl3cP5kWHWT6kvnls0PPwtRhQd4nF6VfnbX fvRHjHFkha0li/Lo+aeSAGMmKXV3IraqaGvpeVJCTihDO4E0nzlKSrCAWQQkMwBzs8JG/p 30i9/eumBpEG1b4LS+TMiMhIu1UpmZA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=bY3k3LvR; spf=pass (imf05.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698877721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=nWC5vyDZZRfa5huOPZv7psvbbvGG3qdcqN7MjpARvfI=; b=bY3k3LvR9XprE9zOljB3AsTXrLDBFFrEFolnFnBDCCEAlMYXoAsS4ISfHqbqLoklNLp6Bv 6aqgddal5IpyYyA2rz9LGdvETz0AYZveWPgkk64GCTIZ4GSCIJ9lBElShRVFL6nTmBZYZd VbKmlXlRGVSqDu/rKLo1n8iAHP9u/84= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-328-Hs5dvgYHMqifC8ft4y6E5g-1; Wed, 01 Nov 2023 18:28:36 -0400 X-MC-Unique: Hs5dvgYHMqifC8ft4y6E5g-1 Received: by mail-ed1-f71.google.com with SMTP id 4fb4d7f45d1cf-5400c8c6392so165863a12.1 for ; Wed, 01 Nov 2023 15:28:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698877715; x=1699482515; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nWC5vyDZZRfa5huOPZv7psvbbvGG3qdcqN7MjpARvfI=; b=S4HcPgPzgLb+XZMsGDjbYa/f1c3fc7zdaqUJt+dB8rPYCc1u22BFhMbzhaAjnvyde3 dLzPmkZaYc/Qv/k80sJ7OWObACcpF2zKI41vPmZZLIVJj/GnyxlAsvqWyayQbT7ZLBvv GW5V46s6n76CQWZ1PtUZw9hsjfVrPh/yHVqqUphnH0C6Sb4yej5Jy0uZNJUvR9smJZZT KB3DJqeZCJP2IDJ74SfB4RItSN/mcfuoeeZqK0xlkX2+H/0ryhsDWFAKutuxmiNeGm/i p5b1QEMW+VUOdHnEhw6TEAUZu40Eeq/HVz9NErIdlUjHOpv1hy2QBhCArwgsJ6/0NK+1 C5Aw== X-Gm-Message-State: AOJu0Yw3nqd/9ryX1wRp6T4OXkJt1vGrDK1VH3aaMkDnGTEVlnQLrjZB qjXZJU7G05nMRMDKtvDrTSGMT2J3QmAS9a6HJq8xfydyu8qMfXijSTxx491odJBDIKgI4HEu64b bra9i+ZCePNI= X-Received: by 2002:aa7:dac2:0:b0:540:4b90:3dc3 with SMTP id x2-20020aa7dac2000000b005404b903dc3mr13507176eds.14.1698877715780; Wed, 01 Nov 2023 15:28:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHQeYpmPh8eDzZeeE/D17VFu8urIkjQexsUbHAFpvk7XP85/AM4Q5J3oaEYd6kGtsKyUN2H2Q== X-Received: by 2002:aa7:dac2:0:b0:540:4b90:3dc3 with SMTP id x2-20020aa7dac2000000b005404b903dc3mr13507163eds.14.1698877715440; Wed, 01 Nov 2023 15:28:35 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:63a7:c72e:ea0e:6045? ([2001:b07:6468:f312:63a7:c72e:ea0e:6045]) by smtp.googlemail.com with ESMTPSA id z5-20020a509e05000000b0052e1783ab25sm1584481ede.70.2023.11.01.15.28.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Nov 2023 15:28:34 -0700 (PDT) Message-ID: <4ca2253d-276f-43c5-8e9f-0ded5d5b2779@redhat.com> Date: Wed, 1 Nov 2023 23:28:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v13 17/35] KVM: Add transparent hugepage support for dedicated guest memory To: Sean Christopherson Cc: Xiaoyao Li , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , Anish Moorthy , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8?= =?UTF-8?Q?n?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" References: <20231027182217.3615211-1-seanjc@google.com> <20231027182217.3615211-18-seanjc@google.com> <7c0844d8-6f97-4904-a140-abeabeb552c1@intel.com> <92ba7ddd-2bc8-4a8d-bd67-d6614b21914f@intel.com> From: Paolo Bonzini Autocrypt: addr=pbonzini@redhat.com; keydata= xsEhBFRCcBIBDqDGsz4K0zZun3jh+U6Z9wNGLKQ0kSFyjN38gMqU1SfP+TUNQepFHb/Gc0E2 CxXPkIBTvYY+ZPkoTh5xF9oS1jqI8iRLzouzF8yXs3QjQIZ2SfuCxSVwlV65jotcjD2FTN04 hVopm9llFijNZpVIOGUTqzM4U55sdsCcZUluWM6x4HSOdw5F5Utxfp1wOjD/v92Lrax0hjiX DResHSt48q+8FrZzY+AUbkUS+Jm34qjswdrgsC5uxeVcLkBgWLmov2kMaMROT0YmFY6A3m1S P/kXmHDXxhe23gKb3dgwxUTpENDBGcfEzrzilWueOeUWiOcWuFOed/C3SyijBx3Av/lbCsHU Vx6pMycNTdzU1BuAroB+Y3mNEuW56Yd44jlInzG2UOwt9XjjdKkJZ1g0P9dwptwLEgTEd3Fo UdhAQyRXGYO8oROiuh+RZ1lXp6AQ4ZjoyH8WLfTLf5g1EKCTc4C1sy1vQSdzIRu3rBIjAvnC tGZADei1IExLqB3uzXKzZ1BZ+Z8hnt2og9hb7H0y8diYfEk2w3R7wEr+Ehk5NQsT2MPI2QBd wEv1/Aj1DgUHZAHzG1QN9S8wNWQ6K9DqHZTBnI1hUlkp22zCSHK/6FwUCuYp1zcAEQEAAc0j UGFvbG8gQm9uemluaSA8cGJvbnppbmlAcmVkaGF0LmNvbT7CwU0EEwECACMFAlRCcBICGwMH CwkIBwMCAQYVCAIJCgsEFgIDAQIeAQIXgAAKCRB+FRAMzTZpsbceDp9IIN6BIA0Ol7MoB15E 11kRz/ewzryFY54tQlMnd4xxfH8MTQ/mm9I482YoSwPMdcWFAKnUX6Yo30tbLiNB8hzaHeRj jx12K+ptqYbg+cevgOtbLAlL9kNgLLcsGqC2829jBCUTVeMSZDrzS97ole/YEez2qFpPnTV0 VrRWClWVfYh+JfzpXmgyhbkuwUxNFk421s4Ajp3d8nPPFUGgBG5HOxzkAm7xb1cjAuJ+oi/K CHfkuN+fLZl/u3E/fw7vvOESApLU5o0icVXeakfSz0LsygEnekDbxPnE5af/9FEkXJD5EoYG SEahaEtgNrR4qsyxyAGYgZlS70vkSSYJ+iT2rrwEiDlo31MzRo6Ba2FfHBSJ7lcYdPT7bbk9 AO3hlNMhNdUhoQv7M5HsnqZ6unvSHOKmReNaS9egAGdRN0/GPDWr9wroyJ65ZNQsHl9nXBqE AukZNr5oJO5vxrYiAuuTSd6UI/xFkjtkzltG3mw5ao2bBpk/V/YuePrJsnPFHG7NhizrxttB nTuOSCMo45pfHQ+XYd5K1+Cv/NzZFNWscm5htJ0HznY+oOsZvHTyGz3v91pn51dkRYN0otqr bQ4tlFFuVjArBZcapSIe6NV8C4cEiSTOwE0EVEJx7gEIAMeHcVzuv2bp9HlWDp6+RkZe+vtl KwAHplb/WH59j2wyG8V6i33+6MlSSJMOFnYUCCL77bucx9uImI5nX24PIlqT+zasVEEVGSRF m8dgkcJDB7Tps0IkNrUi4yof3B3shR+vMY3i3Ip0e41zKx0CvlAhMOo6otaHmcxr35sWq1Jk tLkbn3wG+fPQCVudJJECvVQ//UAthSSEklA50QtD2sBkmQ14ZryEyTHQ+E42K3j2IUmOLriF dNr9NvE1QGmGyIcbw2NIVEBOK/GWxkS5+dmxM2iD4Jdaf2nSn3jlHjEXoPwpMs0KZsgdU0pP JQzMUMwmB1wM8JxovFlPYrhNT9MAEQEAAcLBMwQYAQIACQUCVEJx7gIbDAAKCRB+FRAMzTZp sadRDqCctLmYICZu4GSnie4lKXl+HqlLanpVMOoFNnWs9oRP47MbE2wv8OaYh5pNR9VVgyhD OG0AU7oidG36OeUlrFDTfnPYYSF/mPCxHttosyt8O5kabxnIPv2URuAxDByz+iVbL+RjKaGM GDph56ZTswlx75nZVtIukqzLAQ5fa8OALSGum0cFi4ptZUOhDNz1onz61klD6z3MODi0sBZN Aj6guB2L/+2ZwElZEeRBERRd/uommlYuToAXfNRdUwrwl9gRMiA0WSyTb190zneRRDfpSK5d usXnM/O+kr3Dm+Ui+UioPf6wgbn3T0o6I5BhVhs4h4hWmIW7iNhPjX1iybXfmb1gAFfjtHfL xRUr64svXpyfJMScIQtBAm0ihWPltXkyITA92ngCmPdHa6M1hMh4RDX+Jf1fiWubzp1voAg0 JBrdmNZSQDz0iKmSrx8xkoXYfA3bgtFN8WJH2xgFL28XnqY4M6dLhJwV3z08tPSRqYFm4NMP dRsn0/7oymhneL8RthIvjDDQ5ktUjMe8LtHr70OZE/TT88qvEdhiIVUogHdo4qBrk41+gGQh b906Dudw5YhTJFU3nC6bbF2nrLlB4C/XSiH76ZvqzV0Z/cAMBo5NF/w= In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 5D57910000A X-Rspam-User: X-Stat-Signature: yy7f4a7qxeryrhxqgesbsfhbdjwe1eer X-Rspamd-Server: rspam03 X-HE-Tag: 1698877722-805031 X-HE-Meta: U2FsdGVkX1+NL6bB41rtR3rE++D2iTRcrsLPrhK3heX+IMc5eIhMKQeodKUhsQHujZdv41DvtLMzvSeW6XuPOeYSGbM+22Er9rgnI/G1V5v3lPpThXsH2NaN7OVEyJD17No/6FoiFh+dK09iuyh+tB8wv2X/1N8H6KmCDCwvxNzRiLi8OX87kHnFWeFRrTy2LQO3jnbNudzU5HZR42t86wioc4gQ9XjKDlFri8DF+LVArnP8g1CjyilA/1NMaGs5ea/eMjcYdovZB0f7SODOpKZ9K24RcvRs9kueRCoi0ndoWjE/ICaubxodA3/RsUxqW6KKWo0gIyIVdIh9OebXsTvbWgANDrslumz9v7daE5CWyc4nUCyGT02cIn7gnGTwRdMtegfme36I4S/WtKGcEfL7ZpZ1XW+VEo3cXJveuJ+BzWn/Tx8pEiK4RI5v980UIgpBD6cOIAnQhe/tuyMrbk0/3q4xFbIlo70ftGN/QgsGXj6KILAO5JjKx2NqcfWvr8YqbKEwnMGcJBCZklEYhnLASJIV76ZxBGc2W7ajBh8E0oLp9FLpNVaiC0zRj44aqt72XfDqHeEj/s1MeTltxgLcKGNPm91aKcVQ9GLcwWdeSp89Fy0xSyIUaBimrrV8TE1Eq3D06sqE7cdPT4xehjMLMLsKMgpUWKloK4IYtD3PnTxu3SC+/cF8HINRnKoKrGixnP5e1qGdNSo0J088XgzflYLMIeV9IlV3hMo5+kb7fzV5lRaYocrTGhb8qyntlavzMw3npP04s+16EAmQPTW+IPEqi/ojmsb2+GNTCsqF40mWz8gt0vdzu+0tE1hg15shT4NcUtqRLcm+kenxTxIVoiYYYaso4L1G5u1AKyLpfhzt6kybbDHHk6u2wzIujefQjmhZvoZi76jo8nc6UwWmSpHcMWsaD/yrmefB/SOnuU/vDkMXJ9vgm6biXgoMAdpzPV8Ht1UJN3150Sz jYncVqh5 tfgq2HI5SwiKsDUl7MKBxDXlu+KNDtg21TQ8ZO0uNBt1DK1mI/uKkWQfCQgDRe3r3TMq9LHt+uGoT4Au1AjjsIGwpcXyLbyPFezxJ7bZKQzH8C8JwV6jgc3R4w3va4LXaofhdZ3y7eFmSXirozPYoWow5caJfQVqLhoskNYtPc4avkV5RTo/JoancNLb+uelQCqvLxJyVevUsZH/JKb5EmJn7OqtJ6LYKWVy1o5bqTQDnULrOvA5B2uN3cDHjNLsf0GhOItFdplEbEBNF7nUvzWlu/ZrJLaOFy1IIHayZShzzMm+sltfaLldyRTnGdN58NIO7u2De6lUE80pngd+FLfVudBmPVCMYQQ84z9t5W2vvXUK/Gbkl9LPqVAmqcuSIpBMXnMbLJM89bYZcyVkMxscNw1JOj7zcaijpsCxxI27J7I8rRSihujTlfSs8A8mpYolcQk9BY296FeE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11/1/23 17:36, Sean Christopherson wrote: >>> "Allow" isn't perfect, e.g. I would much prefer a straight KVM_GUEST_MEMFD_USE_HUGEPAGES >>> or KVM_GUEST_MEMFD_HUGEPAGES flag, but I wanted the name to convey that KVM doesn't >>> (yet) guarantee hugepages. I.e. KVM_GUEST_MEMFD_ALLOW_HUGEPAGE is stronger than >>> a hint, but weaker than a requirement. And if/when KVM supports a dedicated memory >>> pool of some kind, then we can add KVM_GUEST_MEMFD_REQUIRE_HUGEPAGE. >> I think that the current patch is fine, but I will adjust it to always >> allow the flag, and to make the size check even if !CONFIG_TRANSPARENT_HUGEPAGE. >> If hugepages are not guaranteed, and (theoretically) you could have no >> hugepage at all in the result, it's okay to get this result even if THP is not >> available in the kernel. > Can you post a fixup patch? It's not clear to me exactly what behavior you intend > to end up with. Sure, just this: diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index 7d1a33c2ad42..34fd070e03d9 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -430,10 +430,7 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) { loff_t size = args->size; u64 flags = args->flags; - u64 valid_flags = 0; - - if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) - valid_flags |= KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; + u64 valid_flags = KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; if (flags & ~valid_flags) return -EINVAL; @@ -441,11 +438,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) if (size < 0 || !PAGE_ALIGNED(size)) return -EINVAL; -#ifdef CONFIG_TRANSPARENT_HUGEPAGE if ((flags & KVM_GUEST_MEMFD_ALLOW_HUGEPAGE) && !IS_ALIGNED(size, HPAGE_PMD_SIZE)) return -EINVAL; -#endif return __kvm_gmem_create(kvm, size, flags); } Paolo