From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE8BAC433F5 for ; Thu, 14 Oct 2021 07:05:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1771F6115C for ; Thu, 14 Oct 2021 07:05:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1771F6115C Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=virtuozzo.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 8C579940009; Thu, 14 Oct 2021 03:05:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8763E6B00A9; Thu, 14 Oct 2021 03:05:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7649B940009; Thu, 14 Oct 2021 03:05:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 6865C6B00A8 for ; Thu, 14 Oct 2021 03:05:48 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 27E6E2DD85 for ; Thu, 14 Oct 2021 07:05:48 +0000 (UTC) X-FDA: 78694157976.31.A33396B Received: from relay.sw.ru (relay.sw.ru [185.231.240.75]) by imf23.hostedemail.com (Postfix) with ESMTP id 27BD090000A9 for ; Thu, 14 Oct 2021 07:05:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=virtuozzo.com; s=relay; h=Content-Type:MIME-Version:Date:Message-ID:From: Subject; bh=S7LE65uhsCV8C643BVPxhF0qRh9OLtZ/h5F5Sin60rk=; b=CnQs1S9wNOJcAGp2Y W9sNTKLUwcBl2VL7C98WHGBYNOPMmAhU6ns/gVLdD8bUMuM9OsfGEExgbsTkZhUmSfJ9ToCBCEUYN w45ppZ3aM3ifjVT8c2lpQtXdbKIMq8rzMfUdz8BNNZU3PCaO5U1dAEn9J2J8zaVi/TFCLcrcYItGA =; Received: from [172.29.1.17] by relay.sw.ru with esmtp (Exim 4.94.2) (envelope-from ) id 1mauoA-005ylV-Im; Thu, 14 Oct 2021 10:05:42 +0300 Subject: Re: [PATCH] memcg: page_alloc: skip bulk allocator for __GFP_ACCOUNT To: Shakeel Butt , Johannes Weiner , Michal Hocko , Mel Gorman Cc: Uladzislau Rezki , Roman Gushchin , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20211013194338.1804247-1-shakeelb@google.com> From: Vasily Averin Message-ID: <4c92e227-2abc-c3cb-93eb-f5c45bef7fc6@virtuozzo.com> Date: Thu, 14 Oct 2021 10:05:21 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20211013194338.1804247-1-shakeelb@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 27BD090000A9 X-Stat-Signature: amu8hfb5yp76zhbydu9exxgh55e31aip Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=virtuozzo.com header.s=relay header.b=CnQs1S9w; dmarc=pass (policy=quarantine) header.from=virtuozzo.com; spf=pass (imf23.hostedemail.com: domain of vvs@virtuozzo.com designates 185.231.240.75 as permitted sender) smtp.mailfrom=vvs@virtuozzo.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634195146-857403 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 13.10.2021 22:43, Shakeel Butt wrote: > The commit 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in > __vmalloc_area_node()") switched to bulk page allocator for order 0 > allocation backing vmalloc. However bulk page allocator does not support > __GFP_ACCOUNT allocations and there are several users of > kvmalloc(__GFP_ACCOUNT). > > For now make __GFP_ACCOUNT allocations bypass bulk page allocator. In > future if there is workload that can be significantly improved with the > bulk page allocator with __GFP_ACCCOUNT support, we can revisit the > decision. > > Fixes: 5c1f4e690eec ("mm/vmalloc: switch to bulk allocator in __vmalloc_area_node()") > Signed-off-by: Shakeel Butt > --- > mm/page_alloc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 668edb16446a..b3acad4615d3 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5215,6 +5215,10 @@ unsigned long __alloc_pages_bulk(gfp_t gfp, int preferred_nid, > unsigned int alloc_flags = ALLOC_WMARK_LOW; > int nr_populated = 0, nr_account = 0; > > + /* Bulk allocator does not support memcg accounting. */ > + if (unlikely(gfp & __GFP_ACCOUNT)) > + goto out; > + May be (memcg_kmem_enabled() && (gfp & __GFP_ACCOUNT)) check is better here? > /* > * Skip populated array elements to determine if any pages need > * to be allocated before disabling IRQs. >