From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87264C433F5 for ; Wed, 6 Apr 2022 09:09:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A7946B0072; Wed, 6 Apr 2022 05:09:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 157EF6B0073; Wed, 6 Apr 2022 05:09:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F39E26B0074; Wed, 6 Apr 2022 05:09:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0107.hostedemail.com [216.40.44.107]) by kanga.kvack.org (Postfix) with ESMTP id E12836B0072 for ; Wed, 6 Apr 2022 05:09:23 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 9D5FAAB9CF for ; Wed, 6 Apr 2022 09:09:13 +0000 (UTC) X-FDA: 79325880186.23.ED1291B Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf29.hostedemail.com (Postfix) with ESMTP id CBFC012002C for ; Wed, 6 Apr 2022 09:09:12 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9E14A210F5; Wed, 6 Apr 2022 09:09:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1649236151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XztoAOcqNaq3/X/lxnWMOgV0ixpXKMfSOqrPJG0IV8w=; b=S8+YGfIXOrUKldiJ0tqUDz2yM2NcBpd9f3xIDA7BoMMi0eKolnmtAcN/uZ+ufvTX06fiQm 85w8x7Gqqc8pRFMcvI0kYoAFCadHQSrBOfh/ZXKpFTwvYAo1iZjrlmKmKkbxTH1wB63hq8 es8jNscNfP/GgtfMBCojs09VxQtZ+fo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1649236151; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XztoAOcqNaq3/X/lxnWMOgV0ixpXKMfSOqrPJG0IV8w=; b=XWVSerDhWi97xpK2/vwXwp6epgmc18PQib3jlMoS8kHYJtmaG8d+qag+1r6Sqotq9z2n8O pe0vWxlFFOzcbFCA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6AA94139F5; Wed, 6 Apr 2022 09:09:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PZhgGbdYTWLNfAAAMHmgww (envelope-from ); Wed, 06 Apr 2022 09:09:11 +0000 Message-ID: <4c8aa38f-a427-bd56-4224-7217af7f9a74@suse.cz> Date: Wed, 6 Apr 2022 11:09:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v3 4/6] mm/slub: distinguish and print stack traces in debugfs files Content-Language: en-US To: David Rientjes Cc: Christoph Lameter , Joonsoo Kim , Pekka Enberg , Roman Gushchin , Andrew Morton , linux-mm@kvack.org, patches@lists.linux.dev, linux-kernel@vger.kernel.org, Oliver Glitta , Marco Elver , Mike Rapoport , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Imran Khan References: <20220404164112.18372-1-vbabka@suse.cz> <20220404164112.18372-5-vbabka@suse.cz> From: Vlastimil Babka In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CBFC012002C X-Stat-Signature: dmqq3xannmc1buyu6pbo6zgyasm5awbm Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=S8+YGfIX; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=XWVSerDh; dmarc=none; spf=pass (imf29.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz X-Rspam-User: X-HE-Tag: 1649236152-219654 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/5/22 23:40, David Rientjes wrote: >> @@ -5116,9 +5117,13 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, >> { >> long start, end, pos; >> struct location *l; >> - unsigned long caddr; >> + unsigned long caddr, chandle; >> unsigned long age = jiffies - track->when; >> + depot_stack_handle_t handle = 0; >> >> +#ifdef CONFIG_STACKDEPOT >> + handle = READ_ONCE(track->handle); >> +#endif >> start = -1; >> end = t->count; >> >> @@ -5133,7 +5138,8 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, >> break; >> >> caddr = t->loc[pos].addr; >> - if (track->addr == caddr) { >> + chandle = t->loc[pos].handle; >> + if ((track->addr == caddr) && (handle == chandle)) { >> >> l = &t->loc[pos]; >> l->count++; >> @@ -5158,6 +5164,8 @@ static int add_location(struct loc_track *t, struct kmem_cache *s, >> >> if (track->addr < caddr) >> end = pos; >> + else if (track->addr == caddr && handle < chandle) >> + end = pos; >> else >> start = pos; >> } > > Does this need to properly handle the case where handle == NULL? Hm I can't think of how much more properly is possible. If objects have same track->addr (which is the immediate caller) and also same NULL handle, they will be counted together. I think it's the best we can do?