From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CDF8E67480 for ; Thu, 31 Oct 2024 20:55:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 135126B0082; Thu, 31 Oct 2024 16:55:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E4F46B0083; Thu, 31 Oct 2024 16:55:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEEFB6B0085; Thu, 31 Oct 2024 16:55:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D30016B0082 for ; Thu, 31 Oct 2024 16:55:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3D90DC1928 for ; Thu, 31 Oct 2024 20:55:37 +0000 (UTC) X-FDA: 82735102926.18.CB1EF2C Received: from 009.lax.mailroute.net (009.lax.mailroute.net [199.89.1.12]) by imf17.hostedemail.com (Postfix) with ESMTP id 1AA4240023 for ; Thu, 31 Oct 2024 20:55:13 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=ZtIOVQTD; spf=pass (imf17.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730408053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=B/pEQTczTiq8UIkWg7TPO3VMAg1G//4dSD/mob7u6xE=; b=SwSriL8CCOpsPRZUnU5yWEDCJCUTEzLfyA2dqd+KohGiRtZMN8gMjTBKVxICO2V/pkupkF 16k6cvZk9W4yBK9ohBxzbwnngDG5A1hZNEMPZU98cuhl5sEn2vroJxmYh0bSIpVkI/jQZH DdpUTJEnEDNNFIxhcoy7QaFfL20pwVM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730408053; a=rsa-sha256; cv=none; b=xcBWJqIpdS3H5ow7phsoe61bSFXhA4y2bNIQguJW/tMGAMDDoqPqOfpXMkOCXYAmJ01lt8 TyLbdh5DB7TCdTWGuBtFUcIqRFv7X23EmrEj+eJZhw2tCQS1XQw376QTstXRX/L9v3ttz2 JjhHRP8xkBziLS/Gv99YBSl3ATAZj/c= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=acm.org header.s=mr01 header.b=ZtIOVQTD; spf=pass (imf17.hostedemail.com: domain of bvanassche@acm.org designates 199.89.1.12 as permitted sender) smtp.mailfrom=bvanassche@acm.org; dmarc=pass (policy=reject) header.from=acm.org Received: from localhost (localhost [127.0.0.1]) by 009.lax.mailroute.net (Postfix) with ESMTP id 4XfbqT6Dh1zlgMVS; Thu, 31 Oct 2024 20:55:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=acm.org; h= content-transfer-encoding:content-type:content-type:in-reply-to :from:from:content-language:references:subject:subject :user-agent:mime-version:date:date:message-id:received:received; s=mr01; t=1730408124; x=1733000125; bh=B/pEQTczTiq8UIkWg7TPO3VM Ag1G//4dSD/mob7u6xE=; b=ZtIOVQTDUxy4QOQyeqVfTWcwWtIKOOg1Jac03tiI A7rCqvb9vtKSHPFTp3wF/OdOCTXggfRQmjW1Xz2AyQuoNB4AiXSB6jL3uB70g+in 79BqU7XO0OVtBFrfJD3PLeY1HqTIVPag3Az5jepT8ofoaTAMY/ewHawQhH4R+bvg NqlDCexeZlHL8u4+B7neARRpjrmuBRu8CaY9eoTp1+/XajADX9rfWmgbndjW9rLQ XuadQP3u1OUiJL6NnXZlZfO6UYtdFeZQhmbg7NR4i+B2vLIqZ50DBphSoU0yOLfj +sqOmryDNyCHXB3zQKpW/jPG+KIxEnZasIOEgmoiYq7Z1g== X-Virus-Scanned: by MailRoute Received: from 009.lax.mailroute.net ([127.0.0.1]) by localhost (009.lax [127.0.0.1]) (mroute_mailscanner, port 10029) with LMTP id 27aSEBHRr0Fw; Thu, 31 Oct 2024 20:55:24 +0000 (UTC) Received: from [100.66.154.22] (unknown [104.135.204.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bvanassche@acm.org) by 009.lax.mailroute.net (Postfix) with ESMTPSA id 4Xfbq63bYdzlgTWK; Thu, 31 Oct 2024 20:55:14 +0000 (UTC) Message-ID: <4c7e679a-d3e6-4426-a679-ee581b5c728c@acm.org> Date: Thu, 31 Oct 2024 13:55:11 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 1/7] block: share more code for bio addition helpers To: Leon Romanovsky , Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg Cc: Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Stat-Signature: onpurmput6hzyc6ubfz4dtqnzwq5465k X-Rspamd-Queue-Id: 1AA4240023 X-Rspam-User: X-HE-Tag: 1730408113-261029 X-HE-Meta: U2FsdGVkX18XlzpQpRqlrXa+GeyQBYX1xBqEZ7QR3CILfSSTjD0dj1MBKVC+LJkyVBGFzZgTfr9wcXlqbXDLG2znmHiybVX+ByD6fLUY0NrORSTRGi8Kpl5Xl5DwrWvTCrD/YtYBXWxQT1vaMcuTXuWq9Bv2IeBpwhrZBGnLEjF58M3EStkDPQ7rY1+JIp4cYIWavr3bOTiFEgFBnqaV8oQzA/hNCOw0dt1X3tvgjyJVq55Wc8Af2IgYEHW6h+AIXBlh0rwDtLJuXsg8QGWz8t/ZOAcFwHKqBMsiMmBa3fWrTu9cLFw2jU9ZPsXnidUfht2h4mfczvpSBJlA/xb2ppEV5YOCcFZuKIcALXmuPf+Y6yfSKJl6dQL7VJi+L5Wt/eI/MuANpDm6AmNzcgdy35/pH/rzOOmndVXHLiIhwNKEqZXxrdTnyFrBdjdgv5BwlWF42f4O1HH2SPi0qV22r2cn/Hca5BNctWYfsoHtnOd8qqVcAkmwHNKn9VcRfRnnwaCCR1tPdYCO0omjEN6zBQpuD8LMmqw0kdECN0hq97+TOeeTwy5oGBo9cFzE4AxWYlqXMGOXKXLA+IX5X7l3YVNBfHSVu3ddbnp9vl2C78SaI9i/XvrxzKa9HQAx8kWqKeCcWYTHs5PPl7sab6lh25MjYVFXgiglUWQpugpxzMIIkp2x2HuFELytGemD61L9lBLkEhS7T4mGpqZqyAy9YPu4DBp3pyQ+uFhfb+wI/h42vGYSxafWqO31TfvSowVUkqMn1X8CZxDpXr3Ks6/N3wj1WFiCBl6AYwhdLn6vtXz4X/bzfAdeKVa8LhvtkFMwrZhQBrtqWtqz4anrZtaBCNhP6duM+uw59+n4gCp4+ud08yxESJLVPW06BoE62qZO7Cx7hF/TIw4fm2/MiuGO32yWEAYA5Nqd2yJnYzhvnUD2lqKoKinW54tgtTNgwPZfEoz6qnO/7Zr6vihbPfa WHtC6WFR SOLjZ5HVxpBJyP0px0wV95xqtKvMNXpXvuuYdBe5ntsnYk8T9LM8Ysqqa1ovWTqxt1TjMEGPx2YK+DXxE5SDtkVvyPHJoytc8grV8Dn8QPNZJ/a1t17xEA1yEIFTcpx/ixTpPSkOekAROHgH/spiPJ2fNGyDiDjxQ9Fr+v1XSvNdeGuwVsSUPC8KoueKNF6vZ5ybrZQcLTiCpCA5+ZV3bUPqN/PdILZiSjOiM/nSW6YXcbpY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 10/27/24 7:21 AM, Leon Romanovsky wrote: > +static int bio_add_zone_append_page_int(struct bio *bio, struct page *page, > + unsigned int len, unsigned int offset, bool *same_page) > +{ > + struct block_device *bdev = bio->bi_bdev; > + > + if (WARN_ON_ONCE(bio_op(bio) != REQ_OP_ZONE_APPEND)) > + return 0; > + if (WARN_ON_ONCE(!bdev_is_zoned(bdev))) > + return 0; > + return bio_add_hw_page(bdev_get_queue(bdev), bio, page, len, offset, > + bdev_max_zone_append_sectors(bdev), same_page); > +} Does "_int" stand for "_internal"? If so, please consider changing it into "_impl". I think that will prevent that anyone confuses this suffix with the "int" data type. Thanks, Bart.