From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D896C3DA4A for ; Fri, 9 Aug 2024 17:20:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E78506B009A; Fri, 9 Aug 2024 13:20:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E32B96B00A2; Fri, 9 Aug 2024 13:20:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF0206B00A3; Fri, 9 Aug 2024 13:20:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B1E5F6B009A for ; Fri, 9 Aug 2024 13:20:53 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 693B3A12BD for ; Fri, 9 Aug 2024 17:20:53 +0000 (UTC) X-FDA: 82433371986.23.DC150C3 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf21.hostedemail.com (Postfix) with ESMTP id 385621C001D for ; Fri, 9 Aug 2024 17:20:51 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=SZXwZOu7; spf=pass (imf21.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.41 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723223986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V0VlmBrSrKPI0nvLOBL3lacDzUDCnPoKiOWhQVarU+s=; b=8VTY3tCNei6T0s3VAfKLnNSinYApSO8Vr/PcroSuolh+E1b1jj5kCyMEjQntad22atljMX Qg/w2bzgMEEMduypfrb4BMxBbvo5kXURcnJ4arXthdn3BWm18r4ydadZVVfqK4C6o2kFhJ VgU2V1t4QU1PjfSEF+Pt32gXpqafDXc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723223986; a=rsa-sha256; cv=none; b=YOFRBHBGLpYhYoTqf5jM6XFA6fkscD8m8tXFp0fWwkiQtscw04ZE2AagJ5JWtOiopcG8dK hKY2mBRSiXNlSdOFNe+0/z4XuTO2pD28fBhtl0eDIKmfJfmWtwDVC/6fZEy1N+x1XNN6qK dOBwbu9K/aiJ76qH6ntTyh10ywK4qnE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=SZXwZOu7; spf=pass (imf21.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.41 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: by mail-io1-f41.google.com with SMTP id ca18e2360f4ac-8223c72bfcfso8765639f.0 for ; Fri, 09 Aug 2024 10:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1723224050; x=1723828850; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=V0VlmBrSrKPI0nvLOBL3lacDzUDCnPoKiOWhQVarU+s=; b=SZXwZOu785nTG/bozZcwIZf0DOUUuipYfDUxHG9bVVhj/3bohgSdb/JSmFlJqeLWng xJ+TRvcUpaHFxeLwEmJcLsy7dOMva4UHH4YWsyN/+x/wPqeL91bZUNWIjRHfCokmN22W HyT6lVIaQxupz2YbXqUB0FM8TYvVzu4aM1b4o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723224050; x=1723828850; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V0VlmBrSrKPI0nvLOBL3lacDzUDCnPoKiOWhQVarU+s=; b=DSvuKJdTR6XVSEpCOiA6op50k27zRwadAW5BBWWznLnG3KaFP+KIr9HkCxC4s+RQJM qDr4LKIJVkoJHkL2vw3xHD7Q9hfxLnWhUaChakyejDjDUxX4R62k8OXinXF55OfZc3gV R5Bwtbr9nyE12TBIkcRbgMLZIAcS/mzMvDNX2pt5Nfbq4R8wT7JydoZkQ+3D5A4t71de hwSoPPSV7MZ0fKGAD8HGIzcKtxOA7eAFcspZSx+69AP/CTghpNQa65Y62eyo3c9pBthT 6MSzomtHeXpJ4F0X1C0VsHXFaCkq2mdEyuHqDDVzD3tAz170Nolzjva5xh/Xt44DEoOG x4IQ== X-Forwarded-Encrypted: i=1; AJvYcCVvmulEhZLu+BpgqKxs9VDgyrYNV53jOf1jDVxXdJVeOx5imX71E5e6vI3JcjsMBJHo6bdcC+TlvA==@kvack.org X-Gm-Message-State: AOJu0Yz/W0ia1cdeQiQSG8zIVQEOLFELDmJMCmYy/DbpiPE6UWuDiIj7 l4ePR26XBfREx2pyoU5EyZU8QQKmNRq6BGpMQmaRQBw8WRsDfhkKkCqw9rg4SJXkKWaWpYrNt3W V X-Google-Smtp-Source: AGHT+IFCIxawOy6BLCebkOf6m3SU/t1bf8oP/2bn7t0rnS01Eibjkom6BbLknNPEfkJ4Vfow8JDQhw== X-Received: by 2002:a5d:97ce:0:b0:81f:8f3a:5689 with SMTP id ca18e2360f4ac-8225ecc63d8mr174936339f.0.1723224049926; Fri, 09 Aug 2024 10:20:49 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ca769102e2sm19814173.10.2024.08.09.10.20.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 09 Aug 2024 10:20:49 -0700 (PDT) Message-ID: <4c709253-50de-45ee-9cbf-8bed65eff857@linuxfoundation.org> Date: Fri, 9 Aug 2024 11:20:48 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: compaction_test: Fix off by one in check_compaction() To: Dan Carpenter , Dev Jain Cc: Andrew Morton , Shuah Khan , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Shuah Khan References: <87470c06-b45a-4e83-92ff-aac2e7b9c6ba@stanley.mountain> Content-Language: en-US From: Shuah Khan In-Reply-To: <87470c06-b45a-4e83-92ff-aac2e7b9c6ba@stanley.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 385621C001D X-Stat-Signature: upyiens4x5brbginchd37pjdtdmm54po X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1723224051-934503 X-HE-Meta: U2FsdGVkX1+yVcsdsM/QKSn9Nagd94BRg3TisxP/eGKDXE/ewFsX80KEegj0OTdxjwJc3CndYkEujSP2qJHlNpuBQgs3fd0IFOKULqLRL/RSjTVdCHThbYE6IojefAr2K98nANeLPwgcbXJGjBIyLwmqn3bkkcZf3L5cYCb0EiY3qcsJQSq5dyVmlIbF1h7HtPwt8u2EV6NUzZnwGhgaV9exFn+PvBfPEb5cx8uAO+ksRrNqsIvhDVlwHIlAGpJUT7+ZClHbwVmLZfVzeHXX7bwxHsPoGoAdUAymnuuxeJbIw3kPgSvP10J1/AGW+Gp7NpQvWK9PifJZNmZw1k763l7k48hTZOzXsrXYb84bgZ7dR7vJg81JdS4nDvAV2Qv+/68lhmBbuj2g3/WL28hy+SLehKEqiINou6jzVk0H5oDjrxPF7Lre1Owob7RjvIobmdBYZxYoc6Xe1DzoRfUAyW+UkMb8Kko6zji6oYylw2xg6Iq0iQoSLGjfseSFufmzw2Edd34ZXQGhP4+HtOlsW5mypwka/J0hw32rcXELklLa+B2XwA7LZiaDK5t8xab3vNvm1JPf9+vJABrH6LVlF/SANQ3nDol/OqYvNbxygdpKE3nY9MJw63n4HADTyt4uP2pfs8uW2p9M3Ulztlv9AZ4MmO/tIYh/Kc072HYnUIqY+3LpMEdkWQRACulMsjMqZV5p7bmTGApoK6kJ8MMmjLY3kYz0gncIDGkeK+7hBLqvWV07bMgmKU924rnUWPuYSbIW5c1Qv1CQnzGBw/51dWSnOZndr0skvnnvD1U6AmF3Ir05noYQQ50Y9wOdyA8u1gtBd6AU55KcnXY5nklFb+iVkpoFhm5s5tj6laqb4ka2wSjriHqKSUKWj5ILhZb4HzzQHWl7H234VlhwWmgbarM4k9wrQIOXXXPoKjk+XWA35ohSc7JhfAOki8kTXAxI/xaO4SJ+jlKLzvuLhZ7 IitBb+U6 6gi+HfuFPyaCGscfD4iyEGrGWpZPMMHKFOMpoFEBUq17eiI7bF4GZ5yJv+Ukb+Jc5fdwT6FV1ZcmmaIQCExrGJHJv/ChFpdDQ/wD+VBD6XEQsESgrqCfy1qnH/6+7IF3ZIgW4Zs1ycUbwchNnFdaoOh916lvtl3qGavxr5hfa/5paG7Jb4UQJ0z4Cpje2SNF2Oo6fb1tInAYr5xqlHwDHTh+6Y0sloHEV16CAZmzXrUQrzEERrL5WEfkIwkA8DkWtVSQM2sVyCcZO0tPzjeVFnm9Sxa614SPCpswr0mDhtOmkJ0NXe0q+eG9CClXq46tqb+jxeFbPHuUWyvxdtoD1y6yWknflpYgSk0xcdDrUWOdNMLCR1aJ3Gtg48qNZLhlSL+C+oIhMXIEedKlbRLNOVXyer1bYK1m3aXIh1xQnX2ejUXE/9+DMM7u2LAU1tCBOJvFHs4ZEBpLU0H8/IFB7P5eNQn1yuQfL1lw2Y/KSdFuR/xk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000706, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/9/24 06:32, Dan Carpenter wrote: > The "initial_nr_hugepages" variable is unsigned long so it takes up to > 20 characters to print, plus 1 more character for the NUL terminator. > Unfortunately, this buffer is not quite large enough for the terminator > to fit. Also use snprintf() for a belt and suspenders approach. > > Fixes: fb9293b6b015 ("selftests/mm: compaction_test: fix bogus test success and reduce probability of OOM-killer invocation") > Signed-off-by: Dan Carpenter > --- > tools/testing/selftests/mm/compaction_test.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/compaction_test.c b/tools/testing/selftests/mm/compaction_test.c > index e140558e6f53..2c3a0eb6b22d 100644 > --- a/tools/testing/selftests/mm/compaction_test.c > +++ b/tools/testing/selftests/mm/compaction_test.c > @@ -89,9 +89,10 @@ int check_compaction(unsigned long mem_free, unsigned long hugepage_size, > int fd, ret = -1; > int compaction_index = 0; > char nr_hugepages[20] = {0}; > - char init_nr_hugepages[20] = {0}; > + char init_nr_hugepages[24] = {0}; Can we exceed this limit too? Can you make this a define? > > - sprintf(init_nr_hugepages, "%lu", initial_nr_hugepages); > + snprintf(init_nr_hugepages, sizeof(init_nr_hugepages), > + "%lu", initial_nr_hugepages); > > /* We want to test with 80% of available memory. Else, OOM killer comes > in to play */ With that change: Reviewed-by: Shuah Khan thanks, -- Shuah