From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3505FC433F5 for ; Fri, 18 Feb 2022 01:49:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A56F6B0075; Thu, 17 Feb 2022 20:49:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 653696B007B; Thu, 17 Feb 2022 20:49:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 542DF6B0082; Thu, 17 Feb 2022 20:49:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 44E116B0075 for ; Thu, 17 Feb 2022 20:49:42 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id EC18E97311 for ; Fri, 18 Feb 2022 01:49:41 +0000 (UTC) X-FDA: 79154218962.26.E56CC91 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf17.hostedemail.com (Postfix) with ESMTP id B483740005 for ; Fri, 18 Feb 2022 01:49:40 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4K0F2M3T1mz9sht; Fri, 18 Feb 2022 09:47:55 +0800 (CST) Received: from [10.174.177.76] (10.174.177.76) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Fri, 18 Feb 2022 09:49:34 +0800 Subject: Re: [PATCH] mm/mmu_notifiers: use helper function mmu_notifier_synchronize() To: Jason Gunthorpe CC: , , References: <20220217110948.35477-1-linmiaohe@huawei.com> <20220217155012.GC1037534@ziepe.ca> From: Miaohe Lin Message-ID: <4c7074b4-5d84-d690-d14a-18c06eacc7a0@huawei.com> Date: Fri, 18 Feb 2022 09:49:33 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20220217155012.GC1037534@ziepe.ca> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.76] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: B483740005 X-Stat-Signature: 57kadeq7h8ykatsr6tmhumbssxokn5tj X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf17.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-HE-Tag: 1645148980-76433 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/2/17 23:50, Jason Gunthorpe wrote: > On Thu, Feb 17, 2022 at 07:09:48PM +0800, Miaohe Lin wrote: >> Use helper function mmu_notifier_synchronize() to ensure all mmu_notifiers >> are freed. Minor readability improvement. >> >> Signed-off-by: Miaohe Lin >> --- >> mm/mmu_notifier.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) > > I'm not keen on this, the internal synchronize_srcu's don't have the > same usage model as described in the comment for > mmu_notifier_synchronize(). Instead they are doing what their comments > say. > > Yes, it is the same code, but the purpose is different. > Yep, this is my overlook. Many thanks for reply. > Jason > . >