From: David Hildenbrand <david@redhat.com>
To: John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jeff Xu <jeffxu@chromium.org>, Shuah Khan <shuah@kernel.org>
Cc: Andrei Vagin <avagin@google.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Christian Brauner <brauner@kernel.org>,
Kees Cook <kees@kernel.org>,
Kent Overstreet <kent.overstreet@linux.dev>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
Muhammad Usama Anjum <usama.anjum@collabora.com>,
Peter Xu <peterx@redhat.com>, Rich Felker <dalias@libc.org>,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items
Date: Fri, 14 Jun 2024 14:28:38 +0200 [thread overview]
Message-ID: <4c6ffb1e-0381-4d5e-afa2-f8809f0b445f@redhat.com> (raw)
In-Reply-To: <20240614023009.221547-3-jhubbard@nvidia.com>
On 14.06.24 04:30, John Hubbard wrote:
> Clean up and move some copy-pasted items into a new mseal_helpers.h.
>
> 1. The test macros can be made safer and simpler, by observing that they
> are invariably called when about to return. This means that the macros
> do not need an intrusive label to goto; they can simply return.
>
> 2. PKEY* items. We cannot, unfortunately use pkey-helpers.h. The best we
> can do is to factor out these few items into mseal_helpers.h.
>
> 3. These tests still need their own definition of u64, so also move that
> to the header file.
>
> Cc: Jeff Xu <jeffxu@chromium.org>
> Cc: David Hildenbrand <david@redhat.com>
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
Acked-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-06-14 12:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-14 2:30 [PATCH v2 0/6] cleanups, fixes, and progress towards avoiding "make headers" John Hubbard
2024-06-14 2:30 ` [PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal John Hubbard
2024-06-14 12:28 ` David Hildenbrand
2024-06-14 12:41 ` David Hildenbrand
2024-06-14 18:02 ` John Hubbard
2024-06-17 18:11 ` David Hildenbrand
2024-06-18 1:52 ` John Hubbard
2024-06-14 2:30 ` [PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items John Hubbard
2024-06-14 12:28 ` David Hildenbrand [this message]
2024-06-14 14:56 ` Jeff Xu
2024-06-14 2:30 ` [PATCH v2 3/6] selftests/mm: mseal, self_elf: rename TEST_END_CHECK to REPORT_TEST_PASS John Hubbard
2024-06-14 12:29 ` David Hildenbrand
2024-06-14 2:30 ` [PATCH v2 4/6] selftests/mm: fix vm_util.c build failures: add snapshot of fs.h John Hubbard
2024-06-14 12:29 ` David Hildenbrand
2024-06-14 2:30 ` [PATCH v2 5/6] selftests/mm: kvm, mdwe fixes to avoid requiring "make headers" John Hubbard
2024-06-14 12:31 ` David Hildenbrand
2024-06-15 0:09 ` John Hubbard
2024-06-14 2:30 ` [PATCH v2 6/6] selftests/mm: remove local __NR_* definitions John Hubbard
2024-06-14 12:32 ` David Hildenbrand
2025-02-12 20:34 ` Dave Hansen
2025-02-12 22:31 ` John Hubbard
2025-02-13 11:32 ` Li Wang
2025-02-13 20:47 ` John Hubbard
2025-02-13 8:04 ` John Hubbard
2025-02-13 15:00 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c6ffb1e-0381-4d5e-afa2-f8809f0b445f@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=avagin@google.com \
--cc=axelrasmussen@google.com \
--cc=brauner@kernel.org \
--cc=dalias@libc.org \
--cc=jeffxu@chromium.org \
--cc=jhubbard@nvidia.com \
--cc=kees@kernel.org \
--cc=kent.overstreet@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterx@redhat.com \
--cc=shuah@kernel.org \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox