From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29EA2C433FE for ; Mon, 14 Nov 2022 02:35:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7863A8E0001; Sun, 13 Nov 2022 21:35:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 734316B0073; Sun, 13 Nov 2022 21:35:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5FB8A8E0001; Sun, 13 Nov 2022 21:35:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 4D9E76B0072 for ; Sun, 13 Nov 2022 21:35:10 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 07B2F120974 for ; Mon, 14 Nov 2022 02:35:09 +0000 (UTC) X-FDA: 80130480738.15.9BC415D Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf26.hostedemail.com (Postfix) with ESMTP id E2E0214000B for ; Mon, 14 Nov 2022 02:35:06 +0000 (UTC) Received: from canpemm500002.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N9YL13TqpzHvrF; Mon, 14 Nov 2022 10:34:33 +0800 (CST) Received: from [10.174.151.185] (10.174.151.185) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Mon, 14 Nov 2022 10:35:01 +0800 Subject: Re: [syzbot] possible deadlock in hugetlb_fault To: Dmitry Vyukov CC: Mike Kravetz , syzbot , , , , , , , , , References: <0000000000008c742d05eca72d4d@google.com> From: Miaohe Lin Message-ID: <4c5fa6b4-6278-ce2b-73c2-883eb734bdc7@huawei.com> Date: Mon, 14 Nov 2022 10:35:01 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.151.185] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To canpemm500002.china.huawei.com (7.192.104.244) X-CFilter-Loop: Reflected ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1668393307; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PidjPkMAwjmCy8epoHYyskiY+BYXXnOEoKjyza19Loc=; b=jPhwIJbEU5n//Yr/LqBENVNIVO++KHO1vHNUVTnW8xc8XmmyZsUGZuk8Q7DbhKPvZka1YN 9BiopBrhsz40hBw6gHpqH4n7nFlKhBnUvdisWaZituj+GH6oCjpynsK8Bh4IV8LMSU7UuG RiZhTx9rh4Y/P0d05CISO5T7YvES2Jw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1668393307; a=rsa-sha256; cv=none; b=RZQyQpxsd/8MdQjzexri0bKZPhdKQQoIjMS6m0aQANYccr1IUceDYX2esRVm2S2mmrub86 bDBvZSjJHMj9eTGo+5iiqxVVFEk1NnOXlZpzL45MTd9m7NW/l31BFeDQIZVDZKQFurL+k3 jGOeFSkIIjb6icwi1x3O+0CpYMhg1fw= X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E2E0214000B X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf26.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com X-Stat-Signature: mpxyoeh5trhgzhjauqihyhcduo5wmt96 X-HE-Tag: 1668393306-361635 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/11/12 22:14, Dmitry Vyukov wrote: > On Sat, 12 Nov 2022 at 12:33, Dmitry Vyukov wrote: >> >> On Sat, 12 Nov 2022 at 05:02, 'Miaohe Lin' via syzkaller-bugs >> wrote: >>> >>> On 2022/11/12 8:07, Mike Kravetz wrote: >>>> On 11/04/22 09:00, syzbot wrote: >>>>> Hello, >>>>> >>>>> syzbot found the following issue on: >>>>> >>>>> HEAD commit: f2f32f8af2b0 Merge tag 'for-6.1-rc3-tag' of git://git.kern.. >>>>> git tree: upstream >>>>> console output: https://syzkaller.appspot.com/x/log.txt?x=137d52ca880000 >>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=d080a4bd239918dd >>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=ca56f14c500045350f93 >>>>> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 >>>>> userspace arch: i386 >>>>> >>>>> Unfortunately, I don't have any reproducer for this issue yet. >>>>> >>>>> Downloadable assets: >>>>> disk image: https://storage.googleapis.com/syzbot-assets/b4f72e7a4c11/disk-f2f32f8a.raw.xz >>>>> vmlinux: https://storage.googleapis.com/syzbot-assets/3f88997ad7c9/vmlinux-f2f32f8a.xz >>>>> kernel image: https://storage.googleapis.com/syzbot-assets/b4b5b3963e2d/bzImage-f2f32f8a.xz >>>>> >>>>> IMPORTANT: if you fix the issue, please add the following tag to the commit: >>>>> Reported-by: syzbot+ca56f14c500045350f93@syzkaller.appspotmail.com >>>>> >>>>> ====================================================== >>>>> WARNING: possible circular locking dependency detected >>>>> 6.1.0-rc3-syzkaller-00152-gf2f32f8af2b0 #0 Not tainted >>>>> ------------------------------------------------------ >>>>> syz-executor.2/5665 is trying to acquire lock: >>>>> ffff88801c74c298 (&mm->mmap_lock#2){++++}-{3:3}, at: __might_fault+0xa1/0x170 mm/memory.c:5645 >>>>> >>>>> but task is already holding lock: >>>>> ffff88801c4f3078 (&vma_lock->rw_sema){++++}-{3:3}, at: hugetlb_vma_lock_read mm/hugetlb.c:6816 [inline] >>>>> ffff88801c4f3078 (&vma_lock->rw_sema){++++}-{3:3}, at: hugetlb_fault+0x40a/0x2060 mm/hugetlb.c:5859 >>>>> >>>>> which lock already depends on the new lock. >>>>> >>>>> >>>>> the existing dependency chain (in reverse order) is: >>>>> >>>>> -> #1 (&vma_lock->rw_sema){++++}-{3:3}: >>>>> down_write+0x90/0x220 kernel/locking/rwsem.c:1562 >>>>> hugetlb_vma_lock_write mm/hugetlb.c:6834 [inline] >>>>> __unmap_hugepage_range_final+0x97/0x340 mm/hugetlb.c:5202 >>>>> unmap_single_vma+0x23d/0x2a0 mm/memory.c:1690 >>>>> unmap_vmas+0x21e/0x370 mm/memory.c:1733 >>>>> exit_mmap+0x189/0x7a0 mm/mmap.c:3090 >>>>> __mmput+0x128/0x4c0 kernel/fork.c:1185 >>>>> mmput+0x5c/0x70 kernel/fork.c:1207 >>>>> exit_mm kernel/exit.c:516 [inline] >>>>> do_exit+0xa39/0x2a20 kernel/exit.c:807 >>>>> do_group_exit+0xd0/0x2a0 kernel/exit.c:950 >>>>> get_signal+0x21a1/0x2430 kernel/signal.c:2858 >>>>> arch_do_signal_or_restart+0x82/0x2300 arch/x86/kernel/signal.c:869 >>>>> exit_to_user_mode_loop kernel/entry/common.c:168 [inline] >>>>> exit_to_user_mode_prepare+0x15f/0x250 kernel/entry/common.c:203 >>>>> __syscall_exit_to_user_mode_work kernel/entry/common.c:285 [inline] >>>>> syscall_exit_to_user_mode+0x19/0x50 kernel/entry/common.c:296 >>>>> __do_fast_syscall_32+0x72/0xf0 arch/x86/entry/common.c:181 >>>>> do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 >>>>> entry_SYSENTER_compat_after_hwframe+0x70/0x82 >>>>> >>>>> -> #0 (&mm->mmap_lock#2){++++}-{3:3}: >>>>> check_prev_add kernel/locking/lockdep.c:3097 [inline] >>>>> check_prevs_add kernel/locking/lockdep.c:3216 [inline] >>>>> validate_chain kernel/locking/lockdep.c:3831 [inline] >>>>> __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 >>>>> lock_acquire kernel/locking/lockdep.c:5668 [inline] >>>>> lock_acquire+0x1df/0x630 kernel/locking/lockdep.c:5633 >>>>> __might_fault mm/memory.c:5646 [inline] >>>>> __might_fault+0x104/0x170 mm/memory.c:5639 >>>>> _copy_from_user+0x25/0x170 lib/usercopy.c:13 >>>>> copy_from_user include/linux/uaccess.h:161 [inline] >>>>> snd_rawmidi_kernel_write1+0x366/0x880 sound/core/rawmidi.c:1549 >>>>> snd_rawmidi_write+0x273/0xbb0 sound/core/rawmidi.c:1618 >>>>> vfs_write+0x2d7/0xdd0 fs/read_write.c:582 >>>>> ksys_write+0x1e8/0x250 fs/read_write.c:637 >>>>> do_syscall_32_irqs_on arch/x86/entry/common.c:112 [inline] >>>>> __do_fast_syscall_32+0x65/0xf0 arch/x86/entry/common.c:178 >>>>> do_fast_syscall_32+0x2f/0x70 arch/x86/entry/common.c:203 >>>>> entry_SYSENTER_compat_after_hwframe+0x70/0x82 >>>>> >>>>> other info that might help us debug this: >>>>> >>>>> Possible unsafe locking scenario: >>>>> >>>>> CPU0 CPU1 >>>>> ---- ---- >>>>> lock(&vma_lock->rw_sema); >>>>> lock(&mm->mmap_lock#2); >>>>> lock(&vma_lock->rw_sema); >>>>> lock(&mm->mmap_lock#2); >>>> >>>> I may not be reading the report correctly, but I can not see how we acquire the >>>> hugetlb vma_lock before trying to acquire mmap_lock in stack 0. We would not >>>> acquire the vma_lock until we enter hugetlb fault processing (not in the stack). >> >> The unlock of vma_lock is conditional: >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/mm/hugetlb.c?id=f2f32f8af2b0ca9d619e5183eae3eed431793baf#n6840 >> >> and the condition is: >> >> static bool __vma_shareable_flags_pmd(struct vm_area_struct *vma) >> { >> return vma->vm_flags & (VM_MAYSHARE | VM_SHARED) && >> vma->vm_private_data; >> } >> >> Is it possible that the condition has changed between vma lock and unlock? >> What mutexes protect vma->vm_flags/vm_private_data? >> >> That would make the report perfectly sensible. >> >> FWIW the test case that was running is this, that's the syscalls that >> were running concurrently: >> >> 07:56:56 executing program 2: >> r0 = syz_open_dev$sndmidi(&(0x7f0000000040), 0x2, 0x141101) >> r1 = dup(r0) >> setsockopt$inet_sctp_SCTP_I_WANT_MAPPED_V4_ADDR(r1, 0x84, 0xc, >> &(0x7f0000000080), 0x4) (async) >> write$6lowpan_enable(r1, &(0x7f0000000000)='0', 0xc86ade39) (async) >> mmap(&(0x7f0000000000/0xb36000)=nil, 0xb36000, 0x3, 0x68831, >> 0xffffffffffffffff, 0x0) (async) >> madvise(&(0x7f0000000000/0x600000)=nil, 0x600003, 0x4) (async, rerun: 32) >> mremap(&(0x7f00007a0000/0x3000)=nil, 0x3000, 0x2000, 0x7, >> &(0x7f0000835000/0x2000)=nil) (rerun: 32) > > > This new bug report seems to confirm the hypothesis: > > WARNING: locking bug in hugetlb_no_page > https://syzkaller.appspot.com/bug?extid=d07c65298d2c15eafcb0 Thanks Dmitry! I believe Mike found the root cause and his proposed patches in next-20221111 will fix the problem: https://lore.kernel.org/linux-mm/20221111232628.290160-1-mike.kravetz@oracle.com/ Let's keep looking. :) Thanks for your work! Thanks, Miaohe Lin > > >>>> Adding Miaohe Lin on Cc due to previous help with vma_lock potential deadlock >>>> situations. Miaohe, does this make sense to you? >>>> >>> >>> Hi Mike, >>> This doesn't make sense for me too. Stack #1 shows that syz-executor is releasing >>> its address space while stack #0 shows another thread is serving the write syscall. >>> In this case, mm->mm_users is 0 and all threads in this process should be serving >>> do_exit()? But I could be easily wrong. Also I can't see how vma_lock is locked before >>> trying to acquire mmap_lock in above stacks. Might this be a false positive? > . >